[Codenarc-user] Reorganizing the Basic RuleSet

[Chris M. <chr...@ea...>]

Here is my plan for reorganizing the CodeNarc "Basic" ruleset.

This will include adding three new rulesets:

1.    "String" - String-related rules

2.    "Groovyism" - Groovy idiomatic usage, and Groovy-specific bad
practices

3.    "Convention" - Coding conventions; not typically errors; might end up
become something of a "miscellaneous" set.

Current Basic RuleSet and (New Destination)

The rules in bold will stay in the Basic ruleset.

.         AddEmptyString                                (string)

.         AssignCollectionSort                          (groovyism)

.         AssignCollectionUnique                       (groovyism)

.         AssignmentInConditional

.         BigDecimalInstantiation

.         BitwiseOperatorInConditional

.         BooleanGetBoolean

.         BooleanMethodReturnsNull

.         BrokenOddnessCheck

.         ClassForName

.         CloneableWithoutClone                       (design)

.         ClosureAsLastMethodParameter           (groovyism)

.         CollectAllIsDeprecated                        (groovyism)

.         CompareToWithoutComparable            (design)

.         ComparisonOfTwoConstants

.         ComparisonWithSelf

.         ConfusingMultipleReturns                    (groovyism)

.         ConfusingTernary                             (convention)

.         ConsecutiveLiteralAppends                  (string)

.         ConsecutiveStringConcatenation           (string)

.         ConstantIfExpression

.         ConstantTernaryExpression

.         CouldBeElvis                                     (convention)

.         DeadCode

.         DoubleNegative

.         DuplicateCaseStatement

.         DuplicateMapKey

.         DuplicateSetValue

.         EmptyCatchBlock

.         EmptyElseBlock

.         EmptyFinallyBlock

.         EmptyForStatement

.         EmptyIfStatement

.         EmptyInstanceInitializer

.         EmptyMethod

.         EmptyStaticInitializer

.         EmptySwitchStatement

.         EmptySynchronizedStatement

.         EmptyTryBlock

.         EmptyWhileStatement

.         EqualsAndHashCode

.         EqualsOverloaded

.         ExplicitArrayListInstantiation                (groovyism)

.         ExplicitCallToAndMethod                     (groovyism)

.         ExplicitCallToCompareToMethod           (groovyism)

.         ExplicitCallToDivMethod                      (groovyism)

.         ExplicitCallToEqualsMethod                  (groovyism)

.         ExplicitCallToGetAtMethod                   (groovyism)

.         ExplicitCallToLeftShiftMethod               (groovyism)

.         ExplicitCallToMinusMethod                   (groovyism)

.         ExplicitCallToModMethod                     (groovyism)

.         ExplicitCallToMultiplyMethod                 (groovyism)

.         ExplicitCallToOrMethod                       (groovyism)

.         ExplicitCallToPlusMethod                     (groovyism)

.         ExplicitCallToPowerMethod                  (groovyism)

.         ExplicitCallToRightShiftMethod              (groovyism)

.         ExplicitCallToXorMethod                      (groovyism)

.         ExplicitGarbageCollection               

.         ExplicitHashMapInstantiation                (groovyism)

.         ExplicitHashSetInstantiation                 (groovyism)

.         ExplicitLinkedHashMapInstantiation       (groovyism)

.         ExplicitLinkedListInstantiation               (groovyism)

.         ExplicitStackInstantiation                     (groovyism)

.         ExplicitTreeSetInstantiation                 (groovyism)

.         ForLoopShouldBeWhileLoop            

.         GStringAsMapKey                             (groovyism)

.         GroovyLangImmutable                       (groovyism)

.         HardCodedWindowsFileSeparator

.         HardcodedWindowsRootDirectory 

.         IntegerGetInteger

.         InvertedIfElse                                   (convention)

.         LongLiteralWithLowerCaseL                 (convention)

.         RandomDoubleCoercedToZero                  

.         RemoveAllOnSelf                                     

.         ReturnFromFinallyBlock

.         ReturnsNullInsteadOfEmptyArray         (design)

.         ReturnsNullInsteadOfEmptyCollection    (design)

.         SimpleDateFormatMissingLocale           (design) (or convention?)

.         ThrowExceptionFromFinallyBlock

.         UseCollectMany                                (groovyism)

.         UseCollectNested                              (groovyism)