[Codenarc-developer] Patch: issue 3411724

[Hamlet D. <ham...@ca...>]

Hi Chris, 

Again I have no time to merge this patch. 

Did you see this patch in the issue tracker? 

Thanks, 



----- Original Message -----
> Feature Requests item #3420629, was opened at 2011-10-08 20:01
> Message generated for change (Comment added) made by joachim-baumann
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=1126575&aid=3420629&group_id=250145
> 
> Please note that this message will contain a full copy of the comment
> thread,
> including the initial issue submission, for this request,
> not just the latest update.
> Category: None
> Group: None
> Status: Open
> Priority: 5
> Private: No
> Submitted By: Joachim Baumann (joachim-baumann)
> Assigned to: Nobody/Anonymous (nobody)
> Summary: Patch: issue 3411724
> 
> Initial Comment:
> Two rules implementing the two potential problems described in issue
> 3411724 regarding the method collectNested{}
> 
> 
> ----------------------------------------------------------------------
> 
> >Comment By: Joachim Baumann (joachim-baumann)
> Date: 2011-10-09 09:33
> 
> Message:
> I forgot to mention the three assumptions underlying the code for
> collectNested-rule regarding multiple collect calls.
> 1. The treewalk is depth-first
> 2. a whole subtree is walked by one instance of the visitor object
> 3. an instance of the visitor object is not used in parallel
> 
> If the first assumption is incorrect, then the algorithm identifying
> the
> collect statements would not work.
> 
> The other assumptions are with regard to the data held in the visitor
> object. If these assumptions were incorrect the variable used to
> store the
> parameters of the surrounding closure would have to be implemented
> differently.
> 
> ----------------------------------------------------------------------
> 
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=1126575&aid=3420629&group_id=250145
>