Re: [Codenarc-user] Grails plugin - enable all rulessets target?

[Olivier G. <ogo...@sm...>]

I think if people have not specified the ruleset files they want, we can
assume they want the default ones. It is currently only 3 but you could
change the default in a new version of the plugin and include all the ones
you mention. If suddenly they get too many violations, then they will have
to ead the doc and explicitly state the ones they are interested in.

The problem with your approach is that if you want to promote a new category
(ruleset file), nobody will know about it unless they happen to read about
it and explicitly add it.

My 2c.

PS: also, codenarc should be able to recognize when ruleSetFiles is a
collection: users should not have to add ".join(',').toString()"..


On Thu, Aug 18, 2011 at 4:07 AM, Hamlet DArcy <ham...@ca...>wrote:

> I am using the Grails plugin.
>
> By default, only three rulessets are used. I think we should encourage
> people to use more of the rulesets.
>
> What do you think of adding a switch to the codenarc target, like this:
>
>  grails codenarc -enableAllRulesets
>
> And when you run this, BuildConfig.groovy has this text appended to it:
>
> codenarc.ruleSetFiles=[
>        'rulesets/basic.xml',
>        'rulesets/braces.xml',
>        'rulesets/concurrency.xml',
>        'rulesets/design.xml',
>        'rulesets/exceptions.xml',
>        'rulesets/formatting.xml',
>        'rulesets/grails.xml',
>        'rulesets/imports.xml',
>        'rulesets/jdbc.xml',
>        'rulesets/junit.xml',
>        'rulesets/logging.xml',
>        'rulesets/naming.xml',
>        'rulesets/security.xml',
>        'rulesets/serialization.xml',
>        'rulesets/size.xml',
>        'rulesets/unnecessary.xml',
>        'rulesets/unused.xml'].join(',').toString()
>
> What do you think? Is this a good idea?
> --
> Hamlet D'Arcy
> ham...@ca...
>
>
>
> ------------------------------------------------------------------------------
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
> user administration capabilities and model configuration. Take
> the hassle out of deploying and managing Subversion and the
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> _______________________________________________
> Codenarc-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-user
>