Re: [Codenarc-developer] Running CodeNarc with a Groovy 1.8 Runtime

[<chr...@we...>]

I am fine with that. It seems like a good idea. Would you want to delay the 0.15 release for that?

From: Hamlet D'Arcy [mailto:ham...@gm...]
Sent: Monday, August 01, 2011 8:43 AM
To: Mair, Christopher
Cc: Cod...@li...
Subject: Re: [Codenarc-developer] Running CodeNarc with a Groovy 1.8 Runtime


I would rewrite just the abstract classes and ASTUtil class. Probably 4 classes max.

--
Hamlet D'Arcy
ham...@gm...<mailto:ham...@gm...>

On Aug 1, 2011 1:52 PM, <chr...@we...<mailto:chr...@we...>> wrote:
>>> I am tempted to rewrite our AST visitor classes and ASTUtil classes in Java,
>>> and the rules themselves can be left in Groovy.
>
> Do you mean all of the AST visitor classes -- 200+ -- one for almost every rule? That would be a major effort, right?
>
> -----Original Message-----
> From: Hamlet D'Arcy [mailto:ham...@gm...<mailto:ham...@gm...>]
> Sent: Monday, August 01, 2011 3:25 AM
> To: Cod...@li...<mailto:Cod...@li...>; Cod...@li...<mailto:Cod...@li...>
> Subject: [Codenarc-developer] Running CodeNarc with a Groovy 1.8 Runtime
>
> Hi all,
>
> As many know, running CodeNarc 0.14 with a Groovy 1.8 runtime produces
> many stack overflow exceptions. This issue is fixed in the next
> release, 0.15.
>
> The problem is a base problem with Groovy. Method dispatch to the
> super class is subtly broken in some class hierarchies when the parent
> class is compiled Java. It would be nice if you would vote for the
> issue so that we can remove the workaround from our codebase:
> http://jira.codehaus.org/browse/GROOVY-4922
>
> Note for CodeNarc Developers: I am tempted to rewrite our AST visitor
> classes and ASTUtil classes in Java, and the rules themselves can be
> left in Groovy. The underlying problem of method dispatch between code
> compiled with 1.7 and running with 1.8 remains and is worrying. The
> rewrite of that small part of CodeNarc would fix the problem for good
> and also give some nice performance improvements. I feel like CodeNarc
> is at the same place Gradle was about 2 years ago... the core is
> implemented in Groovy but as the project grows the benefits of a Java
> core start to show themselves. With a Java core we'll have a little
> more safety, a little better performance, and a little more room to
> grow. What do you think?
>
> Thanks,
>
> --
> Hamlet D'Arcy
> ham...@gm...<mailto:ham...@gm...>
>
> ------------------------------------------------------------------------------
> Got Input? Slashdot Needs You.
> Take our quick survey online. Come on, we don't ask for help often.
> Plus, you'll get a chance to win $100 to spend on ThinkGeek.
> http://p.sf.net/sfu/slashdot-survey
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...<mailto:Cod...@li...>
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>
> ------------------------------------------------------------------------------
> Got Input? Slashdot Needs You.
> Take our quick survey online. Come on, we don't ask for help often.
> Plus, you'll get a chance to win $100 to spend on ThinkGeek.
> http://p.sf.net/sfu/slashdot-survey
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...<mailto:Cod...@li...>
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer