Re: [Codenarc-developer] Some additional rules

[Hamlet D'A. <ham...@gm...>]

I'd love to hear more ideas for Grails rules. What are the grails best
practices that get enforced during code reviews?

On Mon, Jul 4, 2011 at 6:03 PM, Rafael Luque Leiva
<raf...@os...> wrote:
>
> Hi Hamlet,
>
> Great news! We're proud to contribute to the project and we'd like to
> develop more additional rules in the future.
>
> We will take a look to your changes (mainly to learn from them). I've
> noticed that you have ported also GrailsDomainHasEqualsRule and
> GrailsDomainHasToStringRule.
>
> Thank you.
>
> Rafael Luque
>
> 2011/7/2 Hamlet DArcy <ham...@ca...>
>>
>> Hi Everyone,
>>
>> I checked in all of the rules from the extra-codenarc-rules project into
>> CodeNarc 0.15 branch.
>>
>> They are all here:
>> http://codenarc.svn.sourceforge.net/viewvc/codenarc/trunk/src/main/groovy/org/codenarc/rule/formatting/
>>
>> The original author should take a look at my changes. I expanded most of
>> the rules. Among the things I added:
>> * explicit support for the @SuppressWarnings annotation
>> * better handling of multi-line elements (such as when a method
>> declaration spans multiple lines)
>> * some parameters, like if Javadoc is required on inner classes.
>> * swapped some parameters from default false to default true (by default,
>> braces should appear on same line)
>>
>> This was really great work. Thank you for letting us merge it to 0.15.
>>
>>
>>
>>
>> ----- Original Message -----
>> > What is the copyright on this stuff?
>> >
>> > Some of the files say:
>> > /*
>> >  * Copyright 2009, Osoco. All Rights Reserved.
>> >  */
>> >
>> >
>> > Is this open source or copyright of Osoco?
>> >
>> >
>> >
>> > ----- Original Message -----
>> > > Thank you Hamlet.
>> > >
>> > > And, you are right about the CopyrightComment rule.
>> > >
>> > > Bests,
>> > >
>> > > Rafael Luque
>> > >
>> > >
>> > > 2011/6/22 Hamlet DArcy < ham...@ca... >
>> > >
>> > >
>> > > Very cool, I am sure we can use these.
>> > >
>> > > However, the CopyrightComment.groovy can be replaced by the
>> > > standard
>> > > "RequiredRegex" rule.
>> > >
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > ----- Original Message -----
>> > > >
>> > > >
>> > > > Hi all,
>> > > >
>> > > > At OSOCO we are using CodeNarc some time ago and our intention is
>> > > > to
>> > > > be able to write our corporate coding conventions as a CodeNarc
>> > > > ruleset. For that purpose we have written some extra rules that
>> > > > we
>> > > > need and have pushed them to our public repo at GitHub:
>> > > >
>> > > > https://github.com/osoco/extra-codenarc-rules
>> > > >
>> > > > Perhaps you can find some of these rules useful in a general way
>> > > > and
>> > > > we can contribute them to the project.
>> > > >
>> > > > Best regards,
>> > > >
>> > > > Rafael Luque
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > ------------------------------------------------------------------------------
>> > > > Simplify data backup and recovery for your virtual environment
>> > > > with
>> > > > vRanger.
>> > > > Installation's a snap, and flexible recovery options mean your
>> > > > data
>> > > > is safe,
>> > > > secure and there when you need it. Data protection magic?
>> > > > Nope - It's vRanger. Get your free trial download today.
>> > > > http://p.sf.net/sfu/quest-sfdev2dev
>> > > > _______________________________________________
>> > > > Codenarc-developer mailing list
>> > > > Cod...@li...
>> > > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>> > > >
>> > >
>> > >
>> >
>
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>
>



-- 
Hamlet D'Arcy
ham...@gm...