Re: [Codenarc-user] implementing Cloneable

[Hamlet D. <ham...@ca...>]

CodeNarc 0.14 does not give a warning for your code. It does however give this warning: 

line: 2 UnnecessaryOverridingMethod The method clone contains no logic and can be safely deleted source: Dummy clone() {super.clone()} 

But that seems OK... you're overriding a method from the parent and doing nothing other than calling the parent. 


----- Original Message -----
> No, it shouldn't, I think, but I wanted to see how it behaves there
> and wasn't able to know due to the bug in the currently released
> version.
> 
> Did you try it by the way? Because with CodeNarc Grails plugin 0.9,
> we are seeing CN warnings about such cloning, which is why I started
> trying it in the first place.
> 
> ---------------------------------------------------
> Sent from BlackBerry
> 
> -----Original Message-----
> From: Hamlet DArcy <ham...@ca...>
> Date: Mon, 04 Jul 2011 15:39:55
> To: Roshan Dawrani<ros...@gm...>
> Cc: <cod...@li...>; René
> Scheibe<ren...@go...>
> Subject: Re: [Codenarc-user] implementing Cloneable
> 
> It doesn't look at the return type.
> 
> Should it? It probably doesn't matter.
> 
> 
> ----- Original Message -----
> >
> > That sounds good, Rene. However, it stops me from trying what I
> > originally wanted to try (since I am not on codenarc dev snapshot,
> > but using it through Codenarc Grails plugin 0.9)
> >
> >
> > My original intent was to see the CodeNarc behavior for covariant
> > methods, i.e., if my code is:
> >
> >
> > ----------------------------------------------------------
> > class Dummy implements Cloneable {
> > Dummy clone() {super.clone()}
> > }
> > ----------------------------------------------------------
> >
> >
> > Does CodeNarc like this covariant method or not is what I wanted to
> > see. Would it possible for you to give a quick check?
> >
> >
> > Thanks.
> >
> >
> >
> >
> > On Mon, Jul 4, 2011 at 6:47 PM, René Scheibe <
> > ren...@go... > wrote:
> >
> >
> > There is bug in v0.14. It's already fixed in the current
> > development
> > version
> > (
> > http://sourceforge.net/tracker/?func=detail&aid=3317632&group_id=250145&atid=1126573
> > ).
> > It will be rolled out with the next release.
> >
> > Regards,
> > René Scheibe
> >
> >
> >
> >
> >
> > On 07/04/2011 02:28 PM, Roshan Dawrani wrote:
> > > Hi,
> > >
> > > Can someone help me see what is wrong in the following code:
> > > -------------------------------------------------------------------------------
> > > class Dummy implements Cloneable {
> > > Object clone() {
> > > super.clone()
> > > }
> > > }
> > > -------------------------------------------------------------------------------
> > >
> > > CodeNarc output shows and I can't figure out how to make it
> > > happy:
> > > -------------------------------------------------------------------------------
> > > line: 1 CloneableWithoutClone The class Dummy implements
> > > Cloneable
> > > but
> > > does not define a proper clone() method source: class Dummy
> > > implements
> > > Cloneable {
> > > -------------------------------------------------------------------------------
> > >
> > > --
> > > Roshan
> > > Blog: http://roshandawrani.wordpress.com/
> > > Twitter: @roshandawrani < http://twitter.com/roshandawrani >
> >
> >
> >
> > > Skype: roshandawrani
> > >
> > >
> > >
> > > ------------------------------------------------------------------------------
> > > All of the data generated in your IT infrastructure is seriously
> > > valuable.
> > > Why? It contains a definitive record of application performance,
> > > security
> > > threats, fraudulent activity, and more. Splunk takes this data
> > > and
> > > makes
> > > sense of it. IT sense. And common sense.
> > > http://p.sf.net/sfu/splunk-d2d-c2
> > >
> > >
> > >
> > >_______________________________________________
> > > Codenarc-user mailing list
> > > Cod...@li...
> > > https://lists.sourceforge.net/lists/listinfo/codenarc-user
> >
> >
> > ------------------------------------------------------------------------------
> > All of the data generated in your IT infrastructure is seriously
> > valuable.
> > Why? It contains a definitive record of application performance,
> > security
> > threats, fraudulent activity, and more. Splunk takes this data and
> > makes
> > sense of it. IT sense. And common sense.
> > http://p.sf.net/sfu/splunk-d2d-c2
> >_______________________________________________
> > Codenarc-user mailing list
> > Cod...@li...
> > https://lists.sourceforge.net/lists/listinfo/codenarc-user
> >
> >
> >
> > --
> > Roshan
> > Blog: http://roshandawrani.wordpress.com/
> > Twitter: @roshandawrani
> > Skype: roshandawrani
> >
> >
> > ------------------------------------------------------------------------------
> > All of the data generated in your IT infrastructure is seriously
> > valuable.
> > Why? It contains a definitive record of application performance,
> > security
> > threats, fraudulent activity, and more. Splunk takes this data and
> > makes
> > sense of it. IT sense. And common sense.
> > http://p.sf.net/sfu/splunk-d2d-c2
> >_______________________________________________
> > Codenarc-user mailing list
> > Cod...@li...
> > https://lists.sourceforge.net/lists/listinfo/codenarc-user
> >
>