Re: [Codenarc-developer] Util Classes
Brought to you by:
chrismair
From: <chr...@we...> - 2011-06-08 13:09:12
|
I view *Util classes as potential code smells anyway -- always subject to refactoring. If you feel like a ClassNodeUtil class makes sense, that sounds fine to me. I'd be inclined to wait until after 0.14 to make that change (even though I am confident our test suite would catch errors if it introduced any). -----Original Message----- From: Hamlet DArcy [mailto:ham...@ca...] Sent: Wednesday, June 08, 2011 9:04 AM To: Mair, Christopher Cc: cod...@li... Subject: Re: [Codenarc-developer] Util Classes I thought about breaking apart AstUtil... but I am not sure about it. There is value in having all those methods all in the same place. But there would also be value in having a ClassNodeUtil that works on ClassNodes. ----- Original Message ----- > I prefer a separate SourceCodeUtil class. > > -----Original Message----- > From: Hamlet DArcy [mailto:ham...@ca...] > Sent: Wednesday, June 08, 2011 5:32 AM > To: cod...@li... > Subject: [Codenarc-developer] Util Classes > > THere is a new SourceCodeUtil class in the codebase (pulled in from a > patch). > > Marcin asked if this code should be in a parent class somewhere, or > what. Chris, do you have an opinion on this? > > -- > Hamlet D'Arcy > ham...@ca... > > > ------------------------------------------------------------------------------ > EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > |