Re: [Codenarc-user] FieldNameRule: definition of what's a constant

[Hamlet D. <ham...@ca...>]

> So I vote to change the finalRegex to the staticFinalRegex.

You want it like this, right? 

    String regex = DEFAULT_FIELD_NAME
    String staticRegex
    String finalRegex
    String staticFinalRegex = DEFAULT_CONST_NAME

I agree. It's up to Chris if he thinks it is a backwards incompatible change or a bug to be fixed. 




----- Original Message -----
> For me it's a bug, not only changed expectations. This results in
> people
> having incorrectly named variables.
> 
> So I vote to change the finalRegex to the staticFinalRegex.
> 
> Regards,
> René Scheibe
> 
> On 05/31/2011 07:25 AM, Hamlet DArcy wrote:
> > IMO, I would also have a different "finalRegex" default property. I
> > think we won't change the default because of backwards
> > compatibility.
> >  
> > 
> > ----- Original Message -----
> >> I was wondering why the "finalRegex" contains the
> >> DEFAULT_CONST_NAME
> >> pattern. I think only the "staticFinalRegex" should contain the
> >> DEFAULT_CONST_NAME pattern, as only "static final" declares class
> >> constants.
> >>
> >> Have a look at Sun's code conventions:
> >> http://www.oracle.com/technetwork/java/codeconventions-135099.html#367
> >> http://download.oracle.com/javase/tutorial/java/nutsandbolts/variables.html
> >>
> >> I was confused when violations popped up for things I am doing
> >> since
> >> years. :-)
> >>
> >> Regards,
> >> René Scheibe
> >>
> >> ------------------------------------------------------------------------------
> >> vRanger cuts backup time in half-while increasing security.
> >> With the market-leading solution for virtual backup and recovery,
> >> you get blazing-fast, flexible, and affordable data protection.
> >> Download your free trial now.
> >> http://p.sf.net/sfu/quest-d2dcopy1
> >> _______________________________________________
> >> Codenarc-user mailing list
> >> Cod...@li...
> >> https://lists.sourceforge.net/lists/listinfo/codenarc-user
> >>
> 
>