Re: [Codenarc-user] FieldNameRule: definition of what's a constant
Brought to you by:
chrismair
From: R. S. <ren...@go...> - 2011-05-31 07:18:23
|
For me it's a bug, not only changed expectations. This results in people having incorrectly named variables. So I vote to change the finalRegex to the staticFinalRegex. Regards, René Scheibe On 05/31/2011 07:25 AM, Hamlet DArcy wrote: > IMO, I would also have a different "finalRegex" default property. I think we won't change the default because of backwards compatibility. > > > ----- Original Message ----- >> I was wondering why the "finalRegex" contains the DEFAULT_CONST_NAME >> pattern. I think only the "staticFinalRegex" should contain the >> DEFAULT_CONST_NAME pattern, as only "static final" declares class >> constants. >> >> Have a look at Sun's code conventions: >> http://www.oracle.com/technetwork/java/codeconventions-135099.html#367 >> http://download.oracle.com/javase/tutorial/java/nutsandbolts/variables.html >> >> I was confused when violations popped up for things I am doing since >> years. :-) >> >> Regards, >> René Scheibe >> >> ------------------------------------------------------------------------------ >> vRanger cuts backup time in half-while increasing security. >> With the market-leading solution for virtual backup and recovery, >> you get blazing-fast, flexible, and affordable data protection. >> Download your free trial now. >> http://p.sf.net/sfu/quest-d2dcopy1 >> _______________________________________________ >> Codenarc-user mailing list >> Cod...@li... >> https://lists.sourceforge.net/lists/listinfo/codenarc-user >> |