Re: [Codenarc-developer] Release plan - MethodCount

[Chris M. <chr...@ea...>]

That was an issue I ran into whenever I implemented visitMethod() in a
visitor -- it would also get triggered for generated main() and run()
methodsfor scripts. But this rule just does a method count directly from the
classNode, so no issue.
 
I removed that disclaimer about generated methods from the rule description
and online doc.
 
I also added a violation message and reduced the default maxMethods value
from 50 down to 30. Let me know if you think that is too low.
 
Chris

-----Original Message-----
From: Hamlet DArcy [mailto:ham...@ca...] 
Sent: Friday, November 12, 2010 3:30 PM
To: codenarc-developer
Subject: Re: [Codenarc-developer] Release plan


The MethodCountRule does ignore generated methods. The CONVERSION phase has
no generated methods.  


Did I miss something? 


Also, how do you generate the site? "mvn site" gives me errors. 

--
Hamlet D'Arcy
ham...@ca...


  _____  



Hamlet, 

There is still one bug/feature that I want to try to get in before the
release: fixing MethodCountRule to ignore generated methods. 

And then I need to update the SVN keyword property on all recently added
files (just letting you know because that will touch a bunch of files). 

I will then plan on generating a version/release either Saturday or Sunday.
Unless I hear otherwise from you, I will upload once I am satisfied with it.
And then we can cooperate on the announcement, blog post, etc. 

Chris