Re: [Codenarc-developer] build is clean again
Brought to you by:
chrismair
From: Hamlet D'A. <ham...@gm...> - 2010-10-28 18:32:45
|
The big win for CLASS_GENERATION is the type information and return paths. If you can read both ReturnStatements and ClassNodes then you can start picking up a whole bunch of cool info reliably like returning null or returning unrelated classes. IMO it is important long term. I ran some tests against CLASS_GEN and saw some failures, but did not investigate. I would be surprised if it were a serious issue. Probably just some tests and rules need tweaking. I don't have a big desire to look into gmaven though. build scripts are something you can pay me to work on... but in my free time? I have to pass.... there are still plenty of rules to write without CLASS_GEN. As for the Groovy version... I think we should upgrade as soon as possible. You shouldn't need to upgrade the groovy version you compile with only the version you run codenarc with. But maybe I'm not thinking right. -- Hamlet D'Arcy ham...@gm... On Wed, Oct 27, 2010 at 10:14 PM, <chr...@wa...> wrote: > > Holy crap! You've been busy. Awesome! > > I just upped the version to Groovy 1.6 on the last release. I am a bit > hesitant to go to 1.7 now. That will require many users to upgrade (like > us). That may not be a huge deal; it will certainly have to happen sooner or > later. But yes, I am also not looking forward to fooling around with the > GMaven config. As I'm sure you noticed, where I needed to define "local" > classes, I just put at the end of the same source file. It will be nice to > have support for inner classes when we get there. If you feel that is > important to do now, and you are willing to take a crack at the GMaven > stuff, that is ok with me. > > Have you tested running those *ClassGeneration *rules against another code > base with the application classes not in the classpath? Does it blow up, or > just fail silently? > > Thanks so much. You da man! > Chris > > > *"Hamlet D'Arcy" <ham...@gm...>* > > 10/27/2010 04:02 PM > To > Cod...@li... > cc > Subject > [Codenarc-developer] build is clean again > > > > > the build is clean again and should build fine. > > There are a few commented out tests. > > Some tests fail because they use anonymous inner classes, a 1.7 > feature that the build does not support. How hard is it to fix the > build? I have heard that GMaven has problems here. > > Some tests fail because they can only be run in ClassGeneration. > > That's all, 9 new rules were added. > > -- > Hamlet D'Arcy > ham...@gm... > > > ------------------------------------------------------------------------------ > Nokia and AT&T present the 2010 Calling All Innovators-North America > contest > Create new apps & games for the Nokia N8 for consumers in U.S. and Canada > $10 million total in prizes - $4M cash, 500 devices, nearly $6M in > marketing > Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store > http://p.sf.net/sfu/nokia-dev2dev > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > ForwardSourceID:NT000CD312 > |