Thread: [Codenarc-user] GrailsPublicControllerMethod

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

The GrailsPublicControllerMethod rule should be removed from CodeNarc
since Grails 2.0 uses methods instead of closures by default.

Thanks,
Bobby

Ideally, the codenarc plugin would have some knowledge about which rules
apply to which version of Grails, *and* which version of Grails the project
uses?

On Mon, Aug 22, 2011 at 2:15 PM, Bobby Warner <bob...@gm...> wrote:

> The GrailsPublicControllerMethod rule should be removed from CodeNarc
> since Grails 2.0 uses methods instead of closures by default.
>
>
> Thanks,
> Bobby
>
>
> ------------------------------------------------------------------------------
> uberSVN's rich system and user administration capabilities and model
> configuration take the hassle out of deploying and managing Subversion and
> the tools developers use with it. Learn more about uberSVN and get a free
> download at:  http://p.sf.net/sfu/wandisco-dev2dev
> _______________________________________________
> Codenarc-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-user
>

Great ideas! I will open some Jira tickets for the plugin.

Can you think of any other grails rules? Are there best practices around
named queries and interceptors? Services? I would love some help thinking up
Grails rules.

--
Hamlet D'Arcy
ham...@gm...

On Aug 23, 2011 4:44 AM, "Olivier Gourment" <ogo...@sm...>
wrote:
> Ideally, the codenarc plugin would have some knowledge about which rules
> apply to which version of Grails, *and* which version of Grails the
project
> uses?
>
> On Mon, Aug 22, 2011 at 2:15 PM, Bobby Warner <bob...@gm...>
wrote:
>
>> The GrailsPublicControllerMethod rule should be removed from CodeNarc
>> since Grails 2.0 uses methods instead of closures by default.
>>
>>
>> Thanks,
>> Bobby
>>
>>
>>
------------------------------------------------------------------------------
>> uberSVN's rich system and user administration capabilities and model
>> configuration take the hassle out of deploying and managing Subversion
and
>> the tools developers use with it. Learn more about uberSVN and get a free
>> download at: http://p.sf.net/sfu/wandisco-dev2dev
>> _______________________________________________
>> Codenarc-user mailing list
>> Cod...@li...
>> https://lists.sourceforge.net/lists/listinfo/codenarc-user
>>

Ideally, yes. Unfortunately, the Grails CodeNarc plugin is just a wrapper for regular CodeNarc. CodeNarc is not executing within the Grails container, and has no notion of what the "current" version of Grails is. I think any customization like this would need to be done within the plugin, and probably at plugin installation/upgrade time, but I'm not sure of a clean and straightforward way to do that. Perhaps create or append to a "codenarc.properties" file that turns that rule off if the plugin script is executed from Grails 2.x? Hmmm.

From: Olivier Gourment [mailto:ogo...@sm...]
Sent: Monday, August 22, 2011 10:44 PM
To: Bobby Warner
Cc: cod...@li...
Subject: Re: [Codenarc-user] GrailsPublicControllerMethod

Ideally, the codenarc plugin would have some knowledge about which rules apply to which version of Grails, *and* which version of Grails the project uses?
On Mon, Aug 22, 2011 at 2:15 PM, Bobby Warner <bob...@gm...<mailto:bob...@gm...>> wrote:
The GrailsPublicControllerMethod rule should be removed from CodeNarc
since Grails 2.0 uses methods instead of closures by default.

Thanks,
Bobby

------------------------------------------------------------------------------
uberSVN's rich system and user administration capabilities and model
configuration take the hassle out of deploying and managing Subversion and
the tools developers use with it. Learn more about uberSVN and get a free
download at:  http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
Codenarc-user mailing list
Cod...@li...<mailto:Cod...@li...>
https://lists.sourceforge.net/lists/listinfo/codenarc-user

Thank you for taking this into consideration! I added a comment to:
http://jira.grails.org/browse/GPCODENARC-23?focusedCommentId=66029#comment-66029

There should be some kind of DSL that allows to do this in Grails
configiuration (BuildConfig.groovy), which generates the
codenarc.propertiesat each build.

On Wed, Aug 24, 2011 at 8:47 AM, <chr...@we...> wrote:

> Ideally, yes. Unfortunately, the Grails CodeNarc plugin is just a wrapper
> for regular CodeNarc. CodeNarc is not executing within the Grails container,
> and has no notion of what the “current” version of Grails is. I think any
> customization like this would need to be done within the plugin, and
> probably at plugin installation/upgrade time, but I’m not sure of a clean
> and straightforward way to do that. Perhaps create or append to a
> “codenarc.properties” file that turns that rule off if the plugin script is
> executed from Grails 2.x? Hmmm.****
>
> ** **
>
> *From:* Olivier Gourment [mailto:ogo...@sm...]
> *Sent:* Monday, August 22, 2011 10:44 PM
> *To:* Bobby Warner
> *Cc:* cod...@li...
> *Subject:* Re: [Codenarc-user] GrailsPublicControllerMethod****
>
> ** **
>
> Ideally, the codenarc plugin would have some knowledge about which rules
> apply to which version of Grails, *and* which version of Grails the project
> uses?****
>
> On Mon, Aug 22, 2011 at 2:15 PM, Bobby Warner <bob...@gm...>
> wrote:****
>
> The GrailsPublicControllerMethod rule should be removed from CodeNarc
> since Grails 2.0 uses methods instead of closures by default.
>
>
> Thanks,
> Bobby
>
>
> ------------------------------------------------------------------------------
> uberSVN's rich system and user administration capabilities and model
> configuration take the hassle out of deploying and managing Subversion and
> the tools developers use with it. Learn more about uberSVN and get a free
> download at:  http://p.sf.net/sfu/wandisco-dev2dev
> _______________________________________________
> Codenarc-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-user****
>
> ** **
>