Hi Chris,
In my opinion, the rules need some performance improvements. Do you
feel the same?
One idea I have is to optimize rules that override
visitMethodCallExpression. We walk the AST for every rule, but many
rules only override visitMethodCall. Why not walk the tree only one
time, and then call all the rules when a method call is found? I am
thinking of an abstract class the defines only visitMethodCall as a
abstract method. Then somehow the rule runner is smart enough to
collect all the instance of the abstract classes and walk the tree
only once, calling each child rule when a MethodCallExpression is
found. It needs to support @SuppressWarnings as well.
I think this would be an improvement. What do you think?
What are you using to measure performance?
Also, great activity recently :) I hope to find a little more time for
rules over the next month or so.
--
Hamlet D'Arcy
ham...@gm...
|
