codenarc-developer

[Codenarc-developer] ExplicitCallToAndMethod / ExplicitCallToOrMethod and Grails

[Chris M. <chr...@ea...>]

Hamlet,
 
I'm wondering if changing ExplicitCallToAndMethodRule and
ExplicitCallToOrMethodRule to ignore invocations where there is a single
Closure parameter would address the typical Grails usage (and other DSLs as
well) without hiding "bad" usages.
 
Chris

Re: [Codenarc-developer] ExplicitCallToAndMethod / ExplicitCallToOrMethod and Grails

[Hamlet D. <ham...@ca...>]

i think it seems reasonable to ignore 'this' references like this.add() or just add() , which is the property I added to the rules. 

-- 
Hamlet D'Arcy 
ham...@ca... 





Hamlet, 

I'm wondering if changing ExplicitCallToAndMethodRule and ExplicitCallToOrMethodRule to ignore invocations where there is a single Closure parameter would address the typical Grails usage (and other DSLs as well) without hiding "bad" usages. 

Chris