Thread: Re: [Codenarc-developer] Release plan
Brought to you by:
chrismair
From: Hamlet D. <ham...@ca...> - 2010-11-12 20:30:05
|
The MethodCountRule does ignore generated methods. The CONVERSION phase has no generated methods. Did I miss something? Also, how do you generate the site? "mvn site" gives me errors. -- Hamlet D'Arcy ham...@ca... Hamlet, There is still one bug/feature that I want to try to get in before the release: fixing MethodCountRule to ignore generated methods. And then I need to update the SVN keyword property on all recently added files (just letting you know because that will touch a bunch of files). I will then plan on generating a version/release either Saturday or Sunday. Unless I hear otherwise from you, I will upload once I am satisfied with it. And then we can cooperate on the announcement, blog post, etc. Chris |
From: <chr...@wa...> - 2010-11-12 20:37:00
|
>> The MethodCountRule does ignore generated methods. The CONVERSION phase has no generated methods. Ok, I have not even looked at the code yet. I was just going off the description: "Remember, Groovy may generate some methods for you, and the method count is for all methods in the object, not just the user defined methods in the source file." >> how do you generate the site? "mvn site" gives me errors. re: mvn site -- Hmmm. I need to look at my notes at home. This may be one of the impacts of us moving to Groovy 1.7 and GMaven <whatever>. I may have to downgrade to Java 1.5 to run that. And perhaps run the Javadoc task separately. Chris Hamlet DArcy <ham...@ca...> 11/12/2010 03:29 PM To codenarc-developer <cod...@li...> cc Subject Re: [Codenarc-developer] Release plan The MethodCountRule does ignore generated methods. The CONVERSION phase has no generated methods. Did I miss something? Also, how do you generate the site? "mvn site" gives me errors. -- Hamlet D'Arcy ham...@ca... Hamlet, There is still one bug/feature that I want to try to get in before the release: fixing MethodCountRule to ignore generated methods. And then I need to update the SVN keyword property on all recently added files (just letting you know because that will touch a bunch of files). I will then plan on generating a version/release either Saturday or Sunday. Unless I hear otherwise from you, I will upload once I am satisfied with it. And then we can cooperate on the announcement, blog post, etc. Chris ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000CE856 |
From: Hamlet D'A. <ham...@gm...> - 2010-11-12 20:43:34
|
That sucks that mvn site might be broken. It looks like the "Dependencies report" is what causes the errors. I just want to process the .apt files and see the site so I can tweek css and some layout. On Fri, Nov 12, 2010 at 9:36 PM, <chr...@wa...> wrote: > > >> *The MethodCountRule does ignore generated methods. The CONVERSION > phase has no generated methods. * > > Ok, I have not even looked at the code yet. I was just going off the > description: "Remember, Groovy may generate some methods for you, and the > method count is for all methods in the object, not just the user defined > methods in the source file." > > >>* **how do you generate the site? "mvn site" gives me errors. * > re: mvn site -- Hmmm. I need to look at my notes at home. This may be one > of the impacts of us moving to Groovy 1.7 and GMaven <whatever>. I may have > to downgrade to Java 1.5 to run that. And perhaps run the Javadoc task > separately. > > Chris > > > *Hamlet DArcy <ham...@ca...>* > > 11/12/2010 03:29 PM > To > codenarc-developer <cod...@li...> > cc > Subject > Re: [Codenarc-developer] Release plan > > > > > The MethodCountRule does ignore generated methods. The CONVERSION phase has > no generated methods. > > Did I miss something? > > Also, how do you generate the site? "mvn site" gives me errors. > > -- > Hamlet D'Arcy > ham...@ca... > > ------------------------------ > > > Hamlet, > > There is still one bug/feature that I want to try to get in before the > release: fixing *MethodCountRule *to ignore generated methods. > > And then I need to update the SVN *keyword *property on all recently added > files (just letting you know because that will touch a bunch of files). > > I will then plan on generating a version/release either Saturday or Sunday. > Unless I hear otherwise from you, I will upload once I am satisfied with it. > And then we can cooperate on the announcement, blog post, etc. > > Chris > > ------------------------------------------------------------------------------ > Centralized Desktop Delivery: Dell and VMware Reference Architecture > Simplifying enterprise desktop deployment and management using > Dell EqualLogic storage and VMware View: A highly scalable, end-to-end > client virtualization framework. Read more! > > http://p.sf.net/sfu/dell-eql-dev2dev_______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > ForwardSourceID:NT000CE856 > > > ------------------------------------------------------------------------------ > Centralized Desktop Delivery: Dell and VMware Reference Architecture > Simplifying enterprise desktop deployment and management using > Dell EqualLogic storage and VMware View: A highly scalable, end-to-end > client virtualization framework. Read more! > http://p.sf.net/sfu/dell-eql-dev2dev > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > -- Hamlet D'Arcy ham...@gm... |
From: Chris M. <chr...@ea...> - 2010-11-12 23:58:49
|
Hmm. I'm home now. I am able to run mvn site and successfully build the site. The output did include an exception while running Cobertura. So, code coverage and javadocs did not work.But the rest if the site came out fine. Here is my environment: > mvn -version Apache Maven 2.2.1 (r801777; 2009-08-06 15:16:01-0400) Java version: 1.6.0_18 Java home: C:\Program Files\Java\jdk1.6.0_18\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows" Chris -----Original Message----- From: Hamlet D'Arcy [mailto:ham...@gm...] Sent: Friday, November 12, 2010 3:43 PM To: Cod...@li... Subject: Re: [Codenarc-developer] Release plan That sucks that mvn site might be broken. It looks like the "Dependencies report" is what causes the errors. I just want to process the .apt files and see the site so I can tweek css and some layout. On Fri, Nov 12, 2010 at 9:36 PM, <chr...@wa...> wrote: >> The MethodCountRule does ignore generated methods. The CONVERSION phase has no generated methods. Ok, I have not even looked at the code yet. I was just going off the description: "Remember, Groovy may generate some methods for you, and the method count is for all methods in the object, not just the user defined methods in the source file." >> how do you generate the site? "mvn site" gives me errors. re: mvn site -- Hmmm. I need to look at my notes at home. This may be one of the impacts of us moving to Groovy 1.7 and GMaven <whatever>. I may have to downgrade to Java 1.5 to run that. And perhaps run the Javadoc task separately. Chris Hamlet DArcy <ham...@ca...> 11/12/2010 03:29 PM To codenarc-developer <cod...@li...> cc Subject Re: [Codenarc-developer] Release plan The MethodCountRule does ignore generated methods. The CONVERSION phase has no generated methods. Did I miss something? Also, how do you generate the site? "mvn site" gives me errors. -- Hamlet D'Arcy ham...@ca... _____ Hamlet, There is still one bug/feature that I want to try to get in before the release: fixing MethodCountRule to ignore generated methods. And then I need to update the SVN keyword property on all recently added files (just letting you know because that will touch a bunch of files). I will then plan on generating a version/release either Saturday or Sunday. Unless I hear otherwise from you, I will upload once I am satisfied with it. And then we can cooperate on the announcement, blog post, etc. Chris ---------------------------------------------------------------------------- -- Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev________________________________________ _______ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000CE856 ---------------------------------------------------------------------------- -- Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer -- Hamlet D'Arcy ham...@gm... |
From: Chris M. <chr...@ea...> - 2010-11-13 00:48:20
|
That was an issue I ran into whenever I implemented visitMethod() in a visitor -- it would also get triggered for generated main() and run() methodsfor scripts. But this rule just does a method count directly from the classNode, so no issue. I removed that disclaimer about generated methods from the rule description and online doc. I also added a violation message and reduced the default maxMethods value from 50 down to 30. Let me know if you think that is too low. Chris -----Original Message----- From: Hamlet DArcy [mailto:ham...@ca...] Sent: Friday, November 12, 2010 3:30 PM To: codenarc-developer Subject: Re: [Codenarc-developer] Release plan The MethodCountRule does ignore generated methods. The CONVERSION phase has no generated methods. Did I miss something? Also, how do you generate the site? "mvn site" gives me errors. -- Hamlet D'Arcy ham...@ca... _____ Hamlet, There is still one bug/feature that I want to try to get in before the release: fixing MethodCountRule to ignore generated methods. And then I need to update the SVN keyword property on all recently added files (just letting you know because that will touch a bunch of files). I will then plan on generating a version/release either Saturday or Sunday. Unless I hear otherwise from you, I will upload once I am satisfied with it. And then we can cooperate on the announcement, blog post, etc. Chris |
From: Hamlet D'A. <ham...@gm...> - 2010-11-13 07:28:46
|
After the release, I would like to go through and add messages to all addViolation method calls. It would help with readability especially in the text form. On Sat, Nov 13, 2010 at 1:48 AM, Chris Mair <chr...@ea...> wrote: > That was an issue I ran into whenever I implemented visitMethod() in a > visitor -- it would also get triggered for generated main() and run() > methodsfor scripts. But this rule just does a method count directly from the > classNode, so no issue. > > I removed that disclaimer about generated methods from the rule description > and online doc. > > I also added a violation message and reduced the default maxMethods value > from 50 down to 30. Let me know if you think that is too low. > > Chris > > -----Original Message----- > From: Hamlet DArcy [mailto:ham...@ca...] > Sent: Friday, November 12, 2010 3:30 PM > To: codenarc-developer > Subject: Re: [Codenarc-developer] Release plan > > The MethodCountRule does ignore generated methods. The CONVERSION phase has > no generated methods. > Did I miss something? > Also, how do you generate the site? "mvn site" gives me errors. > > -- > Hamlet D'Arcy > ham...@ca... > > ________________________________ > > Hamlet, > > There is still one bug/feature that I want to try to get in before the > release: fixing MethodCountRule to ignore generated methods. > > And then I need to update the SVN keyword property on all recently added > files (just letting you know because that will touch a bunch of files). > > I will then plan on generating a version/release either Saturday or Sunday. > Unless I hear otherwise from you, I will upload once I am satisfied with it. > And then we can cooperate on the announcement, blog post, etc. > > Chris > > ------------------------------------------------------------------------------ > Centralized Desktop Delivery: Dell and VMware Reference Architecture > Simplifying enterprise desktop deployment and management using > Dell EqualLogic storage and VMware View: A highly scalable, end-to-end > client virtualization framework. Read more! > http://p.sf.net/sfu/dell-eql-dev2dev > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > -- Hamlet D'Arcy ham...@gm... |