codenarc-developer Mailing List for CodeNarc (Page 10)
Brought to you by:
chrismair
This list is closed, nobody may subscribe to it.
2010 |
Jan
|
Feb
|
Mar
|
Apr
(8) |
May
(17) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(8) |
Nov
(67) |
Dec
(9) |
---|---|---|---|---|---|---|---|---|---|---|---|---|
2011 |
Jan
(23) |
Feb
(19) |
Mar
(15) |
Apr
(7) |
May
(5) |
Jun
(43) |
Jul
(5) |
Aug
(11) |
Sep
(18) |
Oct
(9) |
Nov
(6) |
Dec
|
2012 |
Jan
(7) |
Feb
(2) |
Mar
(7) |
Apr
|
May
|
Jun
|
Jul
(17) |
Aug
(5) |
Sep
|
Oct
(1) |
Nov
|
Dec
(1) |
2013 |
Jan
|
Feb
(1) |
Mar
(7) |
Apr
|
May
(6) |
Jun
|
Jul
(2) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2014 |
Jan
(6) |
Feb
(3) |
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2016 |
Jan
(2) |
Feb
|
Mar
|
Apr
(2) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2017 |
Jan
|
Feb
|
Mar
(4) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
From: <chr...@wa...> - 2011-01-13 12:47:42
|
Hamlet, In the violation message for the UnnecessaryBigDecimalInstantiation rule, is the "G" suffix necessary? e.g. source: BigDecimal amount = new BigDecimal("1115.37") message: Can probably be rewritten as 1115.37G since Groovy will treat 1115.37 as a BigDecimal by default. Likewise, the message for UnnecessaryIntegerInstantiation includes an "i" suffix after the number. Can we remove them or at least further qualify that message. I can just see developers adding unnecessary "G" and "i" all over the place. Chris |
From: <chr...@wa...> - 2011-01-12 12:57:21
|
Good suggestion. I will do that. Hamlet DArcy <ham...@ca...> 01/12/2011 02:40 AM To cod...@li... cc Subject [Codenarc-developer] logger created for different class rule Hi Chris, Before closing the Logger rule we should support SLF4J and Logback. The API to create a logger with those are: LoggerFactory.getLogger(Class) -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > Feature Requests item #3114736, was opened at 2010-11-21 14:13 > Message generated for change (Comment added) made by chrismair > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=1126575&aid=3114736&group_id=250145 > > Please note that this message will contain a full copy of the comment > thread, > including the initial issue submission, for this request, > not just the latest update. > Category: None > Group: None > >Status: Closed > Priority: 5 > Private: No > Submitted By: Hamlet D'Arcy (hamletdrc) > Assigned to: Chris Mair (chrismair) > Summary: create rule: logger created for different class > > Initial Comment: > When you copy and paste a logger instantiation, often you forget to > change the Class literal that is passed as a parameter. > In this case, detect when the class literal does not match the current > class and flag as an error. > > ---------------------------------------------------------------------- > > >Comment By: Chris Mair (chrismair) > Date: 2011-01-11 19:33 > > Message: > Created LoggerForDifferentClassRule. Available in version 0.12. > > ---------------------------------------------------------------------- > > Comment By: Chris Mair (chrismair) > Date: 2011-01-09 20:11 > > Message: > I am starting to work on this one. I'm giving it a bit higher priority > since it was (also) requested by another user (see Feature #3117658). > > ---------------------------------------------------------------------- > > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=1126575&aid=3114736&group_id=250145 ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000F47DE |
From: Hamlet D. <ham...@ca...> - 2011-01-12 07:40:29
|
Hi Chris, Before closing the Logger rule we should support SLF4J and Logback. The API to create a logger with those are: LoggerFactory.getLogger(Class) -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > Feature Requests item #3114736, was opened at 2010-11-21 14:13 > Message generated for change (Comment added) made by chrismair > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=1126575&aid=3114736&group_id=250145 > > Please note that this message will contain a full copy of the comment > thread, > including the initial issue submission, for this request, > not just the latest update. > Category: None > Group: None > >Status: Closed > Priority: 5 > Private: No > Submitted By: Hamlet D'Arcy (hamletdrc) > Assigned to: Chris Mair (chrismair) > Summary: create rule: logger created for different class > > Initial Comment: > When you copy and paste a logger instantiation, often you forget to > change the Class literal that is passed as a parameter. > In this case, detect when the class literal does not match the current > class and flag as an error. > > ---------------------------------------------------------------------- > > >Comment By: Chris Mair (chrismair) > Date: 2011-01-11 19:33 > > Message: > Created LoggerForDifferentClassRule. Available in version 0.12. > > ---------------------------------------------------------------------- > > Comment By: Chris Mair (chrismair) > Date: 2011-01-09 20:11 > > Message: > I am starting to work on this one. I'm giving it a bit higher priority > since it was (also) requested by another user (see Feature #3117658). > > ---------------------------------------------------------------------- > > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=1126575&aid=3114736&group_id=250145 |
From: Hamlet D. <ham...@ca...> - 2011-01-11 14:17:33
|
Ah, the enabled=false is exactly what I needed. I'm going to take a break from my other work and bang out a few new rules this week. I'd like the 0.12 release to be just a little larger! -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > Hamlet, > > Options include: > (1) Override the isReady () method to dynamically return true only if > the necessary preconditions are satisfied (see RequiredRegexRule , for > instance). > (2) In the rule constructor, set enabled property to false . > > Chris > > > Hamlet DArcy <ham...@ca...> > > 01/11/2011 09:05 AM > > To cod...@li... > > cc > > Subject [Codenarc-developer] how do I write a new rule that is > disabled by default? > > > > > How do I add a new rule that is disabled by default? > > It is a rule that is valid but most people do not want it. > > Thanks, > > -- > Hamlet D'Arcy > ham...@ca... > > > ------------------------------------------------------------------------------ > Gaining the trust of online customers is vital for the success of any > company > that requires sensitive data to be transmitted over the Web. Learn how > to > best implement a security strategy that keeps consumers' information > secure > and instills the confidence they need to proceed with transactions. > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > ForwardSourceID:NT000F460A |
From: <chr...@wa...> - 2011-01-11 14:13:46
|
Hamlet, Options include: (1) Override the isReady() method to dynamically return true only if the necessary preconditions are satisfied (see RequiredRegexRule, for instance). (2) In the rule constructor, set enabled property to false. Chris Hamlet DArcy <ham...@ca...> 01/11/2011 09:05 AM To cod...@li... cc Subject [Codenarc-developer] how do I write a new rule that is disabled by default? How do I add a new rule that is disabled by default? It is a rule that is valid but most people do not want it. Thanks, -- Hamlet D'Arcy ham...@ca... ------------------------------------------------------------------------------ Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000F460A |
From: Hamlet D. <ham...@ca...> - 2011-01-11 14:06:04
|
How do I add a new rule that is disabled by default? It is a rule that is valid but most people do not want it. Thanks, -- Hamlet D'Arcy ham...@ca... |
From: <chr...@wa...> - 2011-01-10 13:23:01
|
Excellent. Thanks a lot, Hamlet. Chris Hamlet DArcy <ham...@ca...> 01/09/2011 07:54 AM To Chris Mair <chr...@ea...> cc cod...@li... Subject Re: [Codenarc-developer] Preparing for release v0.12 > Is there anything holding us back from releasing v0.12? I don't think there is anything holding us back. There is a big backlog of rules, but that is OK. > Any chance the new logo/icon will be ready soon? Do you need any help > on that? I just got back from a long vacation and am a little buried. The logo files are exactly what I sent you. If you like it then we can use it. Feel free to edit any way you want. > And finally, what do you want to do about the “Get 0.11” image/icon on > the home page? I changed it to "Get 0.12" The image is in codenarc-core/src/site/resources/images I am very busy right now, but want to get back into some more rules with the 0.13 release. I'd love to be able to commit to more 0.12 release rules but just cannot commit right now. -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > Hamlet (and anybody else), > > > > Is there anything holding us back from releasing v0.12? > > > > I still have one or two new rules to add, I think. Though I still have > a long to-do list in general, I think we are well beyond the point of > having enough for a sizeable and useful release, so I am hoping to cut > it off soon. > > > > I have checked in draft v0.12 release notes in “CHANGELOG.txt”. > > > > Any chance the new logo/icon will be ready soon? Do you need any help > on that? > > > > And finally, what do you want to do about the “Get 0.11” image/icon on > the home page? Do we want to keep doing it that way? That is fine with > me, but could you check in (or send me) the “Get 0.12” image, or tell > me how to generate it. Alternatively, we could use a generic > “Download” or “Get the Latest Version” image. > > > > Thanks. > > Chris > ------------------------------------------------------------------------------ > Gaining the trust of online customers is vital for the success of any > company > that requires sensitive data to be transmitted over the Web. Learn how > to > best implement a security strategy that keeps consumers' information > secure > and instills the confidence they need to proceed with transactions. > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer ------------------------------------------------------------------------------ Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000F438A |
From: Hamlet D. <ham...@ca...> - 2011-01-09 12:54:36
|
> Is there anything holding us back from releasing v0.12? I don't think there is anything holding us back. There is a big backlog of rules, but that is OK. > Any chance the new logo/icon will be ready soon? Do you need any help > on that? I just got back from a long vacation and am a little buried. The logo files are exactly what I sent you. If you like it then we can use it. Feel free to edit any way you want. > And finally, what do you want to do about the “Get 0.11” image/icon on > the home page? I changed it to "Get 0.12" The image is in codenarc-core/src/site/resources/images I am very busy right now, but want to get back into some more rules with the 0.13 release. I'd love to be able to commit to more 0.12 release rules but just cannot commit right now. -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > Hamlet (and anybody else), > > > > Is there anything holding us back from releasing v0.12? > > > > I still have one or two new rules to add, I think. Though I still have > a long to-do list in general, I think we are well beyond the point of > having enough for a sizeable and useful release, so I am hoping to cut > it off soon. > > > > I have checked in draft v0.12 release notes in “CHANGELOG.txt”. > > > > Any chance the new logo/icon will be ready soon? Do you need any help > on that? > > > > And finally, what do you want to do about the “Get 0.11” image/icon on > the home page? Do we want to keep doing it that way? That is fine with > me, but could you check in (or send me) the “Get 0.12” image, or tell > me how to generate it. Alternatively, we could use a generic > “Download” or “Get the Latest Version” image. > > > > Thanks. > > Chris > ------------------------------------------------------------------------------ > Gaining the trust of online customers is vital for the success of any > company > that requires sensitive data to be transmitted over the Web. Learn how > to > best implement a security strategy that keeps consumers' information > secure > and instills the confidence they need to proceed with transactions. > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer |
From: Chris M. <chr...@ea...> - 2011-01-08 03:19:39
|
Hamlet (and anybody else), Is there anything holding us back from releasing v0.12? I still have one or two new rules to add, I think. Though I still have a long to-do list in general, I think we are well beyond the point of having enough for a sizeable and useful release, so I am hoping to cut it off soon. I have checked in draft v0.12 release notes in "CHANGELOG.txt". Any chance the new logo/icon will be ready soon? Do you need any help on that? And finally, what do you want to do about the "Get 0.11" image/icon on the home page? Do we want to keep doing it that way? That is fine with me, but could you check in (or send me) the "Get 0.12" image, or tell me how to generate it. Alternatively, we could use a generic "Download" or "Get the Latest Version" image. Thanks. Chris |
From: Chris M. <chr...@ea...> - 2010-12-26 02:13:12
|
I am setting up as new laptop, and installed IDEA 10.0. With all of this, I updated CodeNarc.iml and CodeNarcv.ipr. If this causes anybody problems, or if we need a better strategy for checking in IDE files, let me know. Chris |
From: <chr...@wa...> - 2010-12-15 12:37:47
|
LOL. That's great. Yes, it sounds perfect for using on a slide. Sorry for the late reply. This email seems to have been stuck in the forum moderator bucket because of the attachment size. Chris Hamlet DArcy <ham...@ca...> 12/03/2010 01:41 AM To cod...@li... cc Subject Re: [Codenarc-developer] more on a new logo This is not suitable for a logo, but checkout what I got on UpHype for a mere $8. Maybe we can use it in a slide or something :) -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > OK, I contacted 3 sellers with an offer... we'll see what happens. For > $24 what could go wrong. > > > -- > Hamlet D'Arcy > ham...@ca... > > ----- Original Message ----- > > > > Absolutely. I will be more than happy to pay for it, especially at > these prices. > > Should we go with the armadillo theme you described (which sounds fine > to me)? Or leave it more open-ended? > > Let me know how you think we should proceed. Thanks very much for the > leg work. > > Chris > > > > -----Original Message----- > From: Hamlet DArcy [mailto:ham...@ca...] > Sent: Tuesday, November 30, 2010 6:34 AM > To: cod...@li... > Subject: [Codenarc-developer] more on a new logo > > > Hi, > > Some more info on a new logo... > > There are 3 different offers on UpHype.com to design logos for under > $20. I'd be willing to pay for that if we can decide on a logo. > > Here are the offers: > http://uphype.com/hype/create-a-simple-but-eye-catching-logo-for-your-business > http://uphype.com/hype/design-a-professional-clean-web-logo > http://uphype.com/hype/design-a-logo > > What do you think? Should we get serious about a logo? > > -- > Hamlet D'Arcy > ham...@ca... [attachment "armadillo cowboy copy.jpg" deleted by Chris Mair/IT/WACH] ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000D1FEA |
From: Chris M. <chr...@ea...> - 2010-12-04 02:06:56
|
I have to build that using Java 1.5 to get a working code coverage report. I'm not totally sure, but I think that is (another) incompatibility issue with GMaven. Anyway, I switch my JAVA_HOME/PATH to a Java 1.5 JDK and then execute: mvn clean site Chris -----Original Message----- From: Hamlet DArcy [mailto:ham...@ca...] Sent: Friday, December 03, 2010 7:51 AM To: cod...@li... Subject: [Codenarc-developer] test coverage on build? How do you run the build with test coverage? -- Hamlet D'Arcy ham...@ca... ---------------------------------------------------------------------------- -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer |
From: Hamlet D. <ham...@ca...> - 2010-12-03 12:51:00
|
How do you run the build with test coverage? -- Hamlet D'Arcy ham...@ca... |
From: Hamlet D. <ham...@ca...> - 2010-12-03 06:42:05
|
This is not suitable for a logo, but checkout what I got on UpHype for a mere $8. Maybe we can use it in a slide or something :) -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > OK, I contacted 3 sellers with an offer... we'll see what happens. For > $24 what could go wrong. > > > -- > Hamlet D'Arcy > ham...@ca... > > ----- Original Message ----- > > > > Absolutely. I will be more than happy to pay for it, especially at > these prices. > > Should we go with the armadillo theme you described (which sounds fine > to me)? Or leave it more open-ended? > > Let me know how you think we should proceed. Thanks very much for the > leg work. > > Chris > > > > -----Original Message----- > From: Hamlet DArcy [mailto:ham...@ca...] > Sent: Tuesday, November 30, 2010 6:34 AM > To: cod...@li... > Subject: [Codenarc-developer] more on a new logo > > > Hi, > > Some more info on a new logo... > > There are 3 different offers on UpHype.com to design logos for under > $20. I'd be willing to pay for that if we can decide on a logo. > > Here are the offers: > http://uphype.com/hype/create-a-simple-but-eye-catching-logo-for-your-business > http://uphype.com/hype/design-a-professional-clean-web-logo > http://uphype.com/hype/design-a-logo > > What do you think? Should we get serious about a logo? > > -- > Hamlet D'Arcy > ham...@ca... |
From: Hamlet D. <ham...@ca...> - 2010-12-01 06:34:25
|
> short-circuit evaluation of each field. Let me know if you have a > better solution. The methods are final because if you override them then the @SuppressWarnings support stops working. The -Ex methods exist so you can still have something to override. However, the missing piece is that the -Ex methods cannot stop the tree walk. One solution is to make the -Ex methods all return boolean, meaning whether to continue walking the tree or nut. Then the parent could read the return value and stop the walk if needed. -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > Hamlet, > > In fixing this issue, I want to short-circuit the processing of the > StatelessClassRule if the class is marked as @Immutable. But because > the > visitClass(ClassNode node) method is final (a good thing!) in > AbstractAstVisitor, I cannot override and just stop the rule > processing > there. > > As a workaround, I set an "immutable" flag in visitClassEx() and > short-circuit evaluation of each field. Let me know if you have a > better > solution. > > Chris > > -----Original Message----- > From: SourceForge.net [mailto:no...@so...] > Sent: Tuesday, November 30, 2010 9:20 PM > To: no...@so... > Subject: [ codenarc-Bugs-3111189 ] StatelessClassRule - Honor > @Immutable > > > Bugs item #3111189, was opened at 2010-11-17 21:35 > Message generated for change (Comment added) made by chrismair You can > respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111189&group_ > id=250145 > > Please note that this message will contain a full copy of the comment > thread, including the initial issue submission, for this request, not > just > the latest update. > Category: None > Group: None > >Status: Closed > >Resolution: Fixed > Priority: 5 > Private: No > Submitted By: Chris Mair (chrismair) > >Assigned to: Chris Mair (chrismair) > Summary: StatelessClassRule - Honor @Immutable > > Initial Comment: > >From Venkat's "Improving Your Groovy Code Quality" presentation at > >Spring > 2GX (http://agiledeveloper.com/downloads.html) - slide #25 > > @Immutable class Person { > int age > boolean equals(other) { > age == other.age > } > } > > CodeNarc does not infer that @Immutable makes age final. It may > trigger > StatelessClass validation error on age. > > ---------------------------------------------------------------------- > > >Comment By: Chris Mair (chrismair) > Date: 2010-11-30 21:19 > > Message: > I have changed StatelessClassRule to ignore all classes marked with > @Immutable. > - Chris > > ---------------------------------------------------------------------- > > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111189&group_ > id=250145 > > > ------------------------------------------------------------------------------ > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > Tap into the largest installed PC base & get more eyes on your game by > optimizing for Intel(R) Graphics Technology. Get started today with > the > Intel(R) Software Partner Program. Five $500 cash prizes are up for > grabs. > http://p.sf.net/sfu/intelisp-dev2dev > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer |
From: Hamlet D. <ham...@ca...> - 2010-12-01 06:24:57
|
OK, I contacted 3 sellers with an offer... we'll see what happens. For $24 what could go wrong. -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- Message Absolutely. I will be more than happy to pay for it, especially at these prices. Should we go with the armadillo theme you described (which sounds fine to me)? Or leave it more open-ended? Let me know how you think we should proceed. Thanks very much for the leg work. Chris -----Original Message----- From: Hamlet DArcy [mailto:ham...@ca...] Sent: Tuesday, November 30, 2010 6:34 AM To: cod...@li... Subject: [Codenarc-developer] more on a new logo Hi, Some more info on a new logo... There are 3 different offers on UpHype.com to design logos for under $20. I'd be willing to pay for that if we can decide on a logo. Here are the offers: http://uphype.com/hype/create-a-simple-but-eye-catching-logo-for-your-business http://uphype.com/hype/design-a-professional-clean-web-logo http://uphype.com/hype/design-a-logo What do you think? Should we get serious about a logo? -- Hamlet D'Arcy ham...@ca... |
From: Chris M. <chr...@ea...> - 2010-12-01 02:27:36
|
Hamlet, In fixing this issue, I want to short-circuit the processing of the StatelessClassRule if the class is marked as @Immutable. But because the visitClass(ClassNode node) method is final (a good thing!) in AbstractAstVisitor, I cannot override and just stop the rule processing there. As a workaround, I set an "immutable" flag in visitClassEx() and short-circuit evaluation of each field. Let me know if you have a better solution. Chris -----Original Message----- From: SourceForge.net [mailto:no...@so...] Sent: Tuesday, November 30, 2010 9:20 PM To: no...@so... Subject: [ codenarc-Bugs-3111189 ] StatelessClassRule - Honor @Immutable Bugs item #3111189, was opened at 2010-11-17 21:35 Message generated for change (Comment added) made by chrismair You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111189&group_ id=250145 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Chris Mair (chrismair) >Assigned to: Chris Mair (chrismair) Summary: StatelessClassRule - Honor @Immutable Initial Comment: >From Venkat's "Improving Your Groovy Code Quality" presentation at Spring 2GX (http://agiledeveloper.com/downloads.html) - slide #25 @Immutable class Person { int age boolean equals(other) { age == other.age } } CodeNarc does not infer that @Immutable makes age final. It may trigger StatelessClass validation error on age. ---------------------------------------------------------------------- >Comment By: Chris Mair (chrismair) Date: 2010-11-30 21:19 Message: I have changed StatelessClassRule to ignore all classes marked with @Immutable. - Chris ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111189&group_ id=250145 |
From: Chris M. <chr...@ea...> - 2010-12-01 01:24:04
|
Absolutely. I will be more than happy to pay for it, especially at these prices. Should we go with the armadillo theme you described (which sounds fine to me)? Or leave it more open-ended? Let me know how you think we should proceed. Thanks very much for the leg work. Chris -----Original Message----- From: Hamlet DArcy [mailto:ham...@ca...] Sent: Tuesday, November 30, 2010 6:34 AM To: cod...@li... Subject: [Codenarc-developer] more on a new logo Hi, Some more info on a new logo... There are 3 different offers on UpHype.com to design logos for under $20. I'd be willing to pay for that if we can decide on a logo. Here are the offers: http://uphype.com/hype/create-a-simple-but-eye-catching-logo-for-your-busine ss http://uphype.com/hype/design-a-professional-clean-web-logo http://uphype.com/hype/design-a-logo What do you think? Should we get serious about a logo? -- Hamlet D'Arcy ham...@ca... |
From: Hamlet D. <ham...@ca...> - 2010-11-30 11:34:34
|
Hi, Some more info on a new logo... There are 3 different offers on UpHype.com to design logos for under $20. I'd be willing to pay for that if we can decide on a logo. Here are the offers: http://uphype.com/hype/create-a-simple-but-eye-catching-logo-for-your-business http://uphype.com/hype/design-a-professional-clean-web-logo http://uphype.com/hype/design-a-logo What do you think? Should we get serious about a logo? -- Hamlet D'Arcy ham...@ca... |
From: Hamlet D. <ham...@ca...> - 2010-11-29 12:55:23
|
Please do add a link. -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- Awesome! Should we add a link to that to the CodeNarc home page? Chris "Hamlet D'Arcy" <ham...@gm...> 11/26/2010 04:45 PM To Cod...@li..., Cod...@li... cc Subject [Codenarc-developer] CodeNarc screencast Hi all, we made a codenarc screencast tonight. Please vote as many times as you can: http://www.dzone.com/links/groovy_codenarc_screencast_creating_a_static_anal.html Or go straight to the video: http://www.youtube.com/watch?v=ZPu8FaZZwRw -- Hamlet D'Arcy ham...@gm... ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000D031E ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer |
From: <chr...@wa...> - 2010-11-29 12:52:44
|
Awesome! Should we add a link to that to the CodeNarc home page? Chris "Hamlet D'Arcy" <ham...@gm...> 11/26/2010 04:45 PM To Cod...@li..., Cod...@li... cc Subject [Codenarc-developer] CodeNarc screencast Hi all, we made a codenarc screencast tonight. Please vote as many times as you can: http://www.dzone.com/links/groovy_codenarc_screencast_creating_a_static_anal.html Or go straight to the video: http://www.youtube.com/watch?v=ZPu8FaZZwRw -- Hamlet D'Arcy ham...@gm... ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000D031E |
From: Hamlet D'A. <ham...@gm...> - 2010-11-26 21:45:58
|
Hi all, we made a codenarc screencast tonight. Please vote as many times as you can: http://www.dzone.com/links/groovy_codenarc_screencast_creating_a_static_anal.html Or go straight to the video: http://www.youtube.com/watch?v=ZPu8FaZZwRw -- Hamlet D'Arcy ham...@gm... |
From: Hamlet D. <ham...@ca...> - 2010-11-23 13:46:10
|
The ReturnAdded needs to be invoked for "ArrayMethodReturnsNull", "BooleanMethodReturnsNull", and "CollectionMethodReturnsNull" rules. Currently, these rules only work if you use explicit return statements in your code, which most people don't. The ReturnAdder code seems quite general, and I think it would be alright to just invoke it for at least these three rules. We probably should not invoke it for every rule automatically because it does change the AST (perhaps the ExplicitReturnRule would break?) -- Hamlet D'Arcy ham...@ca... Hamlet, Yes, I did take a look at ReturnAdder (thanks for that link). I sent you an email shortly after closing that issue.The way I see it, any if statement of the form if (condition) true; else false (or false/true) is unnecessary. It can either be simplified to a single expression or else removed altogether. So, I was able to fix this issue in a pretty straightforward way. I am also planning on expanding the rule to also catch statements of the form if (condition) <constant> [else <constant>] as long as they are not the last statement in a block. So, although that ReturnAdder code is interesting, I don't yet see the need for it. Thanks. Chris Hamlet DArcy <ham...@ca...> 11/23/2010 06:35 AM To codenarc-developer <cod...@li...> cc Subject [Codenarc-developer] ReturnAdder.java from Groovy codebase Hi Chris, Just saw that you fixed this open issue "UnnecessaryIfStatement - misses if without explicit return". Did you take a look at ReturnAdder.java? I think we should just invoke this this utility method for all MethodNodes so that everyone can see the return statements it produces: http://svn.codehaus.org/groovy/trunk/groovy/groovy-core/src/main/org/codehaus/groovy/classgen/ReturnAdder.java -- Hamlet D'Arcy ham...@ca... Bugs item #3111181, was opened at 2010-11-17 21:26 Message generated for change (Comment added) made by chrismair You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111181&group_id=250145 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Chris Mair (chrismair) Assigned to: Nobody/Anonymous (nobody) Summary: UnnecessaryIfStatement - misses if without explicit return Initial Comment: >From Venkat's "Improving Your Groovy Code Quality" presentation at Spring 2GX (http://agiledeveloper.com/downloads.html) - slide #20 UnnecessaryIfStatement - misses unnecessary if/else when explicit return is omitted. e.g. def isSpellingCorrect(word) { File file = new File("...") def found = false file.eachLine { if (it == word) found = true } if (found) true else false } ---------------------------------------------------------------------- >Comment By: Chris Mair (chrismair) Date: 2010-11-23 06:26 Message: Fixed. Just added check for any if/else such as: if (condition) true; false. Will be part of version 0.12. - Chris ---------------------------------------------------------------------- Comment By: Hamlet D'Arcy (hamletdrc) Date: 2010-11-18 06:28 Message: You can see the logic for return statements in the groovy codebase. search for ReturnAdder.java. We can analyze this file and then replicate it. (or maybe invoke it!) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111181&group_id=250145 ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev_______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000CFEB2 ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer |
From: <chr...@wa...> - 2010-11-23 13:41:46
|
Hamlet, Yes, I did take a look at ReturnAdder (thanks for that link). I sent you an email shortly after closing that issue.The way I see it, any if statement of the form if (condition) true; else false (or false/true) is unnecessary. It can either be simplified to a single expression or else removed altogether. So, I was able to fix this issue in a pretty straightforward way. I am also planning on expanding the rule to also catch statements of the form if (condition) <constant> [else <constant>] as long as they are not the last statement in a block. So, although that ReturnAdder code is interesting, I don't yet see the need for it. Thanks. Chris Hamlet DArcy <ham...@ca...> 11/23/2010 06:35 AM To codenarc-developer <cod...@li...> cc Subject [Codenarc-developer] ReturnAdder.java from Groovy codebase Hi Chris, Just saw that you fixed this open issue "UnnecessaryIfStatement - misses if without explicit return". Did you take a look at ReturnAdder.java? I think we should just invoke this this utility method for all MethodNodes so that everyone can see the return statements it produces: http://svn.codehaus.org/groovy/trunk/groovy/groovy-core/src/main/org/codehaus/groovy/classgen/ReturnAdder.java -- Hamlet D'Arcy ham...@ca... Bugs item #3111181, was opened at 2010-11-17 21:26 Message generated for change (Comment added) made by chrismair You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111181&group_id=250145 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Chris Mair (chrismair) Assigned to: Nobody/Anonymous (nobody) Summary: UnnecessaryIfStatement - misses if without explicit return Initial Comment: >From Venkat's "Improving Your Groovy Code Quality" presentation at Spring 2GX (http://agiledeveloper.com/downloads.html) - slide #20 UnnecessaryIfStatement - misses unnecessary if/else when explicit return is omitted. e.g. def isSpellingCorrect(word) { File file = new File("...") def found = false file.eachLine { if (it == word) found = true } if (found) true else false } ---------------------------------------------------------------------- >Comment By: Chris Mair (chrismair) Date: 2010-11-23 06:26 Message: Fixed. Just added check for any if/else such as: if (condition) true; false. Will be part of version 0.12. - Chris ---------------------------------------------------------------------- Comment By: Hamlet D'Arcy (hamletdrc) Date: 2010-11-18 06:28 Message: You can see the logic for return statements in the groovy codebase. search for ReturnAdder.java. We can analyze this file and then replicate it. (or maybe invoke it!) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111181&group_id=250145 ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer ForwardSourceID:NT000CFEB2 |
From: Hamlet D. <ham...@ca...> - 2010-11-23 11:35:56
|
Hi Chris, Just saw that you fixed this open issue "UnnecessaryIfStatement - misses if without explicit return". Did you take a look at ReturnAdder.java? I think we should just invoke this this utility method for all MethodNodes so that everyone can see the return statements it produces: http://svn.codehaus.org/groovy/trunk/groovy/groovy-core/src/main/org/codehaus/groovy/classgen/ReturnAdder.java -- Hamlet D'Arcy ham...@ca... Bugs item #3111181, was opened at 2010-11-17 21:26 Message generated for change (Comment added) made by chrismair You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111181&group_id=250145 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Chris Mair (chrismair) Assigned to: Nobody/Anonymous (nobody) Summary: UnnecessaryIfStatement - misses if without explicit return Initial Comment: >From Venkat's "Improving Your Groovy Code Quality" presentation at Spring 2GX (http://agiledeveloper.com/downloads.html) - slide #20 UnnecessaryIfStatement - misses unnecessary if/else when explicit return is omitted. e.g. def isSpellingCorrect(word) { File file = new File("...") def found = false file.eachLine { if (it == word) found = true } if (found) true else false } ---------------------------------------------------------------------- >Comment By: Chris Mair (chrismair) Date: 2010-11-23 06:26 Message: Fixed. Just added check for any if/else such as: if (condition) true; false. Will be part of version 0.12. - Chris ---------------------------------------------------------------------- Comment By: Hamlet D'Arcy (hamletdrc) Date: 2010-11-18 06:28 Message: You can see the logic for return statements in the groovy codebase. search for ReturnAdder.java. We can analyze this file and then replicate it. (or maybe invoke it!) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3111181&group_id=250145 |