Suggestion - NecessaryGString

Brought to you by: chrismair

This project can now be found here.

#353 Suggestion - NecessaryGString

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2011-11-03

Created: 2011-09-20

Creator: Anonymous

Private: No

Codenarc catches UnecessaryGString... which will tend to make the developer habitually use single quotes.

It should probably also do the inverse..NecessaryGString

    def x=1
    println 'x= $\{x\}'

Discussion

Comment has been marked as spam.
Undo

View and moderate all "feature-requests Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Feature Requests"
Anonymous - 2011-09-20

summary: Suggestion - scan for --> Suggestion - NecessaryGString

- **summary**: Suggestion - scan for --> Suggestion - NecessaryGString

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Chris Mair - 2011-09-21

Great idea!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Chris Mair - 2011-11-03

status: open --> closed-duplicate
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Chris Mair - 2011-11-03

Closed as duplicate of rule #3180600: "String contains a valid GString token"

https://sourceforge.net/tracker/?func=detail&aid=3180600&group_id=250145&atid=1126575

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Chris Mair - 2011-11-03

status: closed-duplicate --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Chris Mair - 2011-11-03

Okay, on second thought, I am reopening, since that other issue is more specific. We can reconsider overlap later.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ken Krebs - 2011-11-15

I would agree using an unnecessary doubleQuotes should be allowed for the reason originally specified. I prefer to use doubleQuotes if I am not sure whether it will always be a String or GString. It is also the case that Groovy itself will optimize this and create a String, not a Gstring in this situation.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Chris Mair - 2012-10-11

Moving this over to Feature Requests

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.