Menu

#192 rule: list toArray() used

open
nobody
None
5
2013-02-16
2011-01-24
No

ITA: Method uses toArray() with zero-length array argument (ITA_INEFFICIENT_TO_ARRAY)

This method uses the toArray() method of a collection derived class, and passes in a zero-length prototype array argument. It is more efficient to use myCollection.toArray(new Foo[myCollection.size()]) If the array passed in is big enough to store all of the elements of the collection, then it is populated and returned directly. This avoids the need to create a second array (by reflection) to return as the result.

NOTE: Figure out the Groovy way to do this.

Discussion


Log in to post a comment.