Menu ▾ ▴

#83 Removed oro regex dependency & some collection cleanup

open
nobody
None
5
2009-09-15
2009-09-15
Joachim Hofer
No

Hi!

While trying to understand the cobertura code, I did a few simple modifications:

I removed the dependency on the Apache ORO matcher in favor of java.util.regex. - Or is there a reason for using ORO instead?
Also, I did some collections cleanup concerning generics for increased type-safety.
Also, I corrected a typo in ClassInstrumenter (regexs vs regexes). - I've now discovered that there's already another patch for that on the tracker.

I hope you find this useful.

Discussion

  • Joachim Hofer

    Joachim Hofer - 2009-09-15

    svn patch

     
    regex_cleanup.patch

  • Mark Doliner

    Mark Doliner - 2009-09-15

    My guess at the reason for using Apache ORO is that java.util.regex wasn't added until java 1.4, and Cobertura used to be compatible with Java 1.3. But I think that compatibility has been dropped, so I think this should be fine. But I'm sure the ever-wise John Lewis will take a look at it