I think a good first step is eliminating all those nasty warning messages about implicit prototypes during library building. How about moving to ANSI C declarations for all the functions, and requiring .h files when an external function call is made from another source.
Example: allphone.c
allphone.c(117) : warning #266: function declared implicitly
p = phone_to_id ("SILb", TRUE);
^
allphone.c(157) : warning #266: function declared implicitly
chan_v_eval (ci_chan+p);
^
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I agree about having function prototypes for external files since they highlight interface errors. It's even a worthwhile discipline to put prototypes for static functions at the top of the file (if the helper functions are used across a number of functions).
If you'd like to help out with some patches, that'd be good too.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think a good first step is eliminating all those nasty warning messages about implicit prototypes during library building. How about moving to ANSI C declarations for all the functions, and requiring .h files when an external function call is made from another source.
Example: allphone.c
allphone.c(117) : warning #266: function declared implicitly
p = phone_to_id ("SILb", TRUE);
^
allphone.c(157) : warning #266: function declared implicitly
chan_v_eval (ci_chan+p);
^
I agree about having function prototypes for external files since they highlight interface errors. It's even a worthwhile discipline to put prototypes for static functions at the top of the file (if the helper functions are used across a number of functions).
If you'd like to help out with some patches, that'd be good too.