From: Gregory P. <gre...@gm...> - 2010-01-24 17:55:29
|
On Sun, Jan 24, 2010 at 06:47:23PM +0100, Michael Piotrowski wrote: > > On Sun, Jan 24, 2010 at 05:49:35PM +0100, Michael Piotrowski wrote: > >> + /* > >> + * Sort regular albums by date, but sort compilations > >> + * alphabetically. > >> + */ > >> + if (u_strcasecmp(artist->name, "<Compilations>") != 0) { > > > > I think it's better to pass is-compilation flag to this function (to > > not have this magic '<Compilations>' string here). > > > > You can reuse result of track_info_is_compilation() call in > > tree_add_track(). > > Ok, this works. However, I noticed that this means that alphabetic > sorting will also apply to all albums with ALBUMARTIST set. Do we want > this? No -- we are interested only in '!artist_name && track_info_is_compilation()' cases. Gregory |