Menu

#55 race condition in _build_docs

v1.0 (example)
pending
None
5
2018-03-14
2018-03-04
No

filed with extra info in https://bugzilla.opensuse.org/show_bug.cgi?id=1083835

_build_docs is called 6 times - once for each file in bin

because of that, the code is racy when using make -j
which is the default in openSUSE package build

please review/test/merge the attached patch

1 Attachments

Discussion

  • Bernhard M. Wiedemann

    I also made this alternative less intrusive patch that leaves the flawed logic as is, but avoids the racy file corruption by using a tmpfile with an atomic rename

     
  • Duncan Ferguson

    Duncan Ferguson - 2018-03-14

    4.13.2 released with an appropriate fix in it. I didn't use your patch but fixed the underlying cause of the error (which was due to my failure in understanding how _build_docs was being called)

    Thanks for the report

     
  • Duncan Ferguson

    Duncan Ferguson - 2018-03-14
    • status: open --> pending
    • assigned_to: Duncan Ferguson
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.