Re: [CLucene-dev] Memory fixes to clucene

[<am...@ma...>]

Cheers Rob !

I'll give this a go tonight, I'm presently messing with Lucene and calling
its methods from PHP with a few Java classes (I know...desperate :-) )
Good thing is that I finally got Java working from PHP so beside the slow
response times it actually can index a given record from MySQL.
Now I'll try to get the search going and see if that can be hacked fast.

Afterwards I'll play with your CLucene source and see if that makes
the difference when used with a php extension (I hope it does), so some
tests can be run/tried Lucene vs CLucene.


-pedja

----- Original Message ----- 
From: "Rob Ristroph" <rg...@sd...>
To: <clu...@li...>
Sent: Wednesday, October 15, 2003 3:38 PM
Subject: [CLucene-dev] Memory fixes to clucene


> 
> Hi everyone,
> 
>         I put up a complete tar file of my current source tree here:
> 
> http://rgr.freeshell.org/clucene/
> 
>         I would like to submit more organized patches, however, as Ben
>         will be able to figure them out more easily.  However that's
>         going to take some time, and I know a couple of people were
>         waiting to try something out now.
> 
>         I found all the errors I fixed using valgrind.  There is still
>         one I didn't fix, which is caused when a key value is inserted
>         into the VoidList.h template, where that key value is
>         allocated with new[] but when you remove something from that
>         structure it is de-allocated with delete not delete[].  Most
>         things inserted into it are allocated with new so you can't
>         just change delete to delete[].  We can track that down later.
> 
>         I did not search for or fix memory leaks, just things which
>         caused crashes.
> 
>         I can now run on the reuter's test set, or a directory that
>         has two copies of it, without crashing.  However, if I use the
>         demo example program, and index it and the search on
>         "Microsoft", it misses some occurances of the word "Microsoft"
>         from the results (you can check with grep).  That is a bug I
>         can help work on later after the current changes have been
>         ingested and tested by a few people.
> 
>         Note that it won't help Ben much to send him a patch that is a
>         difference between something you did and this tar file.  You
>         want to make patches against what is in the CVS.
> 
>         The way I am doing it is ( now that sourceforge's CVS servers
>         seem to be back ! ) is to use the command "cvs diff".  For
>         example, I can cd into src/CLucene/utils and type "cvs diff"
>         and it will print out a diff suitable to be used as a patch
>         file that Ben (or anyone working from the CVS version) can
>         apply.
> 
>         My plan is to do exactly that, but instead of one big patch
>         for all I did, submit little ones, all changes per directory
>         or all changes that fix a particular type of problem.
>         Otherwise any mistakes I made will get lost in the noise and
>         slip past Ben.
> 
>         I'm busy in the near term, so those will start to trickle in
>         over the next couple of days, and I can have them all
>         organized and submitted by Saturday afternoon, I think.
> 
> --Rob
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> SourceForge.net hosts over 70,000 Open Source Projects.
> See the people who have HELPED US provide better services:
> Click here: http://sourceforge.net/supporters.php
> _______________________________________________
> CLucene-developers mailing list
> CLu...@li...
> https://lists.sourceforge.net/lists/listinfo/clucene-developers
>