Re: [CLucene-dev] Wrong condition in check if space for terminating NULL is available in postingsFreeListDW.values

[Kostka B. <ko...@to...>]

Itamar,

I pushed one more fix for this condition, previous one wasn't 100% correct, too. Could you please cherry pick it to master? Sorry.

BTW is there any reason, why 

          memset(this->postingsFreeListDW.values + this->postingsFreeCountDW
              , NULL
              , sizeof(Posting*));

is used instead of easier a more readable

	postingsFreeListDW.value[postingsFreeCountDW] = NULL;

?

I'm going to port as many tests as I can, but it is much more time consuming work than I expected
Not the porting itself, but some (usually minor) bugs an memory leaks in core were found by each test.

I'll try to find, which test (if any) is created to test such extreme cases and port it soon.

Borek

> -----Original Message-----
> From: Itamar Syn-Hershko [mailto:it...@co...]
> Sent: Thursday, September 16, 2010 5:26 PM
> To: clu...@li...
> Subject: Re: [CLucene-dev] Wrong condition in check if space for terminating NULL is
> available in postingsFreeListDW.values
> 
> On 16/9/2010 4:04 PM, Kostka Bořivoj wrote:
> > I'm also not sure if the whole unused part of postingsFreeListDW.values shouldn't be
> NULLified.
> >
> 
> I wouldn't know either. Weren't you porting tests to test for those
> extreme cases?
> 
> > Itamar, could you please merge this fix into master asap, as this is quite a serious
> bug?
> >
> 
> Done, see my other e-mail regarding this.
> 
> Itamar.
> 
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> CLucene-developers mailing list
> CLu...@li...
> https://lists.sourceforge.net/lists/listinfo/clucene-developers