#237 Script `create-ocs-tmp-img` doesn't rename sda1.aa

[Łukasz Stefanowicz]

The problem exist in testing 2.4.2-59 and stable version 2.4.2-32 when restoring disk image (containing FAT16 partitions) made with partimage (BTW partclone did not recognize FAT version).

Script create-ocs-tmp-img tries to create converted image (sda -> sdc) in /tmp the result:

incorrectly created symbolic links:
sda1.aa -> /home/partimag/R4-HDD-2015-10-10-20-img/sda1.aa
sda5.aa -> /home/partimag/R4-HDD-2015-10-10-20-img/sda5.aa

other files are renamed correctly:
sdc-hidden-data-after-mbr
sdc-mbr
sdc-pt.parted
sdc-pt.parted.compact
sdc-pt.sf

Then of course restoration failes missing sdc1.aa sdc5.aa files.

I've attached proper part of log and ls of converted image directory.

[Łukasz Stefanowicz]

I think I've found a solution ;)
In script cnvt-ocs-dev:

 diff -u cnvt-ocs-dev.old cnvt-ocs-dev
--- cnvt-ocs-dev.old    2013-04-29 14:34:18.000000000 +0200
+++ cnvt-ocs-dev        2015-10-13 10:27:34.204450200 +0200
@@ -217,6 +217,7 @@
 # Better way to list all of them:
 filenames_2_be_mod_about_disk="$(LC_ALL=C find $ocsroot/$image_name/ -name "$(to_filename ${src_dev})-*" -print | sort)"
 filenames_2_be_mod_about_parts="$(LC_ALL=C find $ocsroot/$image_name/ -name "$(to_filename ${src_dev})*.*-img*" -print | sort)"
+filenames_2_be_mod_about_parts="$filenames_2_be_mod_about_parts $(LC_ALL=C find $ocsroot/$image_name/ -name "$(to_filename ${src_dev})*.aa" -print | sort)"
 filenames_2_be_mod_about_swap="$(LC_ALL=C find $ocsroot/$image_name/ -name "swappt-$(to_filename ${src_dev})*.info" -print | sort)"

 # Process the disk-related file names

[Steven Shiau]

Thanks for the patch. We will try to include that in the future release.
However, partimage is not developed anymore, and we keep it is to make clonezilla compatible to old image. It's recommended not to use it.
BTW, what did you maen by "partclone did not recognize FAT version"?
Partclone has the following programs:
partclone.fat
partclone.fat12
partclone.fat16
partclone.fat32
partclone.vfat
It can be used to save the FAT system.

Steven.

[Łukasz Stefanowicz]

Ok, thank you - I'm looking forward for the future release ;)
I've used latest stable release 2.4.2-32 to make backups of very old hard drives with fat16 partitions.
Partclone failed with something like "unrecognized fat version". Partimage worked ok.

Łukasz.

[Steven Shiau]

"Partclone failed with something like "unrecognized fat version". Partimage worked ok." -> Could you please take a photo about this? We'd like to fix it about partclone.
Thanks.

Steven.

[Łukasz Stefanowicz]

I was able to reproduce error using VirtualBox (restored image and than tried to do savedisk using partclone).

I've attached screenshot of the error.

Here is partclone.log:

Partclone v0.2.83 http://partclone.org
Starting to clone device (/dev/sda1) to image (-)
Reading Super Block
fatclone.c: Unknown fat type!!

And fdisk -l output:

Disk /dev/sda: 12.1 GiB, 13015048192 bytes, 25420016 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0xac76e12e

Device     Boot Start   End Sectors  Size Id Type
/dev/sda1  *       63 64259   64197 31.4M  4 FAT16 <32M

Łukasz.

[Steven Shiau]

Cool. Could you please share us the virtualbox disk file?
Thanks.

Steven.

[Łukasz Stefanowicz]

Here you are, vdi (VirtualBox 5.0.4). I've wiped out files (there's only README.TXT).

[Steven Shiau]

Thanks. I have confirmed this issue in my virtualbox.
Assigning this to the main developer of partclone, Thomas Tsai.

Steven.

[Steven Shiau]

BTW, how did format that as FAT16?
Could you please tell us the environment (E.g. Windows 95? Ubuntu Linux?) and the commands?
Thanks.

Steven.

[Łukasz Stefanowicz]

DOS...very old DOS... :)
I don't know when, how or does person who formated this is still alive ;)

[Łukasz Stefanowicz]

Will you apply patch (*.aa image name format) in the future release?

[Steven Shiau]

Thomas Tsai has fixed the FAT issue for partclone, and we will release another testing Clonezilla live with the new partclone (0.2.85) tomorrow.
I tended to not apply the patch about this. Basically partimage is deprecated in Clonezilla, and actually there are more files to be changed if we want to support it again in Clonezilla.
Thanks for your understanding.

Steven.

[Steven Shiau]

We have released an updated Clonezilla live 2.4.3-2 or 20151110-wily to address the partclone/fat16 issue:
http://clonezilla.org/downloads.php
Could you please test it and let us know the results?
Thanks.

Steven.

[Łukasz Stefanowicz]

Not working...it detects partition as fat12! After creating backup and restoring it: filenames are visible, but dos program hangs on booting.

[Steven Shiau]

Thanks for your report. Yes, this is a bug in Partclone 0.2.85, and Thomas has fixed it in Partclone 0l.2.86. We will have another testing Clonezilla live release with this updated partclone next week.

Steven.

[Steven Shiau]

Could you please give Clonezilla live 2.4.3-3 a try?
http://clonezilla.org/downloads.php
The partclone has been updated and we are sure it can identify the file system as fat16 in your VDI file. However, not sure if it could boot or not.
Please test it and let us know the results.
Thanks.

Steven.

[Łukasz Stefanowicz]

I can confirm it is working. Properly detected partition as FAT16, saved disk and restored it.

Łukasz.

[Steven Shiau]

Cool! Thanks for yoru confirmation.

Steven.