From: Sam S. <sd...@gn...> - 2018-01-29 14:53:12
|
Hi Bruno, In addition to Don's objections to new syntax (which I agree with and opposed to), I have another objection: > * Bruno Haible <oe...@py...t> [2018-01-28 11:24:02 +0100]: > > ...On AIX and HP-UX. Caused by the lack of support for /dev/fd/1.... the cause of the problem is "lack of support for /dev/fd/1" rather than specific OS. we need to check for features, not OS. iow, check whether "/dev/fd/1" is supported, not the name of the os. we already have an "#if" nightmare in lispbibl.d, let us not duplicate it in tests. > 2) When a group of tests belongs together, and a test fails, skip the > remaining tests of the same group. why not move such tests into a separate file and run that file is the feature is present? iow, (when (probe-namestring "/dev/fd/1") (push "mkst" *all-tests*)) > To solve problem 1), I propose to add - in tests.lisp - OS names to the > *features* list. So that it becomes possible to write #+(or AIX HP-UX). > Outside of the test suite, i.e. for user programs, there should be no > distinction between Linux, AIX, HP-UX, etc. oh no! please! > To solve problem 2), I propose a syntax with braces: > { > FORM1 > EXPECTED-RESULT1 > FORM2 > EXPECTED-RESULT2 > ... > } > > To solve problem 3), I propose a syntax like this: > $+CONDITION > FORM > EXPECTED-RESULT I would much rather stick with the Lisp syntax. Thanks. -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1561 http://steingoldpsychology.com http://www.childpsy.net http://camera.org https://ffii.org http://americancensorship.org https://jihadwatch.org I don't want to be young again, I just don't want to get any older. |