Re: 12 bugfixes patches

[Sam S. <sd...@gn...>]

Hi Reini,
please create patches on
https://sourceforge.net/p/clisp/patches/

> * Reini Urban <erv...@tz...> [2017-03-22 21:51:15 +0100]:
>
> Subject: [PATCH 04/12] configure: typo exisiting
> Subject: [PATCH 05/12] fix cygwin/mingw --without-dynamic-modules

done, thanks

> Subject: [PATCH 07/12] modprep: add missing doc field to funcdef

what is the benefit of this?

> Subject: [PATCH 10/12] fix various cygwin tests

this prevents some tests from failing.
could it be that you are hiding a bug in clisp?

> Subject: [PATCH 11/12] win32: ddk/ntifs.h -> winternl.h, ntstatus.h
>
> Do not include private ddk headers, where winternl.h is good enough.
> ddk/ntifs.h cannot be loaded on most modern mingw settings. (mingw64 32/64 bit)
>
> Have no idea if this is backcompat.

the doc says:

Header: Wdm.h (include Wdm.h, Ntddk.h, or Ntifs.h)

> Subject: [PATCH 12/12] win32: add -I. for include w32shell.c
>
> gcc does not have -I. as default.
> clisp.c:2191:23: fatal error: w32shell.c: No such file or directory
>  # include <w32shell.c>
> ---
>  src/makemake.in | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git src/makemake.in src/makemake.in
> index b50f0ade9..10d240946 100644
> --- src/makemake.in
> +++ src/makemake.in
> @@ -1449,6 +1449,11 @@ if [ "${with_debug}" != no ] ; then
>    esac
>  fi
>  
> +if [ ${HSYSOS} = win32gcc -o ${HSYSOS} = cygwin ]
> +then
> +  # include <w32shell.c>
> +  XCFLAGS=$XCFLAGS' -I.'
> +fi
>  if [ $CC_CPLUSPLUS = true -a \( ${HSYSOS} = win32gcc -o ${HSYSOS} = cygwin \) ]
>  then # This is necessary for g++ to handle w32shell.c:
>    # The member lpVtbl is not defined by the w32api include files if

We prefer "then" to be on the same line as "if", see other code in the file.


-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504
http://steingoldpsychology.com http://www.childpsy.net http://iris.org.il
http://islamexposedonline.com http://www.dhimmitude.org http://think-israel.org
When we break the law, they fine us, when we comply, they tax us.