Re: status update

[Sam S. <sd...@gn...>]

> * Daniel Jour <qna...@tz...> [2016-08-25 21:35:57 +0200]:
>
>> - Merging in your changes: where is your repo, how can I access your
>>  patchsets &c.
>
> Here's my fork of the main repo (I can currently not provide a link
> listing only my commits due to the limited internet access):
>
> https://sourceforge.net/u/musteresel/clisp/ci/default/tree/
>
> This contains the changes that are currently useable. One thing I need
> to check is whether I included the files related to gnulib (I think I
> didn't, just the cache from which they can be reproduced using
> gnulib-tool).

15613::::Daniel Jour 2016-04-30 clisp-link.in: Replace /bin/pwd with calls to pwd (for NixOS)

pwd is also a shell built-in, so full path is necessary.

15614::::Daniel Jour 2016-04-30 modules/bindings/glibc/linux.lisp: Replace non-standard header include

Fine (I committed an equivalent patch a couple of weeks ago).
This is out of scope though.

15615::::Daniel Jour 2016-05-01 lispbibl.d: don't treat value1 extra if it's not in a register

The metadata (ChangeLog, log summary) is lacking.
I merged this patch with the appropriate metadata.
This is also out of scope though.

15616::::Daniel Jour 2016-05-16 Update asdf to version 3.1.7

Accepted.

15617::::Daniel Jour 2016-05-18 Don't call cat by absolute path

why?

15618::::Daniel Jour 2016-05-18 Fix locale related errors when testing getdate

Accepted.

15619::::Daniel Jour 2016-06-09 Disable TRIVIALMAP_MEMORY and SINGLEMAP_MEMORY on NetBSD

Accepted.

15620::::Daniel Jour 2016-06-19 regexp: use autotools, gnulib, improve buffer handling

0! This is 3 patches in one:
   (a) autotools
   (b) alloca-->static
   (c) do not compute matches when a boolean is returned
1. Why are you replacing stack allocation with arbitrary limits?
2. Is it really necessary to create a separate m4 directory for the
   single file gnulib-cache.m4? It's really ugly! (same for the rawsock
   change below).

15621::::Daniel Jour 2016-06-20 regexp: wrap foreign pointer in REGEX structure
15622::::Daniel Jour 2016-06-21 regexp: Don't return a list when there are many matches
15623::::Daniel Jour 2016-06-21 regexp: Allow selection of return type also for match

these do not apply cleanly without the above.


15624::::Daniel Jour 2016-06-22 Remove comment5 utility, and any remaining non-C comments

Nope.
Each line with separate /* .. */ is ugly.
We need to use either blocks or //.
When did // comments go into the C standard?
Also, I think this should be done together with removing all
pre-processing and renaming all *.d files to *.c.

15625:::tip:Daniel Jour 2016-08-23 rawsock: autotools build system, own gnulib checkout

Copying code from socked.d into rawsock.c is no good.
Also, you removed the configure script, so now people have to install
autoconf to build clisp.
Are you sure this is right?

DIUC that the main change required to make rawsock work on windows was
the switch from rawsock_t to int?



> Next, the changes towards an autotools based build (and configuration)
> system:
>
> https://gist.github.com/musteresel/ee87db0a79e4eb22cfdd2d85afe45bff

what does "wip" in "wip-autotools-export" stand for?
the change to built.d seems incomplete.

> This is a squashed commit (I made some changes back and forth which
> are not that usefull in a commit history) of the current WIP state,
> exported using hg export (thus should be importable using hg import on
> the above repository).

I need to understand what you are doing before importing anything.
The best way would be if you made an isolated change
(e.g., I don't see why you had to touch built.d).


> Then, the libmagic module:
>
> https://gist.github.com/musteresel/6c3b9eeea10818c7e8f6d6672b030401
>
> It's still missing tests and does not cover the complete functionality
> provided by the libmagic on my system.

Okay, by the time you finish it you will probably have write access to
the tree ;-)

>> The upshot is that we need a link to your code.
>> This is urgent.
>
> Sorry for the delay, does the above help?

Yes, thanks.

>> - Making a release. How much effort will you be able to dedicate to
>>  CLISP during the school year (your studies are, of course, the
>>  priority)?
>
> In September probably almost none (exams). Starting Mid-October I'd
> estimate about 10hrs/week, though could also be more ...

Okay, so let us talk then if you are still interested.


-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1404
http://www.childpsy.net/ http://palestinefacts.org http://jihadwatch.org
http://dhimmi.org http://think-israel.org http://honestreporting.com
When arguing with the wife, think: do you want to be right or happy?