Re: clisp - general interest in code cleanup

[Daniel J. <dan...@gm...>]

Sam Steingold writes:
> The approach of you refactoring many huge files and us reviewing your
> changes does not scale because none of us have time for that.

Oh, I see! That indeed wouldn't make much sense now.

>>> all files include lispbibl.d, so this means that all files use them. :-)
>>
>> Hehe, what I meant was more like: There seems to be versions of
>> alloca, an avl tree, sorting code, safe malloc and more in CLISP's code
>> that could be also provided by gnulib. That's what's confusing me: Are
>> these separate versions on purpose, or just not yet replaced by the
>> Gnulib ones?
>
> CLISP has a lot of code which is now available elsewhere because much of
> CLISP was written 20+ years ago.
>
> I see no problem in relying on external libraries.
> I am not sure that gnulib provides avl trees though.

Good. It does, there are three implementations, written by Bruno Haible, so
I'd guess they're probably very similar or even the same as the CLISP
implementation:
https://www.gnu.org/software/gnulib/MODULES.html#ansic_ext_container

>> What's the general course of action here? Fix it in gnulib (as far as
>> that's possible, eventually using it's local modules feature) or work
>> around "here"?
>
> I suggest that you discuss this on the gnulib mailing list.
> I have no idea what the gnulib people will recommend.

Ok, I'll do that (searching the list for preliminary information now).

> I added a couple minor comments, otherwise lgtm.

Thank you :)