Re: clisp - general interest in code cleanup

[Sam S. <sd...@gn...>]

> * Daniel Jour <qnavry.bregjvt@tznvy.pbz> [2016-03-23 08:41:00 +0000]:
>
> That's great. I agree, modernizing the complete code base is a task that's
> too huge to attempt as a first CLISP project. What I hoped for was that it's
> ok if, picking a random example, readtable related code got extracted from
> src/io.d, i.e. it's ok when runtime code is refactored to some degree.

this approach does not scale.

>> 1. update all gnulib imports
>
> To what extend is CLISP using gnulib atm? I've found the
> gnulib-imported target in Makefile.devel (as well as related stuff),
> but am unsure how far the actual src/* files make use of it. As far as
> I can tell only src/lispbibl.d, src/_clisp.c and src/glmalloc.c seem
> to use it (only taking the runtime into approach, not any modules).

all files include lispbibl.d, so this means that all files use them. :-)

>> 2. fix gnulib/Windows interaction (gnulib assumes FD to be an int,
>>    Windows uses Handles)
>
> Can you provide a bit more background on that? Is this related to
> http://lists.gnu.org/archive/html/bug-gnulib/2016-03/msg00033.html and
> thus a general gnulib issue? Or does this only affect CLISP?

this is a general property of gnulib.
clisp used to work around this, but the latest import of gnulib files (5
years ago?) broke it.
IIRC, clisp no longer builds on windows.

> How "extensive" are these self-tests?

there are a lot of them and they cover most of the code.
(modules have their own tests).

> I guess I should get a proposal ready ASAP then.

please do!


-- 
Sam Steingold (http://sds.podval.org/) on Ubuntu 15.10 (wily) X 11.0.11702000
http://www.childpsy.net/ http://memri.org http://islamexposedonline.com
http://honestreporting.com http://truepeace.org http://think-israel.org
God had a deadline, so He wrote it all in Lisp.