[ clisp-Bugs-3432970 ] Case-sensitive structs miscompiled? [suggested fix]

[SourceForge.net <no...@so...>]

Bugs item #3432970, was opened at 2011-11-03 13:37
Message generated for change (Settings changed) made by mak08
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101355&aid=3432970&group_id=1355

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: clisp
Group: lisp error
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Michael Kappert (mak08)
>Assigned to: Bruno Haible (haible)
Summary: Case-sensitive structs miscompiled? [suggested fix]

Initial Comment:
It seems that keywords are stored incorrectly in the fasl for case-sensitive struct literals:

$ cat struct-case.cl
(defpackage "STORE" (:modern t))
(in-package store)

(defstruct book title author)

(defmacro defbook-expand (title author)
  (make-book :title title :author author))

(defvar *et-book* (defbook-expand  "aTitle" "anAuthor"))
......
cs-user> (compile-file "/home/michael/Projects/scratch/struct-case.cl")
;; Compiling file /home/michael/Projects/scratch/struct-case.cl ...
;; Wrote file /home/michael/Projects/scratch/struct-case.fas
0 errors, 0 warnings
#P"/home/michael/Projects/scratch/struct-case.fas"
nil
nil
cs-user> (load *)
;; Loading file /home/michael/Projects/scratch/struct-case.fas ...
; Evaluation aborted on #<system::simple-keyword-error #x0003348AA920>.
cs-user> 

The struct literal appears in the fasl as
S(|STORE|::|book| :|title| "aTitle" :|author| "anAuthor")


----------------------------------------------------------------------

Comment By: Michael Kappert (mak08)
Date: 2011-11-07 12:55

Message:
This is probably much too crude, but it fixes the problem for me: I think
keywords should always be printed in upppercase in pr_structure_default. I
could see no regressions in make check (tested only on Ubuntu). 

diff -r 8f5a8b96a72d src/io.d
--- a/src/io.d	Mon Oct 17 14:59:11 2011 +0300
+++ b/src/io.d	Mon Nov 07 21:48:12 2011 +0100
@@ -8409,7 +8409,7 @@
         {    /* Print (symbol-name (clos:slot-definition-name slot)): */
           var object obj = TheSlotDefinition(*slot_)->slotdef_name;
           if (!symbolp(obj)) goto bad_clas;
-          pr_like_symbol(stream_,Symbol_name(obj)); /* print symbolname of
component */
+          pr_symbol_part(stream_,Symbol_name(obj),false,false); /* print
symbolname of component */
         }
         JUSTIFY_SPACE;
         JUSTIFY_LAST(true);


----------------------------------------------------------------------

Comment By: Michael Kappert (mak08)
Date: 2011-11-04 14:58

Message:
Now it seems more like a bug in the print-object method for structs:
cs-user> (defstruct foo bar)
foo
cs-user> (let ((*print-readably* nil)) (read-from-string (format nil "~s"
#s(foo :bar "bar"))))
#S(foo :bar "bar")
18
cs-user> (let ((*print-readably* t)) (read-from-string (format nil "~s"
#s(foo :bar "bar"))))
; Evaluation aborted on #<system::simple-keyword-error #x0003348EB220>.
cs-user> (let ((*print-readably* t)) (read-from-string (format nil "~s"
#s(foo :BAR "bar"))))
; Evaluation aborted on #<system::simple-keyword-error #x0003348EB240>.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101355&aid=3432970&group_id=1355