[ clisp-Patches-3087696 ] patch for bug 3087668

[SourceForge.net <no...@so...>]

Patches item #3087696, was opened at 2010-10-14 17:59
Message generated for change (Comment added) made by sds
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=301355&aid=3087696&group_id=1355

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Julian Squires (tek)
Assigned to: Arseny Slobodyuk (ampy)
Summary: patch for bug 3087668 

Initial Comment:
Bug 3087668 seems to occur because the trailing backslash in (ext:probe-pathname "C:\\") is stripped off before real_path, which means it gets interpreted as a relative path.  Additionally, FindFirstFile fails when passed a path with a trailing backslash.  The attached patch appears to fix this problem; I'm not terribly familiar with the source so hopefully it's appropriate.

----------------------------------------------------------------------

>Comment By: Sam Steingold (sds)
Date: 2010-10-16 21:26

Message:
Arseny, I disagree,
c: means the default directory on c drive c
c:/ means the top-level directory on drive c


----------------------------------------------------------------------

Comment By: Arseny Slobodyuk (ampy)
Date: 2010-10-15 20:45

Message:
Thanks for the patch and investigation, Julian. I'll se how to fix the bug,
probably real_path shouldn't add the slash. As far as I can see,
(probe-pathname "C:\\") should be equivalent to (probe-pathname "C:") and
mean "drive C exists", correct me if I wrong.

----------------------------------------------------------------------

Comment By: Julian Squires (tek)
Date: 2010-10-15 14:39

Message:
Doh.  I'm sorry, I hadn't realized the code paths I was changing weren't
all win32.  I've included an #ifdef in the patch, but at this point you
probably know a cleaner solution than I.

----------------------------------------------------------------------

Comment By: Sam Steingold (sds)
Date: 2010-10-15 14:19

Message:
thanks for the patch.
unfortunately, it breaks clisp on unix.

----------------------------------------------------------------------

Comment By: Julian Squires (tek)
Date: 2010-10-14 18:12

Message:
Sorry, my original patch didn't include a ChangeLog entry, and included a
few errant tabs.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=301355&aid=3087696&group_id=1355