[ clisp-Bugs-1672132 ] mprotect configure test incorrect

[SourceForge.net <no...@so...>]

Bugs item #1672132, was opened at 2007-03-01 18:26
Message generated for change (Comment added) made by fgstep
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101355&aid=1672132&group_id=1355

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: ffcall
Group: build problems
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Fedor (fgstep)
Assigned to: Bruno Haible (haible)
Summary: mprotect configure test incorrect

Initial Comment:
The configure test for mprotect appears to be incorrect, producing exactly the opposite result it is supposed to. Attached is the patch

----------------------------------------------------------------------

>Comment By: Adam Fedor (fgstep)
Date: 2007-03-01 22:37

Message:
Logged In: YES 
user_id=1326233
Originator: YES

The autoconf code for AC_TRY_RUN is roughly: 
AC_TRY_RUN(program, action-if-succeed, action-if-fail,
action-if-cross-compile), 
and in mprotect.m4, it's implemented roughly as:
AC_TRY_RUN('mprotect program', no_mprotect=1, , )
so no_mprotect gets set if the program suceeds (it's correct in the first
test but not the others). Later on, it's tested:  if test -z
"$no_mprotect"; cl_cv_func_mprotect_works=yes - so the test shows mprotect
as working if no_mprotect is NOT set, but the previous AC_TRY_RUN tests set
no_mprotect if it does works.  I can show you a config.log file where the
mprotect test clearly fails, but HAVE_WORKING_MPROTECT is defined. Perhaps
it's worked all these years for other reasons?

Actually, I found this on powerpc-apple-darwin8.8 and fixed it, but this
just causes other problems, which may be similar to bug #1535284. Perhaps I
just need to look at the wider issue of what's not working...


----------------------------------------------------------------------

Comment By: Sam Steingold (sds)
Date: 2007-03-01 22:00

Message:
Logged In: YES 
user_id=5735
Originator: NO

the current code have been detecting mprotect just fine for many years.
could you please be more specific - what are you unhappy about?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101355&aid=1672132&group_id=1355