clisp-devel

[PATCH 2/2] silence comment5 warnings

[Reini U. <rei...@gm...>]

Like "End of comment outside comment in line"
caused by multi-line comments not detected as such with #define.
---
 src/aridecl.d  | 10 +++++-----
 src/lispbibl.d |  6 +++---
 2 files changed, 8 insertions(+), 8 deletions(-)

Re: [PATCH 2/2] silence comment5 warnings

[Sam S. <sd...@gn...>]

> * Reini Urban <ervav.heona@tznvy.pbz> [2017-03-20 08:02:59 +0100]:
>
> Like "End of comment outside comment in line"
> caused by multi-line comments not detected as such with #define.

I would rather eliminate comment5 altogether, rather than mutilate the
code to pacify it.

IOW, whenever you translate a file, please convert comments to C, and
then we will dump comment5.

Thanks!

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504
http://steingoldpsychology.com http://www.childpsy.net https://ffii.org
https://jihadwatch.org http://honestreporting.com http://memri.org
A language that does not change the way you think is not worth learning.

Re: [PATCH 2/2] silence comment5 warnings

[Reini U. <rei...@gm...>]

> On Mar 20, 2017, at 4:58 PM, Sam Steingold <sd...@gn...> wrote:
> 
>> * Reini Urban <ervav.heona@tznvy.pbz> [2017-03-20 08:02:59 +0100]:
>> 
>> Like "End of comment outside comment in line"
>> caused by multi-line comments not detected as such with #define.
> 
> I would rather eliminate comment5 altogether, rather than mutilate the
> code to pacify it.
> 
> IOW, whenever you translate a file, please convert comments to C, and
> then we will dump comment5.

Agreed, much better. Almost done with all in my translate branch.
When I finished the last 2 files, I’ll rename them all to .c and remove comment5.

Re: [PATCH 2/2] silence comment5 warnings

[Bruno H. <br...@cl...>]

Hello Reini,

I don't agree with this patch. The code that caused the warning messages
is valid C. This, for example, is a valid C program:

==========================================================================
#include <stdio.h>

#define hello "hello world" /* some nice
                               greeting */
int main () {
  printf (hello "\n");
}
==========================================================================

Or even this:
==========================================================================
#include <stdio.h>

#define hello "hello world" /\
* some nice
                               greeting *\
/
int main () {
  printf (hello "\n");
}
==========================================================================

I prefer much to fix the tools so that they understand the C syntax that
we use, rather than to add a constraint that we would have to remember
in future developments.

Done by modifying varbrace.c.

Sam wrote:
> I would rather eliminate comment5 altogether, rather than mutilate the
> code to pacify it.

Eliminating comment5 would not help here, since the warning comes from
'varbrace', and comment5's processing does not modify the lines that
trigger the warning.

Bruno

Re: [PATCH 2/2] silence comment5 warnings

[Daniel J. <dan...@gm...>]

Bruno wrote:
> Done by modifying varbrace.c.

Wouldn't it be better to finally get rid of varbrace? I have not
tested it, but a single

#define var

in lispbibl.d should do it until all those "var" pseudo-keywords are
removed, no?

Re: [PATCH 2/2] silence comment5 warnings

[Sam S. <sd...@gn...>]

Hi Bruno,

> * Bruno Haible <oe...@py...t> [2017-03-21 00:27:16 +0100]:
>
> Sam wrote:
>> I would rather eliminate comment5 altogether, rather than mutilate the
>> code to pacify it.
>
> Eliminating comment5 would not help here, since the warning comes from
> 'varbrace', and comment5's processing does not modify the lines that
> trigger the warning.

varbrace is not needed either. C99, IIRC, supports arbitrary placement
of declarations.

We need to drop comment5 and varbrace and rename all *.d files to *.c.
Then gctrigger should convert them to *.m.c and cc should compile *.m.c
to *.o.

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504
http://steingoldpsychology.com http://www.childpsy.net https://ffii.org
http://mideasttruth.com https://jihadwatch.org http://www.dhimmitude.org
main(a){printf(a,34,a="main(a){printf(a,34,a=%c%s%c,34);}",34);}