clisp-devel

nightly build make check etc

[<don...@is...>]

1. tail of output of make check:
(seems a bad way for make check to end)

 Copyright (c) Sam Steingold, Bruno Haible 2001-2018

 Type :h and hit Enter for context help.

 ;; connecting to "http://clisp.org/beta/impnotes/id-href.map"...connected...HTTP/1.1 301 Moved Permanently --> "https://clisp.sourceforge.io/beta/impnotes/id-href.map"
 *** - OPEN-HTTP("https://clisp.sourceforge.io/beta/impnotes/id-href.map"):
       HTTPS protocol is not supported yet
 Bye.
 Makefile:2247: recipe for target 'check-doc' failed
 make: *** [check-doc] Error 1


2. tail of output of make extracheck:
(Is this output considered "correct"?)

 STACK size: 98238 [0x180000bfe00 0x18000000010]
 if ./image; then exit 1; fi
 STACK size: 98238 [0x180000bfe00 0x18000000010]
 *** - myerror
 ls -l lisp.run lispinit.mem image image.mem
 -rwxr-xr-x. 1 don don 9894688 Jan 24 04:09 image
 -rw-r--r--. 1 don don 3357472 Jan 24 04:09 image.mem
 -rw-r--r--. 1 don don 3361472 Jan 24 03:09 lispinit.mem
 -rwxr-xr-x. 1 don don 6532472 Jan 24 03:08 lisp.run
 rm -f image image.mem


3. tail of output of make mod-check:
This looks like a big improvement.

 EQL-OK: 5
 RUN-TEST: finished #P"/home/don/hg/clisp/modules/readline/test.tst" (0 errors out of 37 tests)
 finished   4 files:               3 errors out of     632 tests
   1             i18n/test.tst:    0 errors out of      11 tests
   2         syscalls/test.tst:    3 errors out of     264 tests
   3           regexp/test.tst:    0 errors out of     320 tests
   4         readline/test.tst:    0 errors out of      37 tests
 Bye.
 Makefile:2403: recipe for target 'base-mod-check' failed
 make: *** [base-mod-check] Error 1


syscalls/test.erg:

Form: (LET ((DIR "syscalls-tests-dir/") (DEST "qwer/adsf") COPY) (WHEN (NTH-VALUE 1 (ENSURE-DIRECTORIES-EXIST DIR :VERBOSE T)) (MAPC #'DELETE-FILE (DIRECTORY (CONCATENATE 'STRING DIR "**") :IF-DOES-NOT-EXIST :KEEP))) (SETQ COPY (COPY-FILE DEST DIR :METHOD :SYMLINK)) (LIST (STRING= DEST (CAAR COPY)) (STRING= (PATHNAME-NAME DEST) (PATHNAME-NAME (DELETE-FILE (CADAR COPY)))) (DELETE-DIRECTORY DIR) (PROBE-PATHNAME DIR)))
CORRECT: (T T T NIL)
CLISP  : ERROR
OS-FILE-ERROR(ENOENT): No such file or directory
OUT:
"Creating directory: /home/don/hg/clisp/build-dir/syscalls-tests-dir/
[OS-FILE-ERROR]: OS-FILE-ERROR(ENOENT): No such file or directory
"


Form: (LET ((DIR "syscalls-tests-dir/") (LINK #P"syscalls-tests-symlink/")) (LIST (MAKE-DIRECTORY DIR) (STRING= DIR (CAAR (COPY-FILE DIR LINK :METHOD :SYMLINK))) (DELETE-DIRECTORY DIR) (DELETE-DIRECTORY LINK)))
CORRECT: (T T T T)
CLISP  : ERROR
OS-FILE-ERROR(EEXIST): File exists
OUT:
"[OS-FILE-ERROR]: OS-FILE-ERROR(EEXIST): File exists
"


Form: (LET ((DIR "syscalls-tests-dir/") (DEST "foo/bar")) (MAKE-DIRECTORY DIR) (COPY-FILE DEST DIR :METHOD :SYMLINK) (HANDLER-CASE (OR (DELETE-DIRECTORY DIR) (ERROR "deleted non-empty directory")) (OS-ERROR (E) (OR (EQ (OS-ERROR-CODE E) :ENOTEMPTY) (INTEGERP (OS-ERROR-CODE E)) (ERROR "wrong error code: ~s" (OS-ERROR-CODE E))))) (MAPC #'DELETE-FILE (DIRECTORY (CONCATENATE 'STRING DIR "**") :IF-DOES-NOT-EXIST :KEEP)) (DELETE-DIRECTORY DIR))
CORRECT: T
CLISP  : ERROR
OS-FILE-ERROR(EEXIST): File exists
OUT:
"[OS-FILE-ERROR]: OS-FILE-ERROR(EEXIST): File exists
"

Re: nightly build make check etc

[Sam S. <sd...@gn...>]

> * Don Cohen <qba...@vf...3-vap.pbz> [2018-01-24 16:22:15 +0000]:
>
> 1. tail of output of make check:
> (seems a bad way for make check to end)
>
>  Copyright (c) Sam Steingold, Bruno Haible 2001-2018
>
>  Type :h and hit Enter for context help.
>
>  ;; connecting to "http://clisp.org/beta/impnotes/id-href.map"...connected...HTTP/1.1 301 Moved Permanently --> "https://clisp.sourceforge.io/beta/impnotes/id-href.map"
>  *** - OPEN-HTTP("https://clisp.sourceforge.io/beta/impnotes/id-href.map"):
>        HTTPS protocol is not supported yet
>  Bye.
>  Makefile:2247: recipe for target 'check-doc' failed
>  make: *** [check-doc] Error 1

disable check-doc or run it as

hg clone http://hg.code.sf.net/p/clisp/www /tmp/clisp-www
make IMPNOTES=/tmp/clisp-www/impnotes check-doc

>
> 2. tail of output of make extracheck:
> (Is this output considered "correct"?)
>
>  STACK size: 98238 [0x180000bfe00 0x18000000010]
>  if ./image; then exit 1; fi
>  STACK size: 98238 [0x180000bfe00 0x18000000010]
>  *** - myerror
>  ls -l lisp.run lispinit.mem image image.mem
>  -rwxr-xr-x. 1 don don 9894688 Jan 24 04:09 image
>  -rw-r--r--. 1 don don 3357472 Jan 24 04:09 image.mem
>  -rw-r--r--. 1 don don 3361472 Jan 24 03:09 lispinit.mem
>  -rwxr-xr-x. 1 don don 6532472 Jan 24 03:08 lisp.run
>  rm -f image image.mem

probably.
the only reliable indicator is the `make` exist status.

Thanks for testing!

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1561
http://steingoldpsychology.com http://www.childpsy.net
http://jij.org http://think-israel.org http://no2bds.org
Microsoft: announce yesterday, code today, think tomorrow.

Re: nightly build make check etc

[<don...@is...>]

Sam Steingold writes:
 > disable check-doc or run it as
how does one disable it?
You mean edit the make file or can you do something like
 make check --exclude check-doc

 > > 2. tail of output of make extracheck:
 > > (Is this output considered "correct"?)
 > probably.
 > the only reliable indicator is the `make` exist status.

perhaps that result could be printed?

How about #3 mod-check ?

Re: nightly build make check etc

[Bruno H. <br...@cl...>]

Don Cohen writes:
>  > the only reliable indicator is the `make` exist status.
> 
> perhaps that result could be printed?

When you run "../configure --cbcx", it creates log files
cbcstep1.log ... cbcstep6.log, and each of these files ends in a line
such as
  ===> make extracheck SUCCEEDED
or
  ===> make extracheck FAILED

It's easy to grep for.

Bruno

Re: nightly build make check etc

[<don...@is...>]

Bruno Haible writes:
 > Don Cohen writes:
 > >  > the only reliable indicator is the `make` exist status.
 > > 
 > > perhaps that result could be printed?
 > 
 > When you run "../configure --cbcx", it creates log files
 > cbcstep1.log ... cbcstep6.log, and each of these files ends in a line
 > such as
 >   ===> make extracheck SUCCEEDED
 > or
 >   ===> make extracheck FAILED
 > 
 > It's easy to grep for.

I see it also ends with a summary:

  Bye.
  Makefile:2407: recipe for target 'full-mod-check' failed
  make: *** [full-mod-check] Error 1
  ===> make full-mod-check FAILED
  Step 1 ===> /bin/sh ../src/configure --disable-option-checking --disable-maintainer-mode --cache-file=config.cache SUCCEEDED
  Step 2 ===> make SUCCEEDED
  Step 3 ===> make check FAILED
  Step 4 ===> make extracheck SUCCEEDED
  Step 5 ===> make base-mod-check FAILED
  Step 6 ===> make full-mod-check FAILED

But tail cbcstep* seems better for showing what's wrong in each case:
  $ tail cbcstep*
  ==> cbcstep1.log <==
  config.status: creating po/Makefile.in
  config.status: creating gllib/Makefile
  config.status: creating makemake
  config.status: creating config.h
  config.status: executing depfiles commands
  config.status: executing libtool commands
  config.status: executing po-directories commands
  config.status: creating po/POTFILES
  config.status: creating po/Makefile
  ===> /bin/sh ../src/configure --disable-option-checking --disable-maintainer-mode --cache-file=config.cache SUCCEEDED

  ==> cbcstep2.log <==
  1815980 ;
  167664 ;
  2 ;
  356064 ;
  31679
  grep "^REPLACE_.*='1'" `find . -name config.log` || true
  ./config.log:REPLACE_IOCTL='1'
  ./config.log:REPLACE_MBRTOWC='1'
  ./config.log:REPLACE_STRERROR_R='1'
  ===> make SUCCEEDED

  ==> cbcstep3.log <==
  Test failed:
  -rw-r--r--. 1 don don 188 Jan 24 14:33 streams.erg
  To see which tests failed, type
      cat /home/don/hg/clisp/build-dir/tests/*.erg

I suppose I could just do that cat unconditionally at the end.


  Makefile:34: recipe for target 'compare' failed
  make[1]: *** [compare] Error 1
  make[1]: Leaving directory '/home/don/hg/clisp/build-dir/tests'
  Makefile:2218: recipe for target 'check-tests' failed
  make: *** [check-tests] Error 2
  ===> make check FAILED

It's interesting that this doesn't show the same error I got before
from make check.  I wonder why not.

  ==> cbcstep4.log <==
  if ./image; then exit 1; fi
  STACK size: 98238 [0x180000bfe00 0x18000000010]
  *** - myerror
  ls -l lisp.run lispinit.mem image image.mem
  -rwxrwxr-x. 1 don don 9890592 Jan 24 14:33 image
  -rw-r--r--. 1 don don 3353376 Jan 24 14:33 image.mem
  -rw-r--r--. 1 don don 3357376 Jan 24 14:32 lispinit.mem
  -rwxrwxr-x. 1 don don 6532472 Jan 24 14:31 lisp.run
  rm -f image image.mem
  ===> make extracheck SUCCEEDED

Ah, that was what I wanted to know.  Thanks.

  ==> cbcstep5.log <==
  RUN-TEST: finished #P"/home/don/hg/clisp/modules/readline/test.tst" (0 errors out of 37 tests)
  finished   4 files:               3 errors out of     632 tests
    1             i18n/test.tst:    0 errors out of      11 tests
    2         syscalls/test.tst:    3 errors out of     264 tests
    3           regexp/test.tst:    0 errors out of     320 tests
    4         readline/test.tst:    0 errors out of      37 tests
  Bye.
  Makefile:2403: recipe for target 'base-mod-check' failed
  make: *** [base-mod-check] Error 1
  ===> make base-mod-check FAILED

So now I'd really like to cat syscalls/test.erg


  ==> cbcstep6.log <==
  NIL
  EQL-OK: T
  *** - READ from
        #<INPUT BUFFERED FILE-STREAM CHARACTER #P"/home/don/hg/clisp/modules/rawsock/test.tst" @24>
        : #<PACKAGE RAWSOCK> has no external symbol with name "CONVERT-ADDRESS"

  Bye.
  Makefile:2407: recipe for target 'full-mod-check' failed
  make: *** [full-mod-check] Error 1
  ===> make full-mod-check FAILED

I guess I've never done the full-mod-check.  Sam only asked for mod-check.

Re: nightly build make check etc

[Sam S. <sd...@gn...>]

> * Don Cohen <qba...@vf...3-vap.pbz> [2018-01-24 16:22:15 +0000]:
>
> 3. tail of output of make mod-check:
>    2         syscalls/test.tst:    3 errors out of     264 tests
>
> Form: (LET ((DIR "syscalls-tests-dir/") (DEST "qwer/adsf") COPY) (WHEN (NTH-VALUE 1 (ENSURE-DIRECTORIES-EXIST DIR :VERBOSE T)) (MAPC #'DELETE-FILE (DIRECTORY (CONCATENATE 'STRING DIR "**") :IF-DOES-NOT-EXIST :KEEP))) (SETQ COPY (COPY-FILE DEST DIR :METHOD :SYMLINK)) (LIST (STRING= DEST (CAAR COPY)) (STRING= (PATHNAME-NAME DEST) (PATHNAME-NAME (DELETE-FILE (CADAR COPY)))) (DELETE-DIRECTORY DIR) (PROBE-PATHNAME DIR)))
> CORRECT: (T T T NIL)
> CLISP  : ERROR
> OS-FILE-ERROR(ENOENT): No such file or directory
> OUT:
> "Creating directory: /home/don/hg/clisp/build-dir/syscalls-tests-dir/
> [OS-FILE-ERROR]: OS-FILE-ERROR(ENOENT): No such file or directory
> "

I fixed this.
Fascinating bug.
It turned out that

./clisp -C -E UTF-8 -Emisc 1:1 -q -norc -i tests/tests -x \
 '(run-some-tests :dirlist (list "syscalls/") :srcdir "../modules/" :outdir "./")'

failed while

./clisp -E 1:1 -q -norc -i tests/tests -x \
 '(run-test "../modules/syscalls/test" :logname "syscalls/test")'

worked, because RUN-SOME-TESTS bound *MERGE-PATHNAMES-ANSI* to T.

Thanks.

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1561
http://steingoldpsychology.com http://www.childpsy.net https://ffii.org
http://islamexposedonline.com http://thereligionofpeace.com
If you need to keep a secret, keep it a secret that you have a secret to keep.