Menu
▾
▴
clisp-devel
|
From: Anton V. <avo...@ya...> - 2011-04-10 01:16:49
|
Hello. I just installed CLISP 2.49 on Windows. During installation I left the checkbox "Path variable" as is - checked. After the installation the old value of the PATH variable had become replaced by the CLISP installation directory: C:\Program Files (x86)\clisp-2.49. I would expect the CLISP path to be added to the PATH instead of replacing it. It's Windows 7, 64 bit. Best regards, - Anton |
|
From: Sam S. <sd...@gn...> - 2011-04-10 16:36:35
|
Hi, > * Anton Vodonosov <nib...@ln...> [2011-04-10 05:16:40 +0400]: > > I just installed CLISP 2.49 on Windows. During installation I left the > checkbox "Path variable" as is - checked. > > After the installation the old value of the PATH variable had become > replaced by the CLISP installation directory: C:\Program Files (x86)\clisp-2.49. > > I would expect the CLISP path to be added to the PATH instead of replacing it. > > It's Windows 7, 64 bit. Elliott, could you please take a look at clisp/win32msvc/nsis/add_to_path.nsh? -- Sam Steingold (http://sds.podval.org/) on Ubuntu 10.04 (lucid) X http://iris.org.il http://honestreporting.com http://pmw.org.il http://palestinefacts.org http://truepeace.org http://jihadwatch.org Those who can't write, write manuals. |
|
From: Elliott S. <ell...@gm...> - 2011-04-10 19:33:36
|
On Sun, Apr 10, 2011 at 9:36 AM, Sam Steingold <sd...@gn...> wrote: > > * Anton Vodonosov <nib...@ln...> [2011-04-10 05:16:40 +0400]: > > > > I just installed CLISP 2.49 on Windows. During installation I left the > > checkbox "Path variable" as is - checked. > > > > After the installation the old value of the PATH variable had become > > replaced by the CLISP installation directory: C:\Program Files > (x86)\clisp-2.49. > > > > I would expect the CLISP path to be added to the PATH instead of > replacing it. > > > > It's Windows 7, 64 bit. > Anton: Did you install this "for everyone" or "just for me"? Have you ever had any previous versions of CLISP installed via the installer on this machine? Elliott, could you please take a look at > clisp/win32msvc/nsis/add_to_path.nsh? > Sam: Thanks for letting me know, I'll take a look at it. I should also mention that I've noticed a bug where the start menu item doesn't get deleted properly when the install "just for me" option is checked. Again, this bug only appears on Windows 7. -- Elliott Slaughter "Don't worry about what anybody else is going to do. The best way to predict the future is to invent it." - Alan Kay |
|
From: Anton V. <avo...@ya...> - 2011-04-10 19:54:29
|
10.04.2011, 23:33, "Elliott Slaughter" <ell...@gm...>: > > Anton: Did you install this "for everyone" or "just for me"? Have you ever had any previous versions of CLISP installed via the installer on this machine? > >> Elliott, could you please take a look at clisp/win32msvc/nsis/add_to_path.nsh? "for everyone". Previously I had installed CLISP 2.48, which I uninstalled manually from control panel before installing the new installer. I can not say what mode (everyone/just for me) was use in the old, 2.48, installation. Best regards, - Anton |
|
From: Elliott S. <ell...@gm...> - 2011-04-11 04:37:37
|
2011/4/10 Anton Vodonosov <avo...@ya...>
>
> 10.04.2011, 23:33, "Elliott Slaughter" <ell...@gm...>:
> >
> > Anton: Did you install this "for everyone" or "just for me"? Have you
> ever had any previous versions of CLISP installed via the installer on this
> machine?
> >
> >> Elliott, could you please take a look at
> clisp/win32msvc/nsis/add_to_path.nsh?
>
> "for everyone". Previously I had installed CLISP 2.48, which I uninstalled
> manually from control panel before installing the new installer.
>
> I can not say what mode (everyone/just for me) was use in the old, 2.48,
> installation.
>
I can't seem to reproduce the bug you observed. I also had CLISP 2.48
installed ("just for me") before starting, uninstalled it, and then
installed CLISP 2.49 ("for everyone"). At every step my user and system
PATHs were still intact, and CLISP path got added and removed as expected. I
am also using Windows 7 64-bit, so no difference there.
I'm not exactly sure what to do from here if I can't reproduce the bug...
In the meantime I do have a patch for the other issue I found (regarding the
start menu), but I'll start another thread for that.
--
Elliott Slaughter
"Don't worry about what anybody else is going to do. The best way to predict
the future is to invent it." - Alan Kay
|
|
From: Elliott S. <ell...@gm...> - 2011-04-16 07:06:45
|
On Sun, Apr 10, 2011 at 9:37 PM, Elliott Slaughter <
ell...@gm...> wrote:
> 2011/4/10 Anton Vodonosov <avo...@ya...>
>
>>
>> 10.04.2011, 23:33, "Elliott Slaughter" <ell...@gm...>:
>> >
>> > Anton: Did you install this "for everyone" or "just for me"? Have you
>> ever had any previous versions of CLISP installed via the installer on this
>> machine?
>> >
>> >> Elliott, could you please take a look at
>> clisp/win32msvc/nsis/add_to_path.nsh?
>>
>> "for everyone". Previously I had installed CLISP 2.48, which I uninstalled
>> manually from control panel before installing the new installer.
>>
>> I can not say what mode (everyone/just for me) was use in the old, 2.48,
>> installation.
>>
>
> I can't seem to reproduce the bug you observed. I also had CLISP 2.48
> installed ("just for me") before starting, uninstalled it, and then
> installed CLISP 2.49 ("for everyone"). At every step my user and system
> PATHs were still intact, and CLISP path got added and removed as expected. I
> am also using Windows 7 64-bit, so no difference there.
>
> I'm not exactly sure what to do from here if I can't reproduce the bug...
>
Anton,
Could you please try the following test installers? Since I am unable to
reproduce the bug, I can't meaningfully test this on my own.
Installer (1) below is intended to fix the bug. Installer (2) is a sanity
check to make sure the bug is still present when the fix is absent.
(1) http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix.exe
(2) http://elliottslaughter.net/files/clisp-2.49+-win32-install-orig.exe
*Please* back up your PATH (user and system) variables before trying either
of the above.
Note that the actually CLISP that gets installed is quite broken--there is a
dll missing, among other things.
Thanks.
--
Elliott Slaughter
"Don't worry about what anybody else is going to do. The best way to predict
the future is to invent it." - Alan Kay
|
|
From: Anton V. <avo...@ya...> - 2011-04-20 23:53:12
|
16.04.2011, 11:06, "Elliott Slaughter" <ell...@gm...>: > > Anton, > > Could you please try the following test installers? Since I am unable to reproduce the bug, I can't meaningfully test this on my own. > > Installer (1) below is intended to fix the bug. Installer (2) is a sanity check to make sure the bug is still present when the fix is absent. > > (1) http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix.exe > > (2) http://elliottslaughter.net/files/clisp-2.49+-win32-install-orig.exe > > *Please* back up your PATH (user and system) variables before trying either of the above. > > Note that the actually CLISP that gets installed is quite broken--there is a dll missing, among other things. > > Thanks. > > -- > Elliott Slaughter > > "Don't worry about what anybody else is going to do. The best way to predict the future is to invent it." - Alan Kay Hello Elliott, Both installers replace my PATH. I did some investigations and found the reason. I have very long value of the PATH variable. If the PATH lenght >= 1024 characters, it is replaced by the installer. Best regards, - Anton |
|
From: Elliott S. <ell...@gm...> - 2011-04-20 23:59:05
|
On Wed, Apr 20, 2011 at 4:53 PM, Anton Vodonosov <avo...@ya...>wrote: > > > 16.04.2011, 11:06, "Elliott Slaughter" <ell...@gm...>: > > > > Anton, > > > > Could you please try the following test installers? Since I am unable to > reproduce the bug, I can't meaningfully test this on my own. > > > > Installer (1) below is intended to fix the bug. Installer (2) is a sanity > check to make sure the bug is still present when the fix is absent. > > > > (1) http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix.exe > > > > (2) http://elliottslaughter.net/files/clisp-2.49+-win32-install-orig.exe > > > > *Please* back up your PATH (user and system) variables before trying > either of the above. > > > > Note that the actually CLISP that gets installed is quite broken--there > is a dll missing, among other things. > > > > Thanks. > > > > -- > > Elliott Slaughter > > > > "Don't worry about what anybody else is going to do. The best way to > predict the future is to invent it." - Alan Kay > > Hello Elliott, > > Both installers replace my PATH. > > I did some investigations and found the reason. I have very long value of > the PATH variable. > > If the PATH lenght >= 1024 characters, it is replaced by the installer. > Thank you for looking into this. I'll try to confirm your results and see if I can find a fix. -- Elliott Slaughter "Don't worry about what anybody else is going to do. The best way to predict the future is to invent it." - Alan Kay |
|
From: Elliott S. <ell...@gm...> - 2011-04-21 07:20:36
|
On Wed, Apr 20, 2011 at 4:58 PM, Elliott Slaughter < ell...@gm...> wrote: > On Wed, Apr 20, 2011 at 4:53 PM, Anton Vodonosov <avo...@ya...>wrote: > >> >> >> 16.04.2011, 11:06, "Elliott Slaughter" <ell...@gm...>: >> > >> > Anton, >> > >> > Could you please try the following test installers? Since I am unable to >> reproduce the bug, I can't meaningfully test this on my own. >> > >> > Installer (1) below is intended to fix the bug. Installer (2) is a >> sanity check to make sure the bug is still present when the fix is absent. >> > >> > (1) http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix.exe >> > >> > (2) >> http://elliottslaughter.net/files/clisp-2.49+-win32-install-orig.exe >> > >> > *Please* back up your PATH (user and system) variables before trying >> either of the above. >> > >> > Note that the actually CLISP that gets installed is quite broken--there >> is a dll missing, among other things. >> > >> > Thanks. >> > >> > -- >> > Elliott Slaughter >> > >> > "Don't worry about what anybody else is going to do. The best way to >> predict the future is to invent it." - Alan Kay >> >> Hello Elliott, >> >> Both installers replace my PATH. >> >> I did some investigations and found the reason. I have very long value of >> the PATH variable. >> >> If the PATH lenght >= 1024 characters, it is replaced by the installer. >> > > Thank you for looking into this. > > I'll try to confirm your results and see if I can find a fix. > Unfortunately, it looks like the 1024 character limit is built into NSIS. http://nsis.sourceforge.net/Talk:Environmental_Variables:_append,_prepend,_and_remove_entries The prescribed solution to get around this is apparently to rebuild NSIS from source, or use special binaries built. The binaries below set the limit to 8192 characters. http://nsis.sourceforge.net/Special_Builds I don't like this situation at all; among other things it means that the packager/maintainer needs to know about and use special builds of NSIS. Also, the script (at least the way it is written right now) has no way of making sure the builder is using the large string build of NSIS, and an unsuspecting CLISP packager might accidentally use the normal NSIS build without knowing. On top of that, the situation could theoretically reappear (with 8192 length strings instead of 1024), although it might be highly unlikely. I'm hoping to at least find a way to check dynamically if the string is too long and avoid smashing PATH. I don't know if there will be any better solution until a new version of NSIS comes out. -- Elliott Slaughter "Don't worry about what anybody else is going to do. The best way to predict the future is to invent it." - Alan Kay |
|
From: Anton V. <avo...@ya...> - 2011-04-21 08:11:26
|
21.04.2011, 11:20, "Elliott Slaughter" <ell...@gm...>: > I'm hoping to at least find a way to check dynamically if the string is too long and avoid smashing PATH. I don't know if there will be any better solution until a new version of NSIS comes out. An idea: try to set some temporary env variable, and then read it's value. It the variable wasn't smashed, then PATH will not be smashed too. |
|
From: Elliott S. <ell...@gm...> - 2011-04-25 03:49:55
|
On Thu, Apr 21, 2011 at 1:11 AM, Anton Vodonosov <avo...@ya...>wrote: > > > 21.04.2011, 11:20, "Elliott Slaughter" <ell...@gm...>: > > > I'm hoping to at least find a way to check dynamically if the string is > too long and avoid smashing PATH. I don't know if there will be any better > solution until a new version of NSIS comes out. > > An idea: try to set some temporary env variable, and then read it's value. > It the variable wasn't smashed, then PATH will not be smashed too. > Anton, could you try this fix? http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix2.exe The installer script is identical to the last attempted fix, but I used the 8192-length-strings version of NSIS. I decided not to add a dynamic check since past 8192 the Windows command line breaks anyway. I did add a compile-time check so that we can be sure the maintainer is using this special version of NSIS. The fix tested out fine on my machine, but I'll wait for independent confirmation before pushing the fix. -- Elliott Slaughter "Don't worry about what anybody else is going to do. The best way to predict the future is to invent it." - Alan Kay |
|
From: Anton V. <avo...@ya...> - 2011-04-25 09:44:27
|
25.04.2011, 07:49, "Elliott Slaughter" <ell...@gm...>: > > Anton, could you try this fix? > http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix2.exe Works for me. Thanks. Best regards, - Anton |
|
From: Elliott S. <ell...@gm...> - 2011-04-26 17:55:45
|
On Mon, Apr 25, 2011 at 2:44 AM, Anton Vodonosov <avo...@ya...>wrote: > > > 25.04.2011, 07:49, "Elliott Slaughter" <ell...@gm...>: > > > > Anton, could you try this fix? > > http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix2.exe > > Works for me. Thanks. > Ok, should be fixed in Mercurial now. -- Elliott Slaughter "Don't worry about what anybody else is going to do. The best way to predict the future is to invent it." - Alan Kay |
|
From: Sam S. <sd...@gn...> - 2011-04-27 15:51:31
|
> * Elliott Slaughter <ryy...@tz...> [2011-04-26 10:55:34 -0700]: > On Mon, Apr 25, 2011 at 2:44 AM, Anton Vodonosov <avo...@ya...>wrote: >> >> 25.04.2011, 07:49, "Elliott Slaughter" <ell...@gm...>: >> > >> > Anton, could you try this fix? >> > http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix2.exe >> >> Works for me. Thanks. > > Ok, should be fixed in Mercurial now. Thanks. However, you forgot to add the ChangeLog entry. You need to massage it into your patch (rather than make a separate commit). Specifically, you need to - roll back your change in your repo - apply the patch - add the ChangeLog entry - commit - push this will work because I am about to roll back your change in the SF repo. -- Sam Steingold (http://sds.podval.org/) on CentOS release 5.6 (Final) X 11.0.60900031 http://iris.org.il http://camera.org http://truepeace.org http://www.memritv.org http://openvotingconsortium.org http://memri.org Let us remember that ours is a nation of lawyers and order. |
|
From: Elliott S. <ell...@gm...> - 2011-04-28 00:44:50
|
On Wed, Apr 27, 2011 at 8:51 AM, Sam Steingold <sd...@gn...> wrote: > > * Elliott Slaughter <ryy...@tz...> [2011-04-26 10:55:34 > -0700]: > > On Mon, Apr 25, 2011 at 2:44 AM, Anton Vodonosov <avo...@ya... > >wrote: > >> > >> 25.04.2011, 07:49, "Elliott Slaughter" <ell...@gm...>: > >> > > >> > Anton, could you try this fix? > >> > http://elliottslaughter.net/files/clisp-2.49+-win32-install-fix2.exe > >> > >> Works for me. Thanks. > > > > Ok, should be fixed in Mercurial now. > > Thanks. However, you forgot to add the ChangeLog entry. > You need to massage it into your patch (rather than make a separate > commit). > Specifically, you need to > - roll back your change in your repo > - apply the patch > - add the ChangeLog entry > - commit > - push > this will work because I am about to roll back your change in the SF repo. > Ok, done. Let me know if there is anything else that needs fixing. -- Elliott Slaughter "Don't worry about what anybody else is going to do. The best way to predict the future is to invent it." - Alan Kay |
|
From: Sam S. <sd...@gn...> - 2011-04-28 16:45:51
|
> * Elliott Slaughter <ryy...@tz...> [2011-04-27 17:44:43 -0700]: > On Wed, Apr 27, 2011 at 8:51 AM, Sam Steingold <sd...@gn...> wrote: >> Thanks. However, you forgot to add the ChangeLog entry. > Ok, done. Let me know if there is anything else that needs fixing. thanks, looks good. -- Sam Steingold (http://sds.podval.org/) on CentOS release 5.6 (Final) X 11.0.60900031 http://ffii.org http://palestinefacts.org http://honestreporting.com http://camera.org http://www.memritv.org http://mideasttruth.com I'd give my right arm to be ambidextrous. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X