From: Hoehle, Joerg-C. <Joe...@t-...> - 2005-06-15 12:51:57
|
Hi, I read some of impnotes and fixed a few missing specifications (I only read a small part of it). While doing so, I noticed problems with hashtabl.d: 1. Line 72ff and line 1369 differ in what they document. I believe the former to be obsolete and the latter up to date. 2. in make_hash_table, coerce_function(...); pushSTACK(test); looks like a GC-SAFETY bug to me. 3. I think the hash-table section of impnotes needs more updates than what I did. - :value-type and:key-type are not documented - maybe other things changed since fasthash, I felt unsure about that. Regards, Jorg Hohle. |
From: Bruno H. <br...@cl...> - 2005-06-15 16:18:30
|
J=C3=B6rg wrote: > I read some of impnotes and fixed a few missing specifications (I only re= ad > a small part of it). Thanks! > 1. Line 72ff and line 1369 differ in what they document. I believe the > former to be obsolete and the latter up to date. Right. I fixed the earlier comments now. > 2. in make_hash_table, coerce_function(...); pushSTACK(test); looks like a > GC-SAFETY bug to me. No, it's perfectly correct code. While the contents of the variable 'test' is in this variable and not yet on the STACK, no 'maygc' function is called. > 3. I think the hash-table section of impnotes needs more updates than what > I did. - :value-type and:key-type are not documented > - maybe other things changed since fasthash, I felt unsure about that. :value and :key are documented in impext.xml. We have split the description of MAKE-HASH-TABLE into a more general part in impbody.xml and a weak hash table description in impext.xml. Bruno |