Re: [Clirr-user] Feedback

[<lak...@t-...>]

Wow, thanks for such a detailled analysis. I have added most of your 
points to the feature request tracker. Please add further suggestions 
there so I can keep track of things.

I'm not sure what you mean in #4, though. Here is some sample code that 
uses only official API from commons-collections 2.1:

Iterator i1 = myCollection.iterator();
ProxyIterator pi = new TransformIterator(i1);
Iterator i2 = pi.getIterator();

I haven't tried it, but I think adding getIterator() to 
TransformIterator doesn't help here because the class verifier will 
already reject the second assignment. So can subclasses really cope with 
the removal of a superclass if the removed class is public?

Again, thanks for your feedback - I'm already working on some of your 
other suggestions.
Lars


Stephen Colebourne wrote:

>Problems so far:
>
>1) Getting the ant task running was relatively easy, however you could do
>with adding more documentation about formatters on the website.
>
>2) When the origFiles and newFiles FileSets point to no jar files there is
>no error/warning message. It appeared that jars were compatible, when in
>fact I had mis-specified the jar files.
>
>3) When an exception adds a superclass it can be programmatically
>incompatible causing a different catch block to be selected, eg. INFO: Added
>java.util.NoSuchElementException to the list of superclasses of
>org.apache.commons.collections.BufferUnderflowException
>
>4) When a superclass is removed, methods can get added to the subclasses to
>cope. It would be nice if the message about adding a method referred to the
>method as having moved from the old superclass.
>ERROR: Removed org.apache.commons.collections.iterators.ProxyIterator from
>the list of superclasses of
>org.apache.commons.collections.iterators.TransformIterator
>INFO: Method 'public java.util.Iterator getIterator()' has been added in
>org.apache.commons.collections.iterators.TransformIterator
>
>5) Field return types
>
>In general though, this tool is looking very good :-)))
>
>Stephen
>  
>