clirr-devel — Discussion about the source code of Clirr

[Clirr-devel] CVS: clirr/core/xdocs exegesis.xml, 1.7, 1.8 changes.xml, 1.18, 1.19

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/xdocs
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv13483/xdocs

Modified Files:
	exegesis.xml changes.xml 
Log Message:
RFE #1719563: added check to report class format version changes

Index: exegesis.xml
===================================================================
RCS file: /cvsroot/clirr/clirr/core/xdocs/exegesis.xml,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- exegesis.xml	3 Aug 2005 17:01:42 -0000	1.7
+++ exegesis.xml	17 Jun 2007 19:51:54 -0000	1.8
@@ -736,6 +736,24 @@
         </p>
       </section>
 
+      <section name="10000 - Class Format Version Increased">
+        <p>Severity: <code>ERROR</code></p>
+        <p>
+          The new class is compiled with a higher "-target" compiler setting.
+          This means that library users must upgrade their Java compiler and/or
+          JVM in order to be able to use the new library version.
+        </p>
+      </section>
+
+      <section name="10001 - Class Format Version Decreased">
+        <p>Severity: <code>INFO</code></p>
+        <p>
+          The new class is compiled with a lower "-target" compiler setting.
+          Newer Java compilers and JVMs versions support all previous class
+          file formats, so this is a binary and source compatible change.
+        </p>
+      </section>
+
     </section>
   </body>
 </document>

Index: changes.xml
===================================================================
RCS file: /cvsroot/clirr/clirr/core/xdocs/changes.xml,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- changes.xml	19 May 2007 12:18:38 -0000	1.18
+++ changes.xml	17 Jun 2007 19:51:54 -0000	1.19
@@ -10,6 +10,10 @@
     <release version="0.7-dev" date="in CVS">
         <action dev="lkuehne" type="add">
             <!-- RFE #1719563-->
+            Added check to report class format version changes.
+        </action>
+        <action dev="lkuehne" type="add">
+            <!-- RFE #1719563-->
             Made class format version accessible via java code structure SPI
             (incompatible API change).
         </action>

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/internal/checks ClassFormatVersionCheck.java, NONE, 1.1

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/checks
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv13483/src/java/net/sf/clirr/core/internal/checks

Added Files:
	ClassFormatVersionCheck.java 
Log Message:
RFE #1719563: added check to report class format version changes

--- NEW FILE ---
package net.sf.clirr.core.internal.checks;

import net.sf.clirr.core.CheckerException;
import net.sf.clirr.core.Message;
import net.sf.clirr.core.Severity;
import net.sf.clirr.core.internal.AbstractDiffReporter;
import net.sf.clirr.core.internal.ApiDiffDispatcher;
import net.sf.clirr.core.internal.ClassChangeCheck;
import net.sf.clirr.core.spi.JavaType;

public class ClassFormatVersionCheck extends AbstractDiffReporter implements ClassChangeCheck
{
    private static final Message MSG_CLASS_FORMAT_VERSION_INCREASED = new Message(10000);

    private static final Message MSG_CLASS_FORMAT_VERSION_DECREASED = new Message(10001);

    public ClassFormatVersionCheck(ApiDiffDispatcher dispatcher)
    {
        super(dispatcher);
    }

    public boolean check(JavaType compatBaseline, JavaType currentVersion) throws CheckerException
    {
        final int oldClassFormatVersion = compatBaseline.getClassFormatVersion();
        final int newClassFormatVersion = currentVersion.getClassFormatVersion();
        final String className = compatBaseline.getName();

        final String[] args = new String[]{
                String.valueOf(oldClassFormatVersion), String.valueOf(newClassFormatVersion)};
        if (oldClassFormatVersion < newClassFormatVersion)
        {
            // don't use severity getSeverity(compatBaseline, Severity.ERROR) here,
            // as even classes that are not visible to the client code will trigger a
            // requirement for a higher JVM version.  
            log(MSG_CLASS_FORMAT_VERSION_INCREASED, Severity.ERROR, className, null, null, args);
        }
        else if (newClassFormatVersion < oldClassFormatVersion)
        {
            log(MSG_CLASS_FORMAT_VERSION_DECREASED, Severity.INFO, className, null, null, args);
        }
        return true;
    }
}

[Clirr-devel] [ clirr-Feature Requests-1722291 ] migrate build to maven 2

[SourceForge.net <no...@so...>]

Feature Requests item #1722291, was opened at 2007-05-20 21:54
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1722291&group_id=89627

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Lars Kühne (lkuehne)
Assigned to: Nobody/Anonymous (nobody)
Summary: migrate build to maven 2

Initial Comment:
this should lead to better multi-module support, better IDE integration, etc.

main issues:
* How do we call javac for generating the test resources? Do we need more modules, one for each version of the test library?
* How do we create the final distribution files? Maybe look at the dist module of Apache Yoko...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1722291&group_id=89627

[Clirr-devel] CVS: clirr/core/xdocs changes.xml,1.17,1.18

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/xdocs
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv18396/xdocs

Modified Files:
	changes.xml 
Log Message:
RFE 1719563: made class format version accessible via JavaType interface

Index: changes.xml
===================================================================
RCS file: /cvsroot/clirr/clirr/core/xdocs/changes.xml,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- changes.xml	15 Apr 2007 05:10:42 -0000	1.17
+++ changes.xml	19 May 2007 12:18:38 -0000	1.18
@@ -8,6 +8,16 @@
   <body>
 
     <release version="0.7-dev" date="in CVS">
+        <action dev="lkuehne" type="add">
+            <!-- RFE #1719563-->
+            Made class format version accessible via java code structure SPI
+            (incompatible API change).
+        </action>
+        <action dev="lkuehne" type="fix">
+            <!-- Bug #1022446-->
+            Fixed Bug "Unable to locate enclosing class" when there are multiple
+            levels of nested inner classes.
+        </action>
         <action dev="lkuehne" type="fix">
             <!-- Bug #1700298-->
             CLI: Classpath parsing was broken with multiple classpath entries.

[Clirr-devel] CVS: clirr/core/src/test/net/sf/clirr/core/internal/checks Regression1373831Test.java, 1.3, 1.4 Regression1022446Test.java, 1.1, 1.2 AbstractCheckerTestCase.java, 1.2, 1.3

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv18230/src/test/net/sf/clirr/core/internal/checks

Modified Files:
	Regression1373831Test.java Regression1022446Test.java 
	AbstractCheckerTestCase.java 
Log Message:
CheckerException is no longer a runtime exception, fixes TODO comment in CheckerException source code

Index: Regression1373831Test.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/Regression1373831Test.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- Regression1373831Test.java	4 May 2007 18:58:36 -0000	1.3
+++ Regression1373831Test.java	19 May 2007 12:18:06 -0000	1.4
@@ -1,5 +1,6 @@
 package net.sf.clirr.core.internal.checks;
 
+import net.sf.clirr.core.CheckerException;
 import net.sf.clirr.core.Severity;
 
 /**
@@ -10,7 +11,7 @@
  */
 public class Regression1373831Test extends AbstractRegressionTestCase
 {
-    public void testRegression()
+    public void testRegression() throws CheckerException
     {
         runChecker();
         final TestDiffListener testDiffListener = getTestDiffListener();

Index: Regression1022446Test.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/Regression1022446Test.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- Regression1022446Test.java	4 May 2007 18:58:36 -0000	1.1
+++ Regression1022446Test.java	19 May 2007 12:18:06 -0000	1.2
@@ -1,5 +1,6 @@
 package net.sf.clirr.core.internal.checks;
 
+import net.sf.clirr.core.CheckerException;
 import net.sf.clirr.core.Severity;
 
 /**
@@ -10,7 +11,7 @@
  */
 public class Regression1022446Test extends AbstractRegressionTestCase
 {
-    public void testRegression()
+    public void testRegression() throws CheckerException
     {
         runChecker();
         final TestDiffListener testDiffListener = getTestDiffListener();

Index: AbstractCheckerTestCase.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/AbstractCheckerTestCase.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- AbstractCheckerTestCase.java	16 Mar 2006 22:30:18 -0000	1.2
+++ AbstractCheckerTestCase.java	19 May 2007 12:18:06 -0000	1.3
@@ -5,6 +5,7 @@
 import java.net.URLClassLoader;
 
 import net.sf.clirr.core.Checker;
+import net.sf.clirr.core.CheckerException;
 import net.sf.clirr.core.ClassFilter;
 import net.sf.clirr.core.internal.asm.AsmTypeArrayBuilder;
 import net.sf.clirr.core.spi.JavaType;
@@ -65,14 +66,14 @@
     {
         runChecker();
 
-        // tdl.checkExpected(expected);
+        tdl.checkExpected(expected);
     }
 
     /**
      * Creates a Checker, wires it with a test listener, executes the
      * checker.
      */
-    protected void runChecker() {
+    protected void runChecker() throws CheckerException {
         Checker checker = createChecker();
         ClassFilter classSelector = createClassFilter();
 

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core CheckerException.java, 1.4, 1.5

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv18230/src/java/net/sf/clirr/core

Modified Files:
	CheckerException.java 
Log Message:
CheckerException is no longer a runtime exception, fixes TODO comment in CheckerException source code

Index: CheckerException.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/CheckerException.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- CheckerException.java	26 Aug 2005 05:35:53 -0000	1.4
+++ CheckerException.java	19 May 2007 12:18:06 -0000	1.5
@@ -30,7 +30,7 @@
  * Unchecked exceptions are used for errors that are due to bugs within
  * clirr code (assertion-violation type problems).
  */
-public class CheckerException extends RuntimeException // TODO: revert this back to Exception to match the class doc above
+public class CheckerException extends Exception
 {
     public CheckerException(String msg)
     {

[Clirr-devel] CVS: clirr/core/src/test/net/sf/clirr/core/internal/checks TestDiffListener.java, 1.6, 1.7

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv17923/src/test/net/sf/clirr/core/internal/checks

Modified Files:
	TestDiffListener.java 
Log Message:
better message on test failures

Index: TestDiffListener.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/TestDiffListener.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- TestDiffListener.java	9 Jan 2006 21:38:38 -0000	1.6
+++ TestDiffListener.java	19 May 2007 12:17:13 -0000	1.7
@@ -44,7 +44,7 @@
                 MessageTranslator translator = new MessageTranslator();
                 
                 StringBuffer buf = new StringBuffer();
-                buf.append("Expected diff " + expected + " was not generated.\n");
+                buf.append("Expected diff " + i + " '" + expected + "' was not generated.\n");
                 if (diffs.size() == 0)
                 {
                     buf.append("No diffs were generated.");

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/internal/asm Repository.java, 1.4, 1.5 AsmJavaType.java, 1.4, 1.5 ArrayType.java, 1.2, 1.3 PrimitiveType.java, 1.2, 1.3

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv15781/src/java/net/sf/clirr/core/internal/asm

Modified Files:
	Repository.java AsmJavaType.java ArrayType.java 
	PrimitiveType.java 
Log Message:
RFE 1719563: made class format version accessible via JavaType interface

Index: Repository.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm/Repository.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Repository.java	22 Apr 2006 19:52:25 -0000	1.4
+++ Repository.java	19 May 2007 12:12:06 -0000	1.5
@@ -24,11 +24,13 @@
     private static final Pattern ARRAY_PATTERN = Pattern.compile("(\\[\\])+$");
 
     private final ClassLoader classLoader;
-    private Map nameTypeMap = new HashMap();
+    private final Map nameTypeMap = new HashMap();
+    private final int primitiveClassFormatVersion;
 
     public Repository(ClassLoader classLoader)
     {
         this.classLoader = classLoader;
+        primitiveClassFormatVersion = findTypeByName("java.lang.Integer").getClassFormatVersion();
     }
 
     /**
@@ -42,6 +44,7 @@
         
         ClassInfoCollector infoCollector = new ClassInfoCollector(this);
         
+        // TODO: Code for ASM 3.0: parser.accept(infoCollector, ClassReader.SKIP_CODE | ClassReader.SKIP_DEBUG);
         parser.accept(infoCollector, true);
         
         final AsmJavaType javaType = infoCollector.getJavaType();
@@ -79,7 +82,8 @@
         final Matcher primitiveMatcher = PRIMITIVE_PATTERN.matcher(typeName);
         if (primitiveMatcher.matches())
         {
-            JavaType primitive = new PrimitiveType(typeName);
+            
+            JavaType primitive = new PrimitiveType(primitiveClassFormatVersion, typeName);
             nameTypeMap.put(typeName, primitive);
             return wrapInArrayTypeIfRequired(dimension, primitive); 
         }

Index: AsmJavaType.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm/AsmJavaType.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- AsmJavaType.java	15 May 2007 19:43:54 -0000	1.4
+++ AsmJavaType.java	19 May 2007 12:12:06 -0000	1.5
@@ -166,6 +166,10 @@
         return containerScope.isLessVisibleThan(declaredScope) ? containerScope : declaredScope;
     }
 
+    public int getClassFormatVersion()
+    {
+        return classFormatVersion;
+    }
 
     public String toString()
     {

Index: ArrayType.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm/ArrayType.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ArrayType.java	22 Apr 2006 22:03:51 -0000	1.2
+++ ArrayType.java	19 May 2007 12:12:06 -0000	1.3
@@ -98,6 +98,11 @@
         return basicType.getEffectiveScope();
     }
 
+    public int getClassFormatVersion()
+    {
+        return basicType.getClassFormatVersion();
+    }
+
     public String toString()
     {
         

Index: PrimitiveType.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm/PrimitiveType.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- PrimitiveType.java	22 Apr 2006 22:03:51 -0000	1.2
+++ PrimitiveType.java	19 May 2007 12:12:06 -0000	1.3
@@ -8,12 +8,19 @@
 class PrimitiveType implements JavaType
 {
     private final String basicName;
+    private final int classFormatVersion;
 
-    PrimitiveType(String name)
+    PrimitiveType(int classFormatVersion, String name)
     {
+        this.classFormatVersion = classFormatVersion;
         this.basicName = name;
     }
     
+    public int getClassFormatVersion()
+    {
+        return classFormatVersion;
+    }
+    
     public String getBasicName()
     {
         return basicName;

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/spi JavaType.java, 1.4, 1.5

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/spi
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv15781/src/java/net/sf/clirr/core/spi

Modified Files:
	JavaType.java 
Log Message:
RFE 1719563: made class format version accessible via JavaType interface

Index: JavaType.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/spi/JavaType.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JavaType.java	22 Apr 2006 22:03:52 -0000	1.4
+++ JavaType.java	19 May 2007 12:12:05 -0000	1.5
@@ -8,6 +8,13 @@
 public interface JavaType extends Named, Scoped
 {
     /**
+     * The class format version of this class's bytecode.
+     * @return the class format version, like 49 for code that has been
+     * generated with the Java5 compiler. 
+     */
+    int getClassFormatVersion();
+    
+    /**
      * The type's fully qualified class name.
      * In case of array types, this is the name without the array brackets
      * 

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core ApiDifference.java, 1.6, 1.7

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv14162/src/java/net/sf/clirr/core

Modified Files:
	ApiDifference.java 
Log Message:
fixed unused field warning

Index: ApiDifference.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/ApiDifference.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- ApiDifference.java	3 Aug 2005 17:16:09 -0000	1.6
+++ ApiDifference.java	19 May 2007 12:08:01 -0000	1.7
@@ -27,8 +27,6 @@
  */
 public final class ApiDifference
 {
-    private static final int HASHCODE_MAGIC = 29;
-
     /**
      * Object representing the message text to be output (or null if
      * the constructor which takes a message string directly is used).

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/internal/asm AsmTypeArrayBuilder.java, 1.1, 1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv13358/src/java/net/sf/clirr/core/internal/asm

Modified Files:
	AsmTypeArrayBuilder.java 
Log Message:
fixed unused variable warning

Index: AsmTypeArrayBuilder.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm/AsmTypeArrayBuilder.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- AsmTypeArrayBuilder.java	16 Mar 2006 22:30:19 -0000	1.1
+++ AsmTypeArrayBuilder.java	19 May 2007 12:05:29 -0000	1.2
@@ -75,7 +75,6 @@
             Repository repository, ZipEntry zipEntry, ZipFile zip)
             throws CheckerException
     {
-        String name = zipEntry.getName();
         InputStream is = null;
         try
         {

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/internal/asm AsmJavaType.java, 1.3, 1.4 ClassInfoCollector.java, 1.2, 1.3

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv28736/src/java/net/sf/clirr/core/internal/asm

Modified Files:
	AsmJavaType.java ClassInfoCollector.java 
Log Message:
RFE 1719563: added version information to AsmJavaType (currently not accessible via JavaType interface)

Index: AsmJavaType.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm/AsmJavaType.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- AsmJavaType.java	22 Apr 2006 22:04:27 -0000	1.3
+++ AsmJavaType.java	15 May 2007 19:43:54 -0000	1.4
@@ -27,9 +27,12 @@
 
     private final String[] interfaceNames;
 
-    AsmJavaType(Repository repository, int access, String basicName, String superClassName, String[] interfaceNames)
+    private final int classFormatVersion;
+
+    AsmJavaType(int classFormatVersion, Repository repository, int access, String basicName, String superClassName, String[] interfaceNames)
     {
         super(access);
+        this.classFormatVersion = classFormatVersion;
         this.repository = repository;
         this.basicName = basicName;
         this.superClassName = superClassName;

Index: ClassInfoCollector.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/asm/ClassInfoCollector.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ClassInfoCollector.java	22 Apr 2006 22:04:27 -0000	1.2
+++ ClassInfoCollector.java	15 May 2007 19:43:54 -0000	1.3
@@ -27,7 +27,7 @@
         final String className = prettyprintClassName(name);
         final String superClassName = prettyprintClassName(superName);
         final String[] interfaceNames = prettyprintClassNames(interfaces);
-        javaType = new AsmJavaType(repository, access, className, superClassName, interfaceNames);
+        javaType = new AsmJavaType(version, repository, access, className, superClassName, interfaceNames);
     }
 
     public FieldVisitor visitField(int access, String name, String desc, String signature, Object value)

[Clirr-devel] [ clirr-Feature Requests-1719563 ] Detect class format version change

[SourceForge.net <no...@so...>]

Feature Requests item #1719563, was opened at 2007-05-15 21:40
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1719563&group_id=89627

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Lars Kühne (lkuehne)
Assigned to: Lars Kühne (lkuehne)
Summary: Detect class format version change

Initial Comment:
With ASM this is technically easy, as the class format version is reported in the first argument to ClassInfoCollector.visit(), e.g. 49 for code that was compiled with Java5.

Question is how to report such a change. Warning?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1719563&group_id=89627

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/spi Scoped.java, 1.1, 1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/spi
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv4380/src/java/net/sf/clirr/core/spi

Modified Files:
	Scoped.java 
Log Message:
fixed typo in javadoc

Index: Scoped.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/spi/Scoped.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- Scoped.java	26 Aug 2005 05:29:52 -0000	1.1
+++ Scoped.java	15 May 2007 18:46:26 -0000	1.2
@@ -23,7 +23,7 @@
      * The effective Scope of this entity.
      * 
      * @return the minimum scope of the modifiers of this entity and
-     * it's all of it's containers.
+     * all of it's containers.
      */
     Scope getEffectiveScope();
 }

[Clirr-devel] CVS: clirr/core/src/test/net/sf/clirr/core/internal/checks ClassHierarchyCheckTest.java, 1.2, 1.3 InterfaceSetCheckTest.java, 1.2, 1.3

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv1800/src/test/net/sf/clirr/core/internal/checks

Modified Files:
	ClassHierarchyCheckTest.java InterfaceSetCheckTest.java 
Log Message:
Fixed test failure by changing the base class of ChangingClassHierarchy in v1 test lib to MouseMotionAdapter. This should be more stable across JDK releases while the set of interfaces of the original base class MouseAdapter tends to change from one JDK to another (e.g. at some point MouseWheelListener was added).

Index: ClassHierarchyCheckTest.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/ClassHierarchyCheckTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ClassHierarchyCheckTest.java	9 Jan 2006 21:38:38 -0000	1.2
+++ ClassHierarchyCheckTest.java	15 May 2007 18:40:58 -0000	1.3
@@ -14,7 +14,7 @@
     {
         ExpectedDiff[] expected = new ExpectedDiff[] {
             new ExpectedDiff("Added java.util.NoSuchElementException to the list of superclasses", Severity.WARNING, "testlib.ApplicationException", null, null),
-            new ExpectedDiff("Removed java.awt.event.MouseAdapter from the list of superclasses", Severity.ERROR, "testlib.ChangingHierarchy", null, null),
+            new ExpectedDiff("Removed java.awt.event.MouseMotionAdapter from the list of superclasses", Severity.ERROR, "testlib.ChangingHierarchy", null, null),
             new ExpectedDiff("Added java.awt.event.WindowAdapter to the list of superclasses", Severity.INFO, "testlib.ChangingHierarchy", null, null),
         };
         verify(expected);

Index: InterfaceSetCheckTest.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/InterfaceSetCheckTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- InterfaceSetCheckTest.java	9 Jan 2006 21:38:38 -0000	1.2
+++ InterfaceSetCheckTest.java	15 May 2007 18:40:58 -0000	1.3
@@ -11,7 +11,7 @@
                 new ExpectedDiff("Added java.awt.event.WindowListener to the set of implemented interfaces", Severity.INFO, "testlib.ChangingHierarchy", null, null),
                 new ExpectedDiff("Added java.awt.event.WindowFocusListener to the set of implemented interfaces", Severity.INFO, "testlib.ChangingHierarchy", null, null),
                 new ExpectedDiff("Added java.awt.event.WindowStateListener to the set of implemented interfaces", Severity.INFO, "testlib.ChangingHierarchy", null, null),
-                new ExpectedDiff("Removed java.awt.event.MouseListener from the set of implemented interfaces", Severity.ERROR, "testlib.ChangingHierarchy", null, null),
+                new ExpectedDiff("Removed java.awt.event.MouseMotionListener from the set of implemented interfaces", Severity.ERROR, "testlib.ChangingHierarchy", null, null),
         };
         verify(expected);
     }

[Clirr-devel] CVS: clirr/core/src/testinput/testlib-v1/testlib ChangingHierarchy.java, 1.1, 1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/testinput/testlib-v1/testlib
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv1800/src/testinput/testlib-v1/testlib

Modified Files:
	ChangingHierarchy.java 
Log Message:
Fixed test failure by changing the base class of ChangingClassHierarchy in v1 test lib to MouseMotionAdapter. This should be more stable across JDK releases while the set of interfaces of the original base class MouseAdapter tends to change from one JDK to another (e.g. at some point MouseWheelListener was added).

Index: ChangingHierarchy.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/testinput/testlib-v1/testlib/ChangingHierarchy.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ChangingHierarchy.java	15 Jul 2004 17:06:30 -0000	1.1
+++ ChangingHierarchy.java	15 May 2007 18:40:58 -0000	1.2
@@ -1,5 +1,5 @@
 package testlib;
 
-public class ChangingHierarchy extends java.awt.event.MouseAdapter
+public class ChangingHierarchy extends java.awt.event.MouseMotionAdapter
 {
 }

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/spi TypeArrayBuilderSupport.java, 1.1, 1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/spi
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv15046/src/java/net/sf/clirr/core/spi

Modified Files:
	TypeArrayBuilderSupport.java 
Log Message:
fixed usage of deprecated method File#toURL()

Index: TypeArrayBuilderSupport.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/spi/TypeArrayBuilderSupport.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TypeArrayBuilderSupport.java	16 Mar 2006 22:30:19 -0000	1.1
+++ TypeArrayBuilderSupport.java	4 May 2007 19:14:35 -0000	1.2
@@ -18,7 +18,7 @@
             File jarFile = jarFiles[i];
             try
             {
-                URL url = jarFile.toURL();
+                URL url = jarFile.toURI().toURL();
                 jarUrls[i] = url;
             }
             catch (MalformedURLException ex)

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/internal ClassLoaderUtil.java, 1.1, 1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv15046/src/java/net/sf/clirr/core/internal

Modified Files:
	ClassLoaderUtil.java 
Log Message:
fixed usage of deprecated method File#toURL()

Index: ClassLoaderUtil.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/ClassLoaderUtil.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ClassLoaderUtil.java	8 Sep 2005 08:36:33 -0000	1.1
+++ ClassLoaderUtil.java	4 May 2007 19:14:35 -0000	1.2
@@ -30,7 +30,7 @@
             File entry = new File(cpEntry);
             try
             {
-                URL url = entry.toURL();
+                URL url = entry.toURI().toURL();
                 cpUrls[i] = url;
             }
             catch (MalformedURLException ex)

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/cli Clirr.java, 1.10, 1.11

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/cli
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv15046/src/java/net/sf/clirr/cli

Modified Files:
	Clirr.java 
Log Message:
fixed usage of deprecated method File#toURL()

Index: Clirr.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/cli/Clirr.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- Clirr.java	1 May 2007 19:38:16 -0000	1.10
+++ Clirr.java	4 May 2007 19:14:35 -0000	1.11
@@ -267,7 +267,7 @@
     {
         URL[] ret = new URL[files.length];
         for (int i = 0; i < files.length; i++) {
-            ret[i] = files[i].toURL();
+            ret[i] = files[i].toURI().toURL();
         }
         return ret;
     }

[Clirr-devel] CVS: clirr/core/src/testinput/testlib-v1/testlib/regressions/bug1022446 Java5Demo.java, NONE, 1.1

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/testinput/testlib-v1/testlib/regressions/bug1022446
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv8715/src/testinput/testlib-v1/testlib/regressions/bug1022446

Added Files:
	Java5Demo.java 
Log Message:
added regression test for bug #1022446

--- NEW FILE ---
package testlib.regressions.bug1022446;

import java.awt.*;
import java.util.concurrent.*;

/** 
 * A stripped down version of the generified SwingWorker to demonstrate the bug.
 */
public class Java5Demo<V>
{
    private final FutureTask<V> task = 
        new FutureTask<V>( 
                new Callable<V>() {
                    public V call() throws Exception {
                        return null;
                    }
                } 
        ) {
            protected void done() {
                EventQueue.invokeLater( new Runnable() {
                    public void run() {
                        // finished();
                    }
                } );
            }
        };
}

[Clirr-devel] CVS: clirr/core/src/testinput/testlib-v2/testlib/regressions/bug1022446 Java5Demo.java, NONE, 1.1

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/testinput/testlib-v2/testlib/regressions/bug1022446
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv8715/src/testinput/testlib-v2/testlib/regressions/bug1022446

Added Files:
	Java5Demo.java 
Log Message:
added regression test for bug #1022446

--- NEW FILE ---
package testlib.regressions.bug1022446;

import java.awt.*;
import java.util.concurrent.*;

/** 
 * A stripped down version of the generified SwingWorker to demonstrate the bug.
 * Unchanged from testlib v1. 
 */
public class Java5Demo<V>
{
    private final FutureTask<V> task = 
        new FutureTask<V>( 
                new Callable<V>() {
                    public V call() throws Exception {
                        return null;
                    }
                } 
        ) {
            protected void done() {
                EventQueue.invokeLater( new Runnable() {
                    public void run() {
                        // finished();
                    }
                } );
            }
        };
}

[Clirr-devel] CVS: clirr/core/src/test/net/sf/clirr/core/internal/checks Regression1022446Test.java, NONE, 1.1 Regression1373831Test.java, 1.2, 1.3 AbstractRegressionTestCase.java, 1.1, 1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv8715/src/test/net/sf/clirr/core/internal/checks

Modified Files:
	Regression1373831Test.java AbstractRegressionTestCase.java 
Added Files:
	Regression1022446Test.java 
Log Message:
added regression test for bug #1022446

--- NEW FILE ---
package net.sf.clirr.core.internal.checks;

import net.sf.clirr.core.Severity;

/**
 * Regression test for bug 
 * <a href="https://sourceforge.net/tracker/index.php?func=detail&aid=1022446&group_id=89627&atid=590799">1022446</a>.
 *  
 * @author lkuehne
 */
public class Regression1022446Test extends AbstractRegressionTestCase
{
    public void testRegression()
    {
        runChecker();
        final TestDiffListener testDiffListener = getTestDiffListener();
        assertEquals("false alarm (binary error)", 0, testDiffListener.countBinaryCompatibilityDiffs(Severity.ERROR));
        assertEquals("false alarm (source error)", 0, testDiffListener.countSourceCompatibilityDiffs(Severity.ERROR));
        assertEquals("false alarm (binary warning)", 0, testDiffListener.countBinaryCompatibilityDiffs(Severity.WARNING));
        assertEquals("false alarm (source warning)", 0, testDiffListener.countSourceCompatibilityDiffs(Severity.WARNING));
        assertEquals("false alarm (binary info)", 0, testDiffListener.countBinaryCompatibilityDiffs(Severity.INFO));
        assertEquals("false alarm (source info)", 0, testDiffListener.countSourceCompatibilityDiffs(Severity.INFO));
    }
}

Index: Regression1373831Test.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/Regression1373831Test.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- Regression1373831Test.java	16 Mar 2006 22:30:18 -0000	1.2
+++ Regression1373831Test.java	4 May 2007 18:58:36 -0000	1.3
@@ -1,8 +1,5 @@
 package net.sf.clirr.core.internal.checks;
 
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
 import net.sf.clirr.core.Severity;
 
 /**
@@ -13,20 +10,6 @@
  */
 public class Regression1373831Test extends AbstractRegressionTestCase
 {
-    Pattern STD_REGRESSION_TEST_PATTERN = Pattern.compile("^.*Regression(.*)Test$");
-    
-    protected String getTrackerId() 
-    {
-        final String fqTestName = this.getClass().getName();
-        final Matcher matcher = STD_REGRESSION_TEST_PATTERN.matcher(fqTestName);
-        if (matcher.matches())
-        {
-            final String group = matcher.group(1);
-            return group;
-        }
-        throw new UnsupportedOperationException("The default implementation works only for classes that follow the naming scheme 'Regression<id>Test'");
-    }
-
     public void testRegression()
     {
         runChecker();

Index: AbstractRegressionTestCase.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/AbstractRegressionTestCase.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- AbstractRegressionTestCase.java	9 Jan 2006 21:38:38 -0000	1.1
+++ AbstractRegressionTestCase.java	4 May 2007 18:58:36 -0000	1.2
@@ -1,5 +1,8 @@
 package net.sf.clirr.core.internal.checks;
 
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
 import net.sf.clirr.core.Checker;
 import net.sf.clirr.core.ClassFilter;
 import net.sf.clirr.core.ClassSelector;
@@ -10,8 +13,20 @@
  */
 public abstract class AbstractRegressionTestCase extends AbstractCheckerTestCase
 {
-    protected abstract String getTrackerId();
+    private Pattern STD_REGRESSION_TEST_PATTERN = Pattern.compile("^.*Regression(.*)Test$");
     
+    protected String getTrackerId() 
+    {
+        final String fqTestName = this.getClass().getName();
+        final Matcher matcher = STD_REGRESSION_TEST_PATTERN.matcher(fqTestName);
+        if (matcher.matches())
+        {
+            final String group = matcher.group(1);
+            return group;
+        }
+        throw new UnsupportedOperationException("The default implementation works only for classes that follow the naming scheme 'Regression<id>Test'");
+    }
+
     protected ClassFilter createClassFilter() 
     {
         ClassSelector classSelector = new ClassSelector(ClassSelector.MODE_IF);

[Clirr-devel] CVS: clirr/core/src/testinput/testlib-v1/testlib/regressions/bug1022446 - New directory

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/testinput/testlib-v1/testlib/regressions/bug1022446
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv8677/src/testinput/testlib-v1/testlib/regressions/bug1022446

Log Message:
Directory /cvsroot/clirr/clirr/core/src/testinput/testlib-v1/testlib/regressions/bug1022446 added to the repository

[Clirr-devel] CVS: clirr/core/src/testinput/testlib-v2/testlib/regressions/bug1022446 - New directory

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/testinput/testlib-v2/testlib/regressions/bug1022446
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv8677/src/testinput/testlib-v2/testlib/regressions/bug1022446

Log Message:
Directory /cvsroot/clirr/clirr/core/src/testinput/testlib-v2/testlib/regressions/bug1022446 added to the repository

[Clirr-devel] [ clirr-Feature Requests-1710771 ] Clirr missing nested inner classes

[SourceForge.net <no...@so...>]

Feature Requests item #1710771, was opened at 2007-05-01 15:29
Message generated for change (Comment added) made by nascif
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1710771&group_id=89627

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nascif Abousalh Neto (nascif)
Assigned to: Nobody/Anonymous (nobody)
Summary: Clirr missing nested inner classes

Initial Comment:
I thought this was a problem with our build missing the inner classes but I verified that they are in the jar file. Could you please check if Clirr is dealing with doubly nested inner classes properly?

Here is the error message:

Unable to complete checks:Unable to locate enclosing class com.xyz.editor.LogListView$1 for nested class com.xyz.editor.LogListView$1$1

Here is the source code:

LogListView.java
	private synchronized void updateHorizontalScrollbar()
	{
		// This method attempts to update the horizontal scroll bar by looking
		// at
		// the lines in the line cache and adjusting the scrollbar to be wide
		// enough
		// to show the longest one.
		if (mUpdateScrollbarTask != null)
		{
			// if we already have a task, then cancel it
			mUpdateScrollbarTask.cancel();
		}

		// create a new task
		mUpdateScrollbarTask = new TimerTask()
		{

			public void run()
			{
				javax.swing.SwingUtilities.invokeLater(new Runnable()
				{

					public void run()
					{
						// calculate longest line and tell the editor pane to


----------------------------------------------------------------------

>Comment By: Nascif Abousalh Neto (nascif)
Date: 2007-05-03 16:55

Message:
Logged In: YES 
user_id=263845
Originator: YES

I guess this should have been a bug, not a feature request.
Does it happen in the CVS version as well? 

I am concerned about putting more effort on testing with 0.6. I am finding
some problems (classDefNotFound for classes that are in the classpath) that
perhaps have already been fixed, or that are BCEL specific.

Any chance we can have a new (alpha, release candidate) version available
soon?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1710771&group_id=89627