clirr-devel Mailing List for Clirr (Page 6)
Status: Alpha
Brought to you by:
lkuehne
You can subscribe to this list here.
2003 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(15) |
Oct
(23) |
Nov
|
Dec
(25) |
---|---|---|---|---|---|---|---|---|---|---|---|---|
2004 |
Jan
(9) |
Feb
|
Mar
|
Apr
|
May
(76) |
Jun
(207) |
Jul
(242) |
Aug
(42) |
Sep
(33) |
Oct
|
Nov
(7) |
Dec
(1) |
2005 |
Jan
|
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
|
Jul
(3) |
Aug
(66) |
Sep
(38) |
Oct
(6) |
Nov
|
Dec
(2) |
2006 |
Jan
(17) |
Feb
(5) |
Mar
(28) |
Apr
(6) |
May
|
Jun
|
Jul
(1) |
Aug
|
Sep
|
Oct
(1) |
Nov
(1) |
Dec
(7) |
2007 |
Jan
|
Feb
|
Mar
|
Apr
(7) |
May
(33) |
Jun
(4) |
Jul
(3) |
Aug
|
Sep
(5) |
Oct
|
Nov
|
Dec
|
2008 |
Jan
(4) |
Feb
(3) |
Mar
(2) |
Apr
|
May
(1) |
Jun
|
Jul
(6) |
Aug
(8) |
Sep
(5) |
Oct
(20) |
Nov
(7) |
Dec
(9) |
2009 |
Jan
(8) |
Feb
(3) |
Mar
(20) |
Apr
(10) |
May
(40) |
Jun
(11) |
Jul
(23) |
Aug
(4) |
Sep
(1) |
Oct
(1) |
Nov
|
Dec
(2) |
2010 |
Jan
(5) |
Feb
(1) |
Mar
|
Apr
|
May
|
Jun
(1) |
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
2011 |
Jan
|
Feb
|
Mar
|
Apr
(3) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
2012 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
2013 |
Jan
|
Feb
|
Mar
|
Apr
(6) |
May
(22) |
Jun
(2) |
Jul
|
Aug
|
Sep
|
Oct
(2) |
Nov
(1) |
Dec
(2) |
2014 |
Jan
(5) |
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(1) |
Dec
|
2015 |
Jan
(1) |
Feb
(2) |
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2016 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(1) |
Nov
|
Dec
|
2017 |
Jan
|
Feb
|
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
From: Lars Küh. <lk...@us...> - 2008-08-17 10:58:55
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv24051/core/src/java/net/sf/clirr/core/internal Modified Files: ClassLoaderUtil.java Log Message: fixed typo Index: ClassLoaderUtil.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/ClassLoaderUtil.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- ClassLoaderUtil.java 4 May 2007 19:14:35 -0000 1.2 +++ ClassLoaderUtil.java 17 Aug 2008 10:58:51 -0000 1.3 @@ -12,7 +12,7 @@ public final class ClassLoaderUtil { - /** prevent instatiation. */ + /** prevent instantiation. */ private ClassLoaderUtil() { } |
From: Lars Küh. <lk...@us...> - 2008-07-28 20:54:40
|
Update of /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv16725/core/src/test/net/sf/clirr/core/internal/checks Modified Files: ExpectedDiff.java Log Message: fixed test failures in non-english locales, reported as part of bug #2019625 Index: ExpectedDiff.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/ExpectedDiff.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ExpectedDiff.java 11 Jul 2004 10:29:24 -0000 1.1 +++ ExpectedDiff.java 28 Jul 2008 20:54:37 -0000 1.2 @@ -1,5 +1,7 @@ package net.sf.clirr.core.internal.checks; +import java.util.Locale; + import net.sf.clirr.core.ApiDifference; import net.sf.clirr.core.MessageTranslator; import net.sf.clirr.core.Severity; @@ -10,7 +12,7 @@ public final class ExpectedDiff { - private static MessageTranslator translator = new MessageTranslator(); + private static MessageTranslator translator = new MessageTranslator(Locale.ENGLISH); private String report; private Severity binaryCompatibilitySeverity; |
From: Lars Küh. <lk...@us...> - 2008-07-28 20:54:40
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv16725/core/src/java/net/sf/clirr/core Modified Files: MessageTranslator.java Log Message: fixed test failures in non-english locales, reported as part of bug #2019625 Index: MessageTranslator.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/MessageTranslator.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- MessageTranslator.java 3 Aug 2005 17:16:13 -0000 1.3 +++ MessageTranslator.java 28 Jul 2008 20:54:37 -0000 1.4 @@ -36,16 +36,21 @@ */ public static final String DFLT_RESOURCE_NAME = EventMessages.class.getName(); - private Locale locale = Locale.getDefault(); + private Locale locale; private String resourceName = DFLT_RESOURCE_NAME; private ResourceBundle messageText; /** - * This is a singleton class; to get an instance of this class, use - * the getInstance method. + * Translate using the system default locale. */ public MessageTranslator() { + this(Locale.getDefault()); + } + + public MessageTranslator(Locale locale) + { + this.locale = locale; } /** |
From: SourceForge.net <no...@so...> - 2008-07-22 19:24:19
|
Feature Requests item #2024980, was opened at 2008-07-22 21:24 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590802&aid=2024980&group_id=89627 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Lars Khne (lkuehne) Assigned to: Nobody/Anonymous (nobody) Summary: Add support for Java5 annotations Initial Comment: Annotations are increasingly to express semantics, like in Spring's @Configured, @Transactional, in Tapestry's @Inject and @NonVisual, etc. If an annotation (or one of it's args) on a method or field changes, this should be reported by clirr. Not sure what to do with annotations on private fields. Probably report them, too, for example to catch changed JPA annotations on fields like a changed table name. Also not sure which level to use. Warning? And in which category, should it be in binary or should there be a new category, like "semantics"? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590802&aid=2024980&group_id=89627 |
From: SourceForge.net <no...@so...> - 2008-07-22 18:44:09
|
Feature Requests item #1295424, was opened at 2005-09-19 15:38 Message generated for change (Comment added) made by lkuehne You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1295424&group_id=89627 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Lars Khne (lkuehne) Assigned to: Nobody/Anonymous (nobody) Summary: Add support for Java5 enums Initial Comment: Clirr currently does not handle Java5 enums at all. I don't have much experience with Java 5 but there should be lots of potential errors, like adding a new constant, removing a constant, changing the value of a constant, etc. ---------------------------------------------------------------------- >Comment By: Lars Khne (lkuehne) Date: 2008-07-22 20:44 Message: Logged In: YES user_id=401384 Originator: YES https://sourceforge.net/tracker/?func=detail&atid=590799&aid=2023504&group_id=89627 discusses final modifiers set by different compiler versions ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1295424&group_id=89627 |
From: SourceForge.net <no...@so...> - 2008-07-21 12:32:58
|
Bugs item #2023504, was opened at 2008-07-21 13:32 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=2023504&group_id=89627 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Checker Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Stephen Connolly (stephen_c) Assigned to: Nobody/Anonymous (nobody) Summary: enums, prev version compiled in JDK 1.6 with source 1.5 Initial Comment: If you have an enum in your jar... And the previous build was using JDK 1.6 with source 1.5 And the current build is using JDK 1.5 You get the following error message: [ERROR] my.enum.package.MyEnum: Method 'public my.enum.package.MyEnum[] values()' is now final Given that the enum is generated by the JDK, this should be filtered out? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=2023504&group_id=89627 |
From: SourceForge.net <no...@so...> - 2008-07-16 15:42:18
|
Bugs item #2019625, was opened at 2008-07-16 17:26 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=2019625&group_id=89627 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Checker Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Arnaud Heritier (aheritier) Assigned to: Nobody/Anonymous (nobody) Summary: ClassNotFoundException and NullPointerException Initial Comment: java.lang.ClassNotFoundException: javax.servlet.Filter not found. [INFO] ------------------------------------------------------------------------ [ERROR] FATAL ERROR [INFO] ------------------------------------------------------------------------ [INFO] null [INFO] ------------------------------------------------------------------------ [INFO] Trace java.lang.NullPointerException at org.apache.bcel.classfile.JavaClass.getAllInterfaces(JavaClass.java:808) at net.sf.clirr.core.internal.bcel.BcelJavaType.getAllInterfaces(BcelJavaType.java:78) at net.sf.clirr.core.internal.checks.InterfaceSetCheck.check(InterfaceSetCheck.java:58) at net.sf.clirr.core.Checker.runClassChecks(Checker.java:190) at net.sf.clirr.core.Checker.reportDiffs(Checker.java:136) at org.codehaus.mojo.clirr.AbstractClirrMojo.executeClirr(AbstractClirrMojo.java:227) at org.codehaus.mojo.clirr.ClirrReport.doReport(ClirrReport.java:249) at org.codehaus.mojo.clirr.ClirrReport.generate(ClirrReport.java:225) at org.codehaus.mojo.clirr.ClirrReport.generate(ClirrReport.java:376) at org.codehaus.mojo.clirr.ClirrReport.execute(ClirrReport.java:188) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:451) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:558) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:512) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:482) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:330) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:291) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:142) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:336) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:129) at org.apache.maven.cli.MavenCli.main(MavenCli.java:287) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) The problem is solved by upgrading bcel to version 5.2 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=2019625&group_id=89627 |
From: SourceForge.net <no...@so...> - 2008-05-23 14:46:47
|
Bugs item #1970547, was opened at 2008-05-23 14:46 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=1970547&group_id=89627 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: CapnNemo (capnnemo) Assigned to: Nobody/Anonymous (nobody) Summary: Class path not parsed correctly Initial Comment: pathToFileArray(String path) uses int colonPos = path.indexOf(pos, File.pathSeparatorChar); However, that should be: int colonPos = path.indexOf(File.pathSeparatorChar, pos); The parameters to indexOf() are the wrong way round. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=1970547&group_id=89627 |
From: Lars Küh. <lk...@us...> - 2008-02-25 19:01:31
|
Update of /cvsroot/clirr/clirr/core In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv1594 Modified Files: pom.xml Log Message: removed ant.jar from *-all.jar Index: pom.xml =================================================================== RCS file: /cvsroot/clirr/clirr/core/pom.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- pom.xml 17 Feb 2008 20:20:46 -0000 1.1 +++ pom.xml 25 Feb 2008 19:01:26 -0000 1.2 @@ -43,6 +43,7 @@ <groupId>ant</groupId> <artifactId>ant</artifactId> <version>1.5.3-1</version> + <scope>provided</scope> </dependency> <dependency> <groupId>commons-cli</groupId> |
From: Simon K. <s_k...@us...> - 2008-02-17 20:20:51
|
Update of /cvsroot/clirr/clirr In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv22986 Added Files: pom.xml Log Message: Add maven2 build for Clirr. --- NEW FILE --- <!-- - Maven 2.x parent pom file for Clirr. - - This file configures defaults for all the clirr submodules. --> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> <modelVersion>4.0.0</modelVersion> <groupId>net.sf.clirr</groupId> <artifactId>clirr</artifactId> <packaging>pom</packaging> <name>CLIRR</name> <version>0.7-SNAPSHOT</version> <description> Clirr is a tool that checks Java libraries for binary and source compatibility with older releases. Basically you give it two sets of jar files and Clirr dumps out a list of changes in the public api. Clirr provides an Ant task that can be configured to break the build if it detects incompatible api changes. In a continuous integration process Clirr can automatically prevent accidental introduction of compatibility problems in Java libraries. </description> <url>http://clirr.sourceforge.net/</url> <!-- any mailing lists for the project --> <mailingLists> <mailingList> <name>clirr-user</name> <subscribe>http://lists.sourceforge.net/lists/listinfo/clirr-user</subscribe> <unsubscribe>http://lists.sourceforge.net/lists/listinfo/clirr-user</unsubscribe> <archive>http://lists.sourceforge.net/lists/listinfo/clirr-user</archive> </mailingList> <mailingList> <name>clirr-devel</name> <subscribe>http://lists.sourceforge.net/lists/listinfo/clirr-devel</subscribe> <unsubscribe>http://lists.sourceforge.net/lists/listinfo/clirr-devel</unsubscribe> <archive>http://lists.sourceforge.net/lists/listinfo/clirr-devel</archive> </mailingList> </mailingLists> <!-- who the developers are for the project --> <developers> <developer> <name>Lars Kühne</name> <id>lkuehne</id> <!-- <email>lkuehne at users sourceforge net</email> --> <organization>ppi Media</organization> <timezone>+1</timezone> <roles> <role>Java Developer</role> <role>Project Admin</role> </roles> </developer> <developer> <name>Vincent Massol</name> <id>vmassol</id> <organization>Apache Software Foundation</organization> <timezone>+1</timezone> <url>http://blogs.codehaus.org/people/vmassol</url> <roles> <role>Initial Inspiration and Feedback</role> <role>Java Developer</role> <role>Maven Guru</role> </roles> </developer> <developer> <name>Simon Kitching</name> <id>s_kitching</id> <organization>ECN</organization> <timezone>+12</timezone> <roles> <role>Java Developer</role> </roles> </developer> </developers> <contributors> <contributor> <name>Stephen Colebourne</name> <email/> <organization>Apache Software Foundation</organization> <roles> <role>Feedback</role> <role>Bug reports</role> <role>Usability testing</role> </roles> <url/> <timezone/> </contributor> </contributors> <scm> <connection>scm:cvs:pserver:ano...@cl...:/cvsroot/clirr:clirr</connection> <url>http://clirr.cvs.sourceforge.net/clirr</url> </scm> <distributionManagement> <site> <id>clirr-site</id> <name>Clirr Website</name> <url>scpexe://clirr.sourceforge.net/</url> </site> </distributionManagement> <modules> <module>core</module> </modules> </project> |
From: Simon K. <s_k...@us...> - 2008-02-17 20:20:50
|
Update of /cvsroot/clirr/clirr/core In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv22986/core Added Files: pom.xml Log Message: Add maven2 build for Clirr. --- NEW FILE --- <!-- - Maven 2.x pom file for the CLIRR Core module. --> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> <parent> <groupId>net.sf.clirr</groupId> <artifactId>clirr</artifactId> <version>0.7-SNAPSHOT</version> <relativePath>../pom.xml</relativePath> </parent> <modelVersion>4.0.0</modelVersion> <groupId>net.sf.clirr</groupId> <artifactId>clirr-core</artifactId> <packaging>jar</packaging> <name>CLIRR Core</name> <version>0.7-SNAPSHOT</version> <description> Clirr is a tool that checks Java libraries for binary and source compatibility with older releases. Basically you give it two sets of jar files and Clirr dumps out a list of changes in the public api. Clirr provides an Ant task that can be configured to break the build if it detects incompatible api changes. In a continuous integration process Clirr can automatically prevent accidental introduction of compatibility problems in Java libraries. </description> <url>http://clirr.sourceforge.net/core</url> <scm> <connection>scm:cvs:pserver:ano...@cl...:/cvsroot/clirr:clirr/core</connection> <url>http://clirr.cvs.sourceforge.net/clirr/core</url> </scm> <dependencies> <dependency> <groupId>asm</groupId> <artifactId>asm-all</artifactId> <version>2.2</version> </dependency> <dependency> <groupId>ant</groupId> <artifactId>ant</artifactId> <version>1.5.3-1</version> </dependency> <dependency> <groupId>commons-cli</groupId> <artifactId>commons-cli</artifactId> <version>1.0</version> </dependency> <dependency> <groupId>commons-lang</groupId> <artifactId>commons-lang</artifactId> <version>1.0.1</version> </dependency> <dependency> <groupId>junit</groupId> <artifactId>junit</artifactId> <version>3.8.1</version> <scope>test</scope> </dependency> </dependencies> <build> <sourceDirectory>src/java</sourceDirectory> <testSourceDirectory>src/test</testSourceDirectory> <resources> <resource> <directory>src/conf</directory> </resource> </resources> <plugins> <plugin> <artifactId>maven-compiler-plugin</artifactId> <version>2.0.2</version> </plugin> <plugin> <!-- - In order to run the unit tests, we have to build a couple of jars to - use as input to the tests. Unfortunately Maven isn't really structured - to do that without making these secondary jars into separate projects - which isn't desirable here. So just drop back to Ant for this part.. --> <artifactId>maven-antrun-plugin</artifactId> <version>1.1</version> <executions> <execution> <id>compile-testlibs</id> <phase>test-compile</phase> <configuration> <tasks> <property name="JAVA_HOME" value="${java.home}"/> <property name="srcbase" value="src/testinput"/> <property name="dstbase" value="target/testinput"/> <mkdir dir="${dstbase}/testlib-v1"/> <javac srcdir="${srcbase}/testlib-v1" destdir="${dstbase}/testlib-v1"/> <jar destfile="target/testlib-v1.jar" basedir="${dstbase}/testlib-v1"/> <mkdir dir="${dstbase}/testlib-v2"/> <javac srcdir="${srcbase}/testlib-v2" destdir="${dstbase}/testlib-v2"/> <jar destfile="target/testlib-v2.jar" basedir="${dstbase}/testlib-v2"/> </tasks> </configuration> <goals> <goal>run</goal> </goals> </execution> </executions> <dependencies> <dependency> <groupId>sun.jdk</groupId> <artifactId>tools</artifactId> <version>1.5</version> <scope>system</scope> <systemPath>${java.home}/../lib/tools.jar</systemPath> </dependency> </dependencies> </plugin> <plugin> <artifactId>maven-surefire-plugin</artifactId> <version>2.4</version> <configuration> <systemProperties> <property> <name>testinput</name> <value>${basedir}/target</value> </property> </systemProperties> </configuration> </plugin> <plugin> <artifactId>maven-jar-plugin</artifactId> <version>2.2</version> <configuration> <archive> <manifest> <mainClass>net.sf.clirr.cli.Clirr</mainClass> </manifest> </archive> </configuration> </plugin> <plugin> <artifactId>maven-source-plugin</artifactId> <version>2.0.4</version> <executions> <execution> <id>attach-sources</id> <goals> <goal>jar</goal> </goals> </execution> </executions> </plugin> <plugin> <!-- - Build an additional artifact which is a jar that contains - all the clirr classes plus all classes from all runtime - dependencies. This jar can then be run by users without - having to download anything else. --> <artifactId>maven-shade-plugin</artifactId> <executions> <execution> <phase>package</phase> <goals> <goal>shade</goal> </goals> <configuration> <shadedArtifactAttached>true</shadedArtifactAttached> <shadedClassifierName>all</shadedClassifierName> </configuration> </execution> </executions> </plugin> </plugins> </build> <reporting> <plugins> <plugin> <artifactId>maven-changelog-plugin</artifactId> <version>2.1</version> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-javadoc-plugin</artifactId> <version>2.3</version> <configuration> <show>protected</show> </configuration> </plugin> <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>jxr-maven-plugin</artifactId> <version>2.0-beta-1</version> </plugin> <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>surefire-report-maven-plugin</artifactId> <version>2.0-beta-1</version> </plugin> <!-- maven-jdepend-plugin maven-license-plugin maven-tasklist-plugin (??) --> </plugins> </reporting> </project> |
From: simon <sim...@ch...> - 2008-01-12 14:57:46
|
On Fri, 2008-01-11 at 20:43 +0100, Lars Kühne wrote: > Jochen Wiedmann wrote: > > Hi, > > > > > > Hi Jochen, I saw that you are working on the maven plugin. Thanks, much > appreciated. > > > any plans for a 0.7 release? There haven't been any relevant changes > > in the last 6 months, so the current version seems stable? > > > > Thanks, > > > > Jochen > > Last May I was requesting feedback on the user list: > http://sourceforge.net/mailarchive/message.php?msg_name=4650B06F.3080403%40t-online.de > > I have not received any feedback at all, and my personal time is a bit > limited so the status hasn't changed since then: > > Outstanding issues before release 0.7: > * Change license from LGPL to ASL2 throughout the code > * fix bugs reported by users of this snapshot > * QA: Test against well known library code bases, like log4j, > hibernate, > spring, jakarta-commons-*, and compare results with Clirr 0.6 > * QA: Test in different JDK versions, 1.4 - 1.6 > > If someone (you?) could help with QA that would be wonderful. I just wanted to say that I'm still lurking on the list too, and hope one day to find enough time to get working on clirr again. Cheers, Simon |
From: <lak...@t-...> - 2008-01-11 19:43:32
|
Jochen Wiedmann wrote: > Hi, > > Hi Jochen, I saw that you are working on the maven plugin. Thanks, much appreciated. > any plans for a 0.7 release? There haven't been any relevant changes > in the last 6 months, so the current version seems stable? > > Thanks, > > Jochen Last May I was requesting feedback on the user list: http://sourceforge.net/mailarchive/message.php?msg_name=4650B06F.3080403%40t-online.de I have not received any feedback at all, and my personal time is a bit limited so the status hasn't changed since then: Outstanding issues before release 0.7: * Change license from LGPL to ASL2 throughout the code * fix bugs reported by users of this snapshot * QA: Test against well known library code bases, like log4j, hibernate, spring, jakarta-commons-*, and compare results with Clirr 0.6 * QA: Test in different JDK versions, 1.4 - 1.6 If someone (you?) could help with QA that would be wonderful. Regards, Lars |
From: SourceForge.net <no...@so...> - 2008-01-10 01:14:07
|
Bugs item #1868061, was opened at 2008-01-10 02:14 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=1868061&group_id=89627 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Checker Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jochen Wiedmann (joe) Assigned to: Nobody/Anonymous (nobody) Summary: classloader problem Initial Comment: I am one of the maintainers of the clirr-maven-plugin (see http://mojo.codehaus.org/clirr-maven-plugin). When I run mvn clirr:check in the commons-fileupload project (see http://commons.apache.org/fileupload), then I receive the error message below. FileUploadBase$1 is a class of the new version (1.2.1). This class doesn't exist in 1.2. I have checked, that no JavaType instance is present for this class in the old version. To the best of my knowledge, the classloaders are fine. Any ideas? net.sf.clirr.core.CheckerException: Unable to find information in class org.apache.commons.fileupload.FileUploadBase referring back to nested class org.apache.commons.fileupload.FileUploadBase$1 at net.sf.clirr.core.internal.bcel.BcelScopeHelper.getClassScope(BcelScopeHelper.java:127) at net.sf.clirr.core.internal.bcel.BcelJavaType.getDeclaredScope(BcelJavaType.java:141) at net.sf.clirr.core.internal.bcel.BcelJavaType.getEffectiveScope(BcelJavaType.java:145) at net.sf.clirr.core.Checker.runClassChecks(Checker.java:156) at net.sf.clirr.core.Checker.reportDiffs(Checker.java:136) at org.codehaus.mojo.clirr.AbstractClirrMojo.executeClirr(AbstractClirrMojo.java:235) at org.codehaus.mojo.clirr.AbstractClirrMojo.executeClirr(AbstractClirrMojo.java:181) at org.codehaus.mojo.clirr.ClirrCheckMojo.execute(ClirrCheckMojo.java:68) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=1868061&group_id=89627 |
From: Jochen W. <joc...@gm...> - 2008-01-10 00:58:42
|
Hi, any plans for a 0.7 release? There haven't been any relevant changes in the last 6 months, so the current version seems stable? Thanks, Jochen -- Look, that's why there's rules, understand? So that you think before you break 'em. -- (Terry Pratchett, Thief of Time) |
From: <lk...@us...> - 2007-09-11 11:04:17
|
Update of /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv30558/src/conf/net/sf/clirr/core Modified Files: EventMessages_fr.properties Log Message: fixed missing 'e' in latest additions to french message translations Index: EventMessages_fr.properties =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core/EventMessages_fr.properties,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- EventMessages_fr.properties 10 Sep 2007 20:38:13 -0000 1.2 +++ EventMessages_fr.properties 11 Sep 2007 11:04:06 -0000 1.3 @@ -91,5 +91,5 @@ généralement qu''une archive jar ou un classpath invalides ont été fournis \ au programme clirr. -m10000=La version du format de classe pour la classe {0} a été incrémenté de {3} à {4} -m10001=La version du format de classe pour la classe {0} a été décrémenté de {3} à {4} +m10000=La version du format de classe pour la classe {0} a été incrémentée de {3} à {4} +m10001=La version du format de classe pour la classe {0} a été décrémentée de {3} à {4} |
From: <lk...@us...> - 2007-09-10 20:38:17
|
Update of /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv13092/src/conf/net/sf/clirr/core Modified Files: EventMessages_fr.properties Log Message: Added french message translations for new messages, contributed by Luc Maisonobe. (Patch #1791134) Index: EventMessages_fr.properties =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core/EventMessages_fr.properties,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- EventMessages_fr.properties 10 Sep 2007 19:42:24 -0000 1.1 +++ EventMessages_fr.properties 10 Sep 2007 20:38:13 -0000 1.2 @@ -91,3 +91,5 @@ généralement qu''une archive jar ou un classpath invalides ont été fournis \ au programme clirr. +m10000=La version du format de classe pour la classe {0} a été incrémenté de {3} à {4} +m10001=La version du format de classe pour la classe {0} a été décrémenté de {3} à {4} |
From: <lk...@us...> - 2007-09-10 19:42:28
|
Update of /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv23735/src/conf/net/sf/clirr/core Added Files: EventMessages_fr.properties Log Message: Added french message translations, contributed by Luc Maisonobe. (Patch #1791134) --- NEW FILE --- # Translations for messages generated by the check classes. # # {0} --> full class name of affected class # {1} --> full method prototype of affected method # {2} --> full field declaration of affected field # {3}..{n} --> check-specific parameters #----------------------------------------------------------------------------- # ClassScopeCheck messages #----------------------------------------------------------------------------- m1000=Extension de la visibilité de la classe de {3} à {4} m1001=Réduction de la visibilité de la classe de {3} à {4} m1002=Incapable de déterminer la portée de la class: {3} dans l''ancienne version de classe m1003=Incapable de déterminer la portée de la class: {3} dans la nouvelle version de classe #----------------------------------------------------------------------------- # GenderChangeCheck messages #----------------------------------------------------------------------------- m2000=Transformation de classe à interface m2001=Transformation d''interface à classe #----------------------------------------------------------------------------- # ClassModifierCheck messages #----------------------------------------------------------------------------- m3000=Incapable de déterminer si la classe est privée m3001=Élimination du modificateur « final » de la classe m3002=Ajout du modificateur « final » à la classe, qui de toute façon était déjà finale m3003=Ajout du modificateur « final » à la classe m3004=Élimination du modificateur « abstract » de la classe m3005=Ajout du modificateur « abstract » à la classe #----------------------------------------------------------------------------- # InterfaceSetCheck messages #----------------------------------------------------------------------------- m4000=Ajout de {3} à l''ensemble des interfaces implantées m4001=Élimination de {3} de l''ensemble des interfaces implantées #----------------------------------------------------------------------------- # ClassHierarchyCheck messages #----------------------------------------------------------------------------- m5000=Ajout de {3} à la liste des superclasses m5001=Élimination de {3} de la liste des superclasses #----------------------------------------------------------------------------- # FieldSetCheck messages #----------------------------------------------------------------------------- m6000=Ajour de {3} champ {2} m6001=Élimination du champ {2} m6002=La valeur du champ {2} n''est plus une constante à la compilation m6003=La valeur de la constante à la compilation {2} a changée m6004=Changement du type du champ {2} de {3} à {4} m6005=Le champ {2} n''est plus « final » m6006=Le champ {2} est désormais « final » m6007=Le champ {2} n''est plus « static » m6008=Le champ {2} est désormais « static » m6009=L''accessibilité du champ {2} a été étendue de {3} à {4} m6010=L''accessibilité du champ {2} a été réduite de {3} à {4} m6011=Le champ {2} a été éliminé, alors que c''était une constante auparavant #----------------------------------------------------------------------------- # MethodSetCheck messages #----------------------------------------------------------------------------- m7000=La méthode « {1} » est désormais implantée dans la superclasse {3} m7001=La méthode abstraite « {1} » est désormais spécifiée par l''interface implantée {3} m7002=La méthode « {1} » a été éliminée m7003=La méthode « {1} » a été éliminée, mais il en existe une définition héritée. m7004=Le nombre d''arguments de la méthode « {1} » a changé m7005=Le type du paramètre {3} de « {1} » est devenu {4} m7006=Le type de retour de la méthode « {1} » est devenu {3} m7007=La méthode « {1} » a été dépréciée m7008=La méthode « {1} » n''est plus dépréciée m7009=L''accessibilité de la méthode « {1} » a été réduite de {3} à {4} m7010=L''accessibilité de la méthode « {1} » a été étendue de {3} à {4} m7011=La méthode « {1} » a été ajoutée m7012=La méthode « {1} » a été ajoutée à une interface m7013=La méthode abstraite « {1} » a été ajoutée m7014=La méthode « {1} » est désormais finale m7015=La méthode « {1} » n''est plus finale #----------------------------------------------------------------------------- # Core Check messages #----------------------------------------------------------------------------- m8000=La classe {0} a été ajoutée m8001=La classe {0} a été éliminée #----------------------------------------------------------------------------- # Assorted messages #----------------------------------------------------------------------------- m9000=Incapable de déterminer l''accessibilité de la classe {0}. Ceci signifie \ généralement qu''une archive jar ou un classpath invalides ont été fournis \ au programme clirr. |
From: <lk...@us...> - 2007-09-10 19:42:28
|
Update of /cvsroot/clirr/clirr/core/xdocs In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv23735/xdocs Modified Files: changes.xml Log Message: Added french message translations, contributed by Luc Maisonobe. (Patch #1791134) Index: changes.xml =================================================================== RCS file: /cvsroot/clirr/clirr/core/xdocs/changes.xml,v retrieving revision 1.20 retrieving revision 1.21 diff -u -r1.20 -r1.21 --- changes.xml 9 Jul 2007 19:41:52 -0000 1.20 +++ changes.xml 10 Sep 2007 19:42:25 -0000 1.21 @@ -8,6 +8,10 @@ <body> <release version="0.7-dev" date="in CVS"> + <action dev="lkuehne" type="add"> + <!-- Patch #1791134 --> + Added french message translations, contributed by Luc Maisonobe. + </action> <action dev="lkuehne" type="fix"> Fixed unit tests for scope change of inner classes. Surprisingly, at the byte code level inner classes do not have the same access modifiers |
From: SourceForge.net <no...@so...> - 2007-09-09 17:24:48
|
Bugs item #1791134, was opened at 2007-09-09 19:24 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=1791134&group_id=89627 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Other Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Luc Maisonobe (maisonobe) Assigned to: Nobody/Anonymous (nobody) Summary: adding french properties Initial Comment: Here is a small contribution to clirr : properties for messages in french. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=1791134&group_id=89627 |
From: <lk...@us...> - 2007-07-09 19:42:01
|
Update of /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv9052/src/test/net/sf/clirr/core/internal/checks Modified Files: ClassScopeCheckTest.java Log Message: Fixed unit tests for scope change of inner classes. Index: ClassScopeCheckTest.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/ClassScopeCheckTest.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- ClassScopeCheckTest.java 9 Jan 2006 21:38:38 -0000 1.5 +++ ClassScopeCheckTest.java 9 Jul 2007 19:41:52 -0000 1.6 @@ -16,23 +16,54 @@ { public void testAccessChangesAreReported() throws Exception { + // note that + // - protected inner classes are technically public but have a protected constructor. + // - private inner classes are technically package visible + // Hence on the class level there are fewer changes than one might expect + // Don't believe this? Try using the JDK's javap tool on the inner classes! ExpectedDiff[] expected = new ExpectedDiff[] { - new ExpectedDiff("Decreased visibility of class from public to protected", Severity.ERROR, "testlib.scope.ClassScopeChange$A2", null, null), - new ExpectedDiff("Decreased visibility of class from public to package", Severity.ERROR, "testlib.scope.ClassScopeChange$A3", null, null), - new ExpectedDiff("Decreased visibility of class from public to private", Severity.ERROR, "testlib.scope.ClassScopeChange$A4", null, null), - - new ExpectedDiff("Increased visibility of class from protected to public", Severity.INFO, "testlib.scope.ClassScopeChange$B2", null, null), - new ExpectedDiff("Decreased visibility of class from protected to package", Severity.ERROR, "testlib.scope.ClassScopeChange$B3", null, null), - new ExpectedDiff("Decreased visibility of class from protected to private", Severity.ERROR, "testlib.scope.ClassScopeChange$B4", null, null), - - new ExpectedDiff("Increased visibility of class from package to public", Severity.INFO, "testlib.scope.ClassScopeChange$C2", null, null), - new ExpectedDiff("Increased visibility of class from package to protected", Severity.INFO, "testlib.scope.ClassScopeChange$C3", null, null), - // package->private is not an error, just an info, because we never report error for package or private diffs - new ExpectedDiff("Decreased visibility of class from package to private", Severity.INFO, "testlib.scope.ClassScopeChange$C4", null, null), - - new ExpectedDiff("Increased visibility of class from private to public", Severity.INFO, "testlib.scope.ClassScopeChange$D2", null, null), - new ExpectedDiff("Increased visibility of class from private to protected", Severity.INFO, "testlib.scope.ClassScopeChange$D3", null, null), - new ExpectedDiff("Increased visibility of class from private to package", Severity.INFO, "testlib.scope.ClassScopeChange$D4", null, null), + + // A1 is unchanged + + // A2 is still technically a public class in v2 + + new ExpectedDiff("Decreased visibility of class from public to package", Severity.ERROR, + "testlib.scope.ClassScopeChange$A3", null, null), + + // A4 is technically package visible in V2 + new ExpectedDiff("Decreased visibility of class from public to package", Severity.ERROR, + "testlib.scope.ClassScopeChange$A4", null, null), + + // B1 is unchanged + + // B2 has technically been a public class in v1 + + // B3 is technically public in v1 + new ExpectedDiff("Decreased visibility of class from public to package", Severity.ERROR, + "testlib.scope.ClassScopeChange$B3", null, null), + + // B4 is technically public in v1 and package visible in v2 + new ExpectedDiff("Decreased visibility of class from public to package", Severity.ERROR, + "testlib.scope.ClassScopeChange$B4", null, null), + + new ExpectedDiff("Increased visibility of class from package to public", Severity.INFO, + "testlib.scope.ClassScopeChange$C2", null, null), + + // B4 is technically package visible in v1 and public in v2 + new ExpectedDiff("Increased visibility of class from package to public", Severity.INFO, + "testlib.scope.ClassScopeChange$C3", null, null), + + // C4 is technically package visible in v2 + + // D1 is technically package visible in v1 + + new ExpectedDiff("Increased visibility of class from package to public", Severity.INFO, + "testlib.scope.ClassScopeChange$D2", null, null), + + new ExpectedDiff("Increased visibility of class from package to public", Severity.INFO, + "testlib.scope.ClassScopeChange$D3", null, null), + + // D4 is technically package visible in v1 }; verify(expected); } |
From: <lk...@us...> - 2007-07-09 19:42:01
|
Update of /cvsroot/clirr/clirr/core/xdocs In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv9052/xdocs Modified Files: changes.xml Log Message: Fixed unit tests for scope change of inner classes. Index: changes.xml =================================================================== RCS file: /cvsroot/clirr/clirr/core/xdocs/changes.xml,v retrieving revision 1.19 retrieving revision 1.20 diff -u -r1.19 -r1.20 --- changes.xml 17 Jun 2007 19:51:54 -0000 1.19 +++ changes.xml 9 Jul 2007 19:41:52 -0000 1.20 @@ -8,6 +8,13 @@ <body> <release version="0.7-dev" date="in CVS"> + <action dev="lkuehne" type="fix"> + Fixed unit tests for scope change of inner classes. Surprisingly, + at the byte code level inner classes do not have the same access modifiers + as in the source code. Instead, private inner classes are technically + package visible and protected inner classes are technically public + (verified with the JDK's javap tool). + </action> <action dev="lkuehne" type="add"> <!-- RFE #1719563--> Added check to report class format version changes. |
From: SourceForge.net <no...@so...> - 2007-07-04 22:36:16
|
Bugs item #1748091, was opened at 2007-07-05 00:36 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=1748091&group_id=89627 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Lars Kühne (lkuehne) Assigned to: Nobody/Anonymous (nobody) Summary: No message when adding checked exception Initial Comment: http://permalink.gmane.org/gmane.comp.jakarta.commons.devel/97642 Clirr should at least flag a source incompatibility ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590799&aid=1748091&group_id=89627 |
From: <lk...@us...> - 2007-06-17 19:51:59
|
Update of /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv13483/src/conf/net/sf/clirr/core Modified Files: EventMessages_en.properties EventMessages_de.properties Log Message: RFE #1719563: added check to report class format version changes Index: EventMessages_en.properties =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core/EventMessages_en.properties,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- EventMessages_en.properties 1 Aug 2005 07:21:42 -0000 1.5 +++ EventMessages_en.properties 17 Jun 2007 19:51:54 -0000 1.6 @@ -92,3 +92,5 @@ means that an invalid jarfile or classpath has been provided to the \ clirr program. +m10000=Class Format Version of class {0} has been increased from {3} to {4} +m10001=Class Format Version of class {0} has been decreased from {3} to {4} Index: EventMessages_de.properties =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core/EventMessages_de.properties,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- EventMessages_de.properties 1 Aug 2005 07:21:42 -0000 1.4 +++ EventMessages_de.properties 17 Jun 2007 19:51:55 -0000 1.5 @@ -83,3 +83,6 @@ #----------------------------------------------------------------------------- m8000=Klasse {0} wurde hinzugefügt m8001=Klasse {0} wurde entfernt + +m10000=Klassenformatversion der Klasse {0} wurde von {3} auf {4} erhöht +m10001=Klassenformatversion der Klasse {0} wurde von {3} auf {4} verringert |
From: <lk...@us...> - 2007-06-17 19:51:58
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv13483/src/java/net/sf/clirr/core Modified Files: Checker.java Log Message: RFE #1719563: added check to report class format version changes Index: Checker.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/Checker.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- Checker.java 5 Sep 2005 21:14:52 -0000 1.9 +++ Checker.java 17 Jun 2007 19:51:54 -0000 1.10 @@ -27,6 +27,7 @@ import net.sf.clirr.core.internal.ClassChangeCheck; import net.sf.clirr.core.internal.CoIterator; import net.sf.clirr.core.internal.NameComparator; +import net.sf.clirr.core.internal.checks.ClassFormatVersionCheck; import net.sf.clirr.core.internal.checks.ClassHierarchyCheck; import net.sf.clirr.core.internal.checks.ClassModifierCheck; import net.sf.clirr.core.internal.checks.ClassScopeCheck; @@ -76,6 +77,7 @@ { classChecks.add(new ClassScopeCheck(this, scopeSelector)); classChecks.add(new GenderChangeCheck(this)); + classChecks.add(new ClassFormatVersionCheck(this)); classChecks.add(new ClassModifierCheck(this)); classChecks.add(new InterfaceSetCheck(this)); classChecks.add(new ClassHierarchyCheck(this)); |