clirr-devel Mailing List for Clirr (Page 17)
Status: Alpha
Brought to you by:
lkuehne
Menu
▾
▴
clirr-devel — Discussion about the source code of Clirr
You can subscribe to this list here.
| 2003 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(15) |
Oct
(23) |
Nov
|
Dec
(25) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2004 |
Jan
(9) |
Feb
|
Mar
|
Apr
|
May
(76) |
Jun
(207) |
Jul
(242) |
Aug
(42) |
Sep
(33) |
Oct
|
Nov
(7) |
Dec
(1) |
| 2005 |
Jan
|
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
|
Jul
(3) |
Aug
(66) |
Sep
(38) |
Oct
(6) |
Nov
|
Dec
(2) |
| 2006 |
Jan
(17) |
Feb
(5) |
Mar
(28) |
Apr
(6) |
May
|
Jun
|
Jul
(1) |
Aug
|
Sep
|
Oct
(1) |
Nov
(1) |
Dec
(7) |
| 2007 |
Jan
|
Feb
|
Mar
|
Apr
(7) |
May
(33) |
Jun
(4) |
Jul
(3) |
Aug
|
Sep
(5) |
Oct
|
Nov
|
Dec
|
| 2008 |
Jan
(4) |
Feb
(3) |
Mar
(2) |
Apr
|
May
(1) |
Jun
|
Jul
(6) |
Aug
(8) |
Sep
(5) |
Oct
(20) |
Nov
(7) |
Dec
(9) |
| 2009 |
Jan
(8) |
Feb
(3) |
Mar
(20) |
Apr
(10) |
May
(40) |
Jun
(11) |
Jul
(23) |
Aug
(4) |
Sep
(1) |
Oct
(1) |
Nov
|
Dec
(2) |
| 2010 |
Jan
(5) |
Feb
(1) |
Mar
|
Apr
|
May
|
Jun
(1) |
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
| 2011 |
Jan
|
Feb
|
Mar
|
Apr
(3) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
| 2012 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
(6) |
May
(22) |
Jun
(2) |
Jul
|
Aug
|
Sep
|
Oct
(2) |
Nov
(1) |
Dec
(2) |
| 2014 |
Jan
(5) |
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(1) |
Dec
|
| 2015 |
Jan
(1) |
Feb
(2) |
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2016 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(1) |
Nov
|
Dec
|
| 2017 |
Jan
|
Feb
|
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: <lk...@us...> - 2004-09-05 13:00:30
|
Update of /cvsroot/clirr/clirr/core/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv14780/core/xdocs Modified Files: runcli.xml Log Message: there is no separate uberjar download avoid hardcoded version that doesn't exist yet Index: runcli.xml =================================================================== RCS file: /cvsroot/clirr/clirr/core/xdocs/runcli.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- runcli.xml 15 Aug 2004 11:06:11 -0000 1.2 +++ runcli.xml 5 Sep 2004 13:00:21 -0000 1.3 @@ -8,12 +8,12 @@ <body> <section name="Running Clirr from the Command Line"> <p> - Clirr provides an "uberjar" download, which bundles all the + Clirr provides an "uberjar", which bundles all the necessary code, including all required libraries, into a single executable jar file. Clirr can then be run from a commandline via the command: <code> - java -jar clirr-core-1.0-uber.jar + java -jar clirr-core-@VERSION@-uber.jar </code> Running clirr with no command-line arguments will display the available options. |
|
From: <lk...@us...> - 2004-09-05 12:40:46
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11828/xdocs Removed Files: changes.xml Log Message: changes are maintained separately for each subproject |
|
From: <lk...@us...> - 2004-09-05 12:36:35
|
Update of /cvsroot/clirr/clirr/maven In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11292/maven Modified Files: plugin.jelly Log Message: ant task property names have been changed Index: plugin.jelly =================================================================== RCS file: /cvsroot/clirr/clirr/maven/plugin.jelly,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- plugin.jelly 22 Aug 2004 13:03:09 -0000 1.3 +++ plugin.jelly 5 Sep 2004 12:36:26 -0000 1.4 @@ -109,8 +109,11 @@ <ant:basename property="clirr.baseline.destination.basename" file="${clirr.baseline.destination}"/> - <clirr failOnWarning="${clirr.fail.on.warning}" - failOnError="${clirr.fail.on.error}"> + <clirr + failOnBinWarning="${clirr.fail.on.warning}" + failOnBinError="${clirr.fail.on.error}" + failOnSrcWarning="${clirr.fail.on.warning}" + failOnSrcError="${clirr.fail.on.error}"> <origFiles dir="${clirr.baseline.destination.dir}" includes="${clirr.baseline.destination.basename}"/> <newFiles dir="${maven.build.dir}" includes="${maven.final.name}.jar"/> |
|
From: <lk...@us...> - 2004-09-05 12:26:05
|
Update of /cvsroot/clirr/clirr/maven/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9837/maven/xdocs Modified Files: goals.xml Log Message: clirr checks binary and source compatibility now Index: goals.xml =================================================================== RCS file: /cvsroot/clirr/clirr/maven/xdocs/goals.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- goals.xml 15 Jul 2004 13:34:22 -0000 1.1 +++ goals.xml 5 Sep 2004 12:25:50 -0000 1.2 @@ -16,9 +16,9 @@ <goal> <name>clirr:check</name> <description> - Run binary compatibility checks. + Run compatibility checks. </description> </goal> </goals> </body> -</document> \ No newline at end of file +</document> |
|
From: <lk...@us...> - 2004-09-05 12:23:34
|
Update of /cvsroot/clirr/clirr/maven/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9377/maven/xdocs Modified Files: properties.xml Log Message: docs for some properties Index: properties.xml =================================================================== RCS file: /cvsroot/clirr/clirr/maven/xdocs/properties.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- properties.xml 15 Jul 2004 13:34:22 -0000 1.1 +++ properties.xml 5 Sep 2004 12:23:15 -0000 1.2 @@ -14,10 +14,39 @@ <th>Description</th> </tr> <tr> - <td>xxx</td> - <td>xxx</td> + <td>clirr.baseline.download</td> + <td>yes</td> <td> - xxxx + Decide whether the plugin will try to download the baseline + jar or not. Default is true</td> + </tr> +<!-- from looking at plugin.jelly I'm not sure this actually works + <tr> + <td>clirr.baseline.version</td> + <td>yes</td> + <td> + Baseline version to check binary compatibility with. + If the property is not defined, the clirr plugin will use + the last released version from the POM using the <versions> + tag. We assume the latest version is the last one in the + <version> list. + </td> + </tr> +--> + <tr> + <td>clirr.fail.on.warning</td> + <td>yes</td> + <td> + Decide whether to fail the build on Clirr-detected warnings. + Default is false. + </td> + </tr> + <tr> + <td>clirr.fail.on.error</td> + <td>yes</td> + <td> + Decide whether to fail the build on Clirr-detected errors. + Default is true. </td> </tr> </table> |
|
From: <lk...@us...> - 2004-09-05 11:45:41
|
Update of /cvsroot/clirr/clirr In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3884 Modified Files: maven.xml Log Message: require Maven 1.0, build the whole thing by simply typing 'maven' Index: maven.xml =================================================================== RCS file: /cvsroot/clirr/clirr/maven.xml,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- maven.xml 15 Aug 2004 11:01:12 -0000 1.3 +++ maven.xml 5 Sep 2004 11:45:31 -0000 1.4 @@ -1,6 +1,6 @@ <?xml version="1.0"?> -<project default="dist" +<project default="dist-site" xmlns:u="jelly:util" xmlns:j="jelly:core"> |
|
From: <lk...@us...> - 2004-09-05 11:45:41
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3884/xdocs Modified Files: download.xml Log Message: require Maven 1.0, build the whole thing by simply typing 'maven' Index: download.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/download.xml,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- download.xml 25 May 2004 04:38:42 -0000 1.6 +++ download.xml 5 Sep 2004 11:45:31 -0000 1.7 @@ -32,7 +32,7 @@ </p> <ul> <li> - <a href="http://maven.apache.org">Maven</a> 1.0 RC1 or above. + <a href="http://maven.apache.org">Maven</a> 1.0 or above. </li> <li> A CVS client. If you are on Linux you probably @@ -53,7 +53,7 @@ cvs -d :pserver:ano...@cv...:/cvsroot/clirr login cvs -z3 -d :pserver:ano...@cv...:/cvsroot/clirr checkout clirr cd clirr -maven dist site +maven ]]></source> <p> Note that the anonymous CVS server on Sourceforge is |
|
From: SourceForge.net <no...@so...> - 2004-09-05 09:27:25
|
Feature Requests item #961222, was opened at 2004-05-27 00:48 Message generated for change (Comment added) made by lkuehne You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590802&aid=961222&group_id=89627 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Stephen Colebourne (scolebourne) Assigned to: Lars Kühne (lkuehne) Summary: Removing constants can be OK Initial Comment: Clirr objects when a static final constant is removed from a class. However, this is permitted if the type of the constant is primitive or a String. See commons-collections 3.0-HEAD ReferenceMap ---------------------------------------------------------------------- >Comment By: Lars Kühne (lkuehne) Date: 2004-09-05 11:27 Message: Logged In: YES user_id=401384 Clirr 0.4 differentiates between binary and source compatibility ("bc" and "sc"). Removing a field that is a compile time constant is marked as a bc warning and a sc error. Not closing this request because I think we are not handling "moved to superclass" correctly. ---------------------------------------------------------------------- Comment By: Stephen Colebourne (scolebourne) Date: 2004-06-04 00:53 Message: Logged In: YES user_id=408725 The JLS says that primitive and String constants must be inlined at compile time (IIRC, always worth checking...) Object based constants are not inlined, so should cause the error in clirr if moved. Thus although ReferenceMap.HARD, .WEAK and .SOFT have been deleted, this causes no binary incompatibility (they are int constants). (The constants can be removed completely without binary incompatibility - in this case, they actually moved to a superclass) ---------------------------------------------------------------------- Comment By: Lars Kühne (lkuehne) Date: 2004-06-02 10:37 Message: Logged In: YES user_id=401384 You mean that compile time constants are inlined into the client code and removing them will not affect compiled clients? Which constant in ReferenceMap do you mean? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=590802&aid=961222&group_id=89627 |
|
From: <lk...@us...> - 2004-09-05 09:21:12
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/checks In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7179 Modified Files: FieldSetCheck.java Log Message: removed unused local variables Index: FieldSetCheck.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/checks/FieldSetCheck.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- FieldSetCheck.java 23 Jul 2004 08:11:16 -0000 1.5 +++ FieldSetCheck.java 5 Sep 2004 09:20:42 -0000 1.6 @@ -97,7 +97,6 @@ { if (scopeSelector.isSelected(cField)) { - final String name = cField.getName(); String scope = ScopeSelector.getScopeDesc(cField); fireDiff(MSG_FIELD_ADDED, Severity.INFO, currentClass, cField, @@ -108,7 +107,6 @@ { if (scopeSelector.isSelected(bField)) { - final String name = bField.getName(); if ((bField.getConstantValue() != null) && bField.isFinal()) { // Fields which are compile-time constants will have |
|
From: <lk...@us...> - 2004-09-05 09:20:11
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7016 Modified Files: AbstractDiffReporter.java Log Message: fixed HTML code in javadocs Index: AbstractDiffReporter.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/AbstractDiffReporter.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- AbstractDiffReporter.java 16 Jul 2004 09:44:09 -0000 1.2 +++ AbstractDiffReporter.java 5 Sep 2004 09:19:54 -0000 1.3 @@ -60,9 +60,9 @@ * to INFO because the specified class is package or private accessibility. * Clirr reports changes at level INFO for all private and package * scoped objects. - * <p - * Note that the class passed here should always be from the <iold</i - * class version, because we're checking whether <iexisting</i code + * <p> + * Note that the class passed here should always be from the <i>old</i> + * class version, because we're checking whether <i>existing</i> code * would have been able to access it (potential compatibility problems) * or not. * @@ -107,16 +107,16 @@ /** * Determine whether the severity of the problem should be reduced * to INFO because: - * <ul - * <lithe specified method is package or private accessibility, or</li - * <lithe specified method is in a package or private class. </li - * </ul - * <p + * <ul> + * <li>the specified method is package or private accessibility, or</li> + * <li>the specified method is in a package or private class. </li + * </ul> + * <p> * Clirr reports changes at level INFO for all private and package * scoped objects. - * <p - * Note that the method passed here should always be from the <iold</i - * class version, because we're checking whether <iexisting</i code + * <p> + * Note that the method passed here should always be from the <i>old</i> + * class version, because we're checking whether <i>existing</i> code * would have been able to access it (potential compatibility problems) * or not. * @@ -143,16 +143,16 @@ /** * Determine whether the severity of the problem should be reduced * to INFO because: - * <ul - * <lithe specified field is package or private accessibility, or</li - * <lithe specified field is in a package or private class. </li - * </ul - * <p + * <ul> + * <li>the specified field is package or private accessibility, or</li> + * <li>the specified field is in a package or private class. </li> + * </ul> + * <p> * Clirr reports changes at level INFO for all private and package * scoped objects. - * <p - * Note that the field passed here should always be from the <iold</i - * class version, because we're checking whether <iexisting</i code + * <p> + * Note that the field passed here should always be from the <i>old</i> + * class version, because we're checking whether <i>existing</i> code * would have been able to access it (potential compatibility problems) * or not. * |
|
From: <lk...@us...> - 2004-09-03 23:05:15
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/ant In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv21906 Modified Files: AntTask.java Log Message: make code compilable on JDK 1.3 (exception chaining not available) Index: AntTask.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/ant/AntTask.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- AntTask.java 18 Jul 2004 00:56:18 -0000 1.2 +++ AntTask.java 3 Sep 2004 23:05:07 -0000 1.3 @@ -32,6 +32,7 @@ import net.sf.clirr.core.CheckerException; import net.sf.clirr.core.PlainDiffListener; import net.sf.clirr.core.XmlDiffListener; +import net.sf.clirr.core.internal.ExceptionUtil; import org.apache.tools.ant.BuildException; import org.apache.tools.ant.DirectoryScanner; @@ -304,7 +305,7 @@ final IllegalArgumentException illegalArgEx = new IllegalArgumentException( "Cannot create classLoader from classpath entry " + entry); - illegalArgEx.initCause(ex); + ExceptionUtil.initCause(illegalArgEx, ex); throw illegalArgEx; } } |
|
From: <lk...@us...> - 2004-09-03 23:04:57
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv21779 Modified Files: CheckerException.java Checker.java Log Message: make code compilable on JDK 1.3 (exception chaining not available) Index: CheckerException.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/CheckerException.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- CheckerException.java 10 Jul 2004 13:37:26 -0000 1.1 +++ CheckerException.java 3 Sep 2004 23:04:48 -0000 1.2 @@ -19,6 +19,8 @@ package net.sf.clirr.core; +import net.sf.clirr.core.internal.ExceptionUtil; + /** * An exception class representing a failure during checking of the * specified jar files. @@ -35,8 +37,9 @@ super(msg); } - public CheckerException(String msg, Throwable t) + public CheckerException(String msg, Throwable cause) { - super(msg, t); + super(msg); + ExceptionUtil.initCause(this, cause); } } Index: Checker.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/Checker.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- Checker.java 18 Jul 2004 00:59:56 -0000 1.3 +++ Checker.java 3 Sep 2004 23:04:48 -0000 1.4 @@ -43,6 +43,7 @@ import net.sf.clirr.core.internal.ClassChangeCheck; import net.sf.clirr.core.internal.CoIterator; import net.sf.clirr.core.internal.JavaClassNameComparator; +import net.sf.clirr.core.internal.ExceptionUtil; import org.apache.bcel.classfile.JavaClass; import org.apache.bcel.classfile.ClassParser; @@ -289,7 +290,7 @@ final IllegalArgumentException illegalArgumentException = new IllegalArgumentException( "Cannot create classloader with jar file " + jarFile); - illegalArgumentException.initCause(ex); + ExceptionUtil.initCause(illegalArgumentException, ex); throw illegalArgumentException; } } |
|
From: <lk...@us...> - 2004-09-03 23:04:57
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv21779/internal Added Files: ExceptionUtil.java Log Message: make code compilable on JDK 1.3 (exception chaining not available) --- NEW FILE --- ////////////////////////////////////////////////////////////////////////////// // Clirr: compares two versions of a java library for binary compatibility // Copyright (C) 2003 - 2004 Lars Kühne // // This library is free software; you can redistribute it and/or // modify it under the terms of the GNU Lesser General Public // License as published by the Free Software Foundation; either // version 2.1 of the License, or (at your option) any later version. // // This library is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public // License along with this library; if not, write to the Free Software // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA ////////////////////////////////////////////////////////////////////////////// package net.sf.clirr.core.internal; import java.lang.reflect.Method; /** * A helper class to initialize the cause of an exception. * * This allows Clirr to be compile time compatible with JDK 1.3 * at still taking advantage of the JDK 1.4 chained exceptions feature * if available. * * @author lkuehne */ public final class ExceptionUtil { /** Disallow instantiation. */ private ExceptionUtil() { } private static Method initCauseMethod; static { try { initCauseMethod = Throwable.class.getMethod("initCause", new Class[]{Throwable.class}); } catch (NoSuchMethodException e) { // we're on JDK < 1.4, no cause data will be available in Exception stacktraces initCauseMethod = null; } } /** * Initializes the chained exception if possible. * Does nothing if chained exceptions are not available on the * current JDK (1.3 or lower). * * @param t the resulting exception (high abstraction level) * @param cause the underlying cause of t (low abstraction level) */ public static void initCause(Throwable t, Throwable cause) { if (initCauseMethod == null) { return; } try { initCauseMethod.invoke(t, new Throwable[]{cause}); } catch (Exception e) { if (e instanceof RuntimeException) { throw (RuntimeException) e; } throw new RuntimeException("unable to initCause: " + e.toString()); } } } |
|
From: <lak...@t-...> - 2004-09-03 22:28:07
|
Arghhh - not fixed!
On JDK 1.3 something seems to work differently and the unit test fails.
So now I have a debugging session I can look forward to tomorrow morning :-)
Lars Kühne wrote:
> Fixed
>
> Lars Kühne wrote:
>
>> public class Example
>> {
>> private static void method(JComponent comp)
>> {
>> // yes, it is possible to define a class here...
>> class A1 extends MouseAdapter
>> {
>> }
>> comp.addMouseListener(new A1());
>> }
>> }
>>
>> This results in error 1002, which means that ScopeSelector was
>> "Unable to find information in class " +
>> enclosingClass.getClassName() + " referring back to nested class " +
>> jclassName"
>>
>> The reason is that the compiler mangles the classname for A1 into
>> Example$1A1, so the ScopeSelector gets confused by the classname 1A1
>> being different from the constant name A1 in the enclosing class.
>>
>> Hmmm - I'll try to figure it out tomorrow if nobody beats me to it...
>
|
|
From: <lk...@us...> - 2004-09-02 04:29:33
|
Update of /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv16409 Modified Files: EventMessages_de.properties Log Message: avoid english error message in the middle of german sentence Index: EventMessages_de.properties =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core/EventMessages_de.properties,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- EventMessages_de.properties 10 Jul 2004 13:37:26 -0000 1.1 +++ EventMessages_de.properties 2 Sep 2004 04:29:23 -0000 1.2 @@ -11,8 +11,8 @@ #----------------------------------------------------------------------------- m1000=Sichtbarkeit der Klasse wurde von {3} auf {4} erweitern m1001=Sichtbarkeit der Klasse wurde von {3} auf {4} eingeschränkt -m1002=Kann Klassen-Scope nicht bestimmen: {3} in der alten Version -m1003=Kann Klassen-Scope nicht bestimmen: {3} in der neuen Version +m1002=Kann Klassen-Scope in der alten Version nicht bestimmen: {3} +m1003=Kann Klassen-Scope in der neuen Version nicht bestimmen: {3} #----------------------------------------------------------------------------- # GenderChangeCheck messages |
|
From: <lak...@t-...> - 2004-09-02 04:22:45
|
Fixed
Lars Kühne wrote:
> public class Example
> {
> private static void method(JComponent comp)
> {
> // yes, it is possible to define a class here...
> class A1 extends MouseAdapter
> {
> }
> comp.addMouseListener(new A1());
> }
> }
>
> This results in error 1002, which means that ScopeSelector was "Unable
> to find information in class " + enclosingClass.getClassName() + "
> referring back to nested class " + jclassName"
>
> The reason is that the compiler mangles the classname for A1 into
> Example$1A1, so the ScopeSelector gets confused by the classname 1A1
> being different from the constant name A1 in the enclosing class.
>
> Hmmm - I'll try to figure it out tomorrow if nobody beats me to it...
|
|
From: <lk...@us...> - 2004-09-02 04:21:42
|
Update of /cvsroot/clirr/clirr/core/src/testinput/testlib-v2/testlib/scope In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15139/src/testinput/testlib-v2/testlib/scope Modified Files: ClassScopeChange.java Log Message: fixed ScopeSelector failure with named inner classes defined inside a method body Index: ClassScopeChange.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/testinput/testlib-v2/testlib/scope/ClassScopeChange.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ClassScopeChange.java 15 Jul 2004 17:06:30 -0000 1.1 +++ ClassScopeChange.java 2 Sep 2004 04:21:32 -0000 1.2 @@ -49,4 +49,11 @@ // private class becomes package static class D4 {} + + // unchanged scope of class defined inside method body + private void method1() + { + class E1 {}; + E1 e1 = new E1(); + } } |
|
From: <lk...@us...> - 2004-09-02 04:21:42
|
Update of /cvsroot/clirr/clirr/core/src/testinput/testlib-v1/testlib/scope In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15139/src/testinput/testlib-v1/testlib/scope Modified Files: ClassScopeChange.java Log Message: fixed ScopeSelector failure with named inner classes defined inside a method body Index: ClassScopeChange.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/testinput/testlib-v1/testlib/scope/ClassScopeChange.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ClassScopeChange.java 15 Jul 2004 17:06:30 -0000 1.1 +++ ClassScopeChange.java 2 Sep 2004 04:21:32 -0000 1.2 @@ -49,4 +49,11 @@ // private class becomes package private static class D4 {} -} \ No newline at end of file + + // unchanged scope of class defined inside method body + private void method1() + { + class E1 {}; + E1 e1 = new E1(); + } +} |
|
From: <lk...@us...> - 2004-09-02 04:21:42
|
Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15139/src/java/net/sf/clirr/core Modified Files: ScopeSelector.java Log Message: fixed ScopeSelector failure with named inner classes defined inside a method body Index: ScopeSelector.java =================================================================== RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/ScopeSelector.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- ScopeSelector.java 18 Jul 2004 01:06:10 -0000 1.3 +++ ScopeSelector.java 2 Sep 2004 04:21:32 -0000 1.4 @@ -18,16 +18,16 @@ ////////////////////////////////////////////////////////////////////////////// package net.sf.clirr.core; -import org.apache.bcel.classfile.JavaClass; +import org.apache.bcel.Constants; import org.apache.bcel.classfile.AccessFlags; import org.apache.bcel.classfile.Attribute; -import org.apache.bcel.classfile.InnerClasses; -import org.apache.bcel.classfile.InnerClass; +import org.apache.bcel.classfile.ConstantClass; import org.apache.bcel.classfile.ConstantPool; -import org.apache.bcel.classfile.Constant; import org.apache.bcel.classfile.ConstantUtf8; +import org.apache.bcel.classfile.InnerClass; +import org.apache.bcel.classfile.InnerClasses; +import org.apache.bcel.classfile.JavaClass; import org.apache.bcel.util.Repository; -import org.apache.bcel.Constants; /** * Selects zero or more java scope values (public, protected, package, @@ -332,8 +332,6 @@ // ok this is a nested class String jclassName = jclass.getClassName(); String enclosingClassName = jclassName.substring(0, dollarPos); - String jclassNestedName = jclassName.substring(dollarPos + 1); - Repository repo = jclass.getRepository(); JavaClass enclosingClass = repo.findClass(enclosingClassName); @@ -354,17 +352,18 @@ InnerClass[] icarray = ics.getInnerClasses(); for (int j = 0; j < icarray.length; ++j) { + // in the code below, instanceof checks should not be necessary + // before casting Constants because the classfile format ensures + // that instanceof would always be true InnerClass ic = icarray[j]; - int nameIndex = ic.getInnerNameIndex(); - - Constant nameconst = pool.getConstant(nameIndex); - if (nameconst instanceof ConstantUtf8) + int classIndex = ic.getInnerClassIndex(); + ConstantClass constClass = (ConstantClass) pool.getConstant(classIndex); + int nameIndex = constClass.getNameIndex(); + ConstantUtf8 nameconst = (ConstantUtf8) pool.getConstant(nameIndex); + String classname = nameconst.getBytes().replace('/', '.'); + if (jclassName.equals(classname)) { - String classname = ((ConstantUtf8) nameconst).getBytes(); - if (jclassNestedName.equals(classname)) - { - return getScope(ic.getInnerAccessFlags()); - } + return getScope(ic.getInnerAccessFlags()); } } } |
|
From: <lak...@t-...> - 2004-08-31 19:55:25
|
Lars Kühne wrote:
> Hi guys,
>
> Olympics are over, and I can start working on Open Source again :-)
>
> This week I'll try to do some field testing inside my company.
> Assuming that I won't find any serious bugs my goal is to release
> Clirr 0.4 (both core and maven) next weekend.
One of our classes at work had the following construct (simplified):
public class Example
{
private static void method(JComponent comp)
{
// yes, it is possible to define a class here...
class A1 extends MouseAdapter
{
}
comp.addMouseListener(new A1());
}
}
This results in error 1002, which means that ScopeSelector was "Unable
to find information in class " + enclosingClass.getClassName() + "
referring back to nested class " + jclassName"
The reason is that the compiler mangles the classname for A1 into
Example$1A1, so the ScopeSelector gets confused by the classname 1A1
being different from the constant name A1 in the enclosing class.
Hmmm - I'll try to figure it out tomorrow if nobody beats me to it...
Lars
|
|
From: Vincent M. <vma...@pi...> - 2004-08-31 07:18:51
|
Sounds good to me. Once it is delivered I'll do some in-house = preaching... :-) Thanks -Vincent > -----Original Message----- > From: cli...@li... [mailto:clirr-devel- > ad...@li...] On Behalf Of Lars K=FChne > Sent: mardi 31 ao=FBt 2004 06:25 > To: cli...@li... > Subject: [Clirr-devel] working towards release 0.4 >=20 > Hi guys, >=20 > Olympics are over, and I can start working on Open Source again :-) >=20 > This week I'll try to do some field testing inside my company. = Assuming > that I won't find any serious bugs my goal is to release Clirr 0.4 = (both > core and maven) next weekend. >=20 > Cheers, > Lars >=20 >=20 >=20 >=20 > ------------------------------------------------------- > This SF.Net email is sponsored by BEA Weblogic Workshop > FREE Java Enterprise J2EE developer tools! > Get your free copy of BEA WebLogic Workshop 8.1 today. > http://ads.osdn.com/?ad_id=3D5047&alloc_id=3D10808&op=3Dclick > _______________________________________________ > Clirr-devel mailing list > Cli...@li... > https://lists.sourceforge.net/lists/listinfo/clirr-devel |
|
From: Simon K. <si...@ec...> - 2004-08-31 05:32:09
|
On Tue, 2004-08-31 at 16:25, Lars K=FChne wrote: > Hi guys, >=20 > Olympics are over, and I can start working on Open Source again :-) >=20 > This week I'll try to do some field testing inside my company. Assuming= =20 > that I won't find any serious bugs my goal is to release Clirr 0.4 (bot= h=20 > core and maven) next weekend. Great. I look forward to it. Regards, Simon |
|
From: <lak...@t-...> - 2004-08-31 04:23:54
|
Hi guys, Olympics are over, and I can start working on Open Source again :-) This week I'll try to do some field testing inside my company. Assuming that I won't find any serious bugs my goal is to release Clirr 0.4 (both core and maven) next weekend. Cheers, Lars |
|
From: Vincent M. <vma...@pi...> - 2004-08-22 15:40:08
|
It does work for me too now. Not sure why it didn't work the first time =
(I
did type "maven dist" at the top level). Maybe there is an issue with
building everything in one go...
Thanks for your help
-Vincent
> -----Original Message-----
> From: cli...@li... [mailto:clirr-devel-
> ad...@li...] On Behalf Of Lars K=FChne
> Sent: dimanche 22 ao=FBt 2004 15:15
> To: cli...@li...
> Subject: Re: [Clirr-devel] running clirr on cactus
>=20
> I've added the old/newClassPath and for me it works:
>=20
> jakarta-cactus/framework> maven clirr
> __ __
> | \/ |__ _Apache__ ___
> | |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
> |_| |_\__,_|\_/\___|_||_| v. 1.0
>=20
> [...]
> [clirr] [ERROR] ERROR: org.apache.cactus.Cookie: Removed field
> ajc$tjp_0
> [clirr] [ERROR] ERROR: org.apache.cactus.Cookie: Removed field
> ajc$tjp_1
> [...]
> [clirr] [ERROR] ERROR:
> org.apache.cactus.util.ChainedRuntimeException: Removed field =
ajc$tjp_0
> [clirr] [ERROR] ERROR:
> org.apache.cactus.util.ChainedRuntimeException: Removed field =
ajc$tjp_1
> [clirr] [ERROR] ERROR: org.apache.cactus.util.log.LogAspect: Class
> org.apache.cactus.util.log.LogAspect removed
>=20
> BUILD FAILED
> File...... /home/lk/.maven/cache/clirr-maven-0.4-SNAPSHOT/plugin.jelly
> Element... clirr
> Line...... 113
> Column.... 46
> detected binary incompatible API changes
> Total time: 8 seconds
> Finished at: Sun Aug 22 15:07:28 CEST 2004
>=20
> I've commited my jelly changes to CVS. Maybe you have to update core =
and
> maven and rebuild everything to make it work?
>=20
> Gotta run,
> Lars
>=20
>=20
> Lars K=FChne wrote:
>=20
> > OK, I can now reproduce your problem. Thanks for guiding me through
> > the Cactus setup.
> >
> > Lars
> >
> > PS: Note that I have added Maven to the main navigation, as I have
> > sucessfully tested it on commons-collections and commons-logging, so
> > it seems that it "kinda works".
> >
> >
> > Vincent Massol wrote:
> >
> >> Hi Lars,
> >>
> >> I've tried adding the newClasspah and oldClasspath as follows in
> >> plugin.jelly:
> >>
> >> <clirr failOnWarning=3D"${clirr.fail.on.warning}"
> >> failOnError=3D"${clirr.fail.on.error}">
> >> <origFiles dir=3D"${clirr.baseline.destination.dir}"
> >> includes=3D"${clirr.baseline.destination.basename}"/>
> >> <newFiles dir=3D"${maven.build.dir}"
> >> includes=3D"${maven.final.name}.jar"/>
> >> <formatter type=3D"xml" outfile=3D"${clirr.report.file}"/>
> >>
> >> <newClassPath refid=3D"maven.dependency.classpath"/>
> >> <oldClassPath refid=3D"maven.dependency.classpath"/>
> >>
> >> </clirr>
> >> But I still get the same error.
> >>
> >> Here's what I do to run clirr on the cactus framework project:
> >>
> >> * cd to jakarta-cactus/framework
> >> * create a build.properties file and add the following to it:
> >>
> >> clirr.baseline.destination =3D C:/Documents and Settings/Vincent
> >> Massol/.maven/repository/cactus/jars/cactus-13-1.6.1.jar
> >>
> >> (i.e. the location of the previous version to compare with)
> >>
> >> * type "maven clirr"
> >>
> >> You're right, I need to sort out the organization. Actually Cactus
> >> does not
> >> really build with Maven yet (it's a work in progress which is not
> >> progressing much right now). But forcing the location of the base =
jar
> >> should
> >> work.
> >>
> >> Thanks
> >> -Vincent
> >>
> >>
> >>
> >
> >
> >
> > -------------------------------------------------------
> > SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank =
Media
> > 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
> > Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
> > http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
> > _______________________________________________
> > Clirr-devel mailing list
> > Cli...@li...
> > https://lists.sourceforge.net/lists/listinfo/clirr-devel
> >
>=20
>=20
>=20
> -------------------------------------------------------
> SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
> 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
> Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
> http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
> _______________________________________________
> Clirr-devel mailing list
> Cli...@li...
> https://lists.sourceforge.net/lists/listinfo/clirr-devel
|
|
From: <lak...@t-...> - 2004-08-22 13:11:14
|
I've added the old/newClassPath and for me it works:
jakarta-cactus/framework> maven clirr
__ __
| \/ |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
|_| |_\__,_|\_/\___|_||_| v. 1.0
[...]
[clirr] [ERROR] ERROR: org.apache.cactus.Cookie: Removed field ajc$tjp_0
[clirr] [ERROR] ERROR: org.apache.cactus.Cookie: Removed field ajc$tjp_1
[...]
[clirr] [ERROR] ERROR:
org.apache.cactus.util.ChainedRuntimeException: Removed field ajc$tjp_0
[clirr] [ERROR] ERROR:
org.apache.cactus.util.ChainedRuntimeException: Removed field ajc$tjp_1
[clirr] [ERROR] ERROR: org.apache.cactus.util.log.LogAspect: Class
org.apache.cactus.util.log.LogAspect removed
BUILD FAILED
File...... /home/lk/.maven/cache/clirr-maven-0.4-SNAPSHOT/plugin.jelly
Element... clirr
Line...... 113
Column.... 46
detected binary incompatible API changes
Total time: 8 seconds
Finished at: Sun Aug 22 15:07:28 CEST 2004
I've commited my jelly changes to CVS. Maybe you have to update core and
maven and rebuild everything to make it work?
Gotta run,
Lars
Lars Kühne wrote:
> OK, I can now reproduce your problem. Thanks for guiding me through
> the Cactus setup.
>
> Lars
>
> PS: Note that I have added Maven to the main navigation, as I have
> sucessfully tested it on commons-collections and commons-logging, so
> it seems that it "kinda works".
>
>
> Vincent Massol wrote:
>
>> Hi Lars,
>>
>> I've tried adding the newClasspah and oldClasspath as follows in
>> plugin.jelly:
>>
>> <clirr failOnWarning="${clirr.fail.on.warning}"
>> failOnError="${clirr.fail.on.error}">
>> <origFiles dir="${clirr.baseline.destination.dir}"
>> includes="${clirr.baseline.destination.basename}"/>
>> <newFiles dir="${maven.build.dir}"
>> includes="${maven.final.name}.jar"/>
>> <formatter type="xml" outfile="${clirr.report.file}"/>
>>
>> <newClassPath refid="maven.dependency.classpath"/>
>> <oldClassPath refid="maven.dependency.classpath"/>
>>
>> </clirr>
>> But I still get the same error.
>>
>> Here's what I do to run clirr on the cactus framework project:
>>
>> * cd to jakarta-cactus/framework
>> * create a build.properties file and add the following to it:
>>
>> clirr.baseline.destination = C:/Documents and Settings/Vincent
>> Massol/.maven/repository/cactus/jars/cactus-13-1.6.1.jar
>>
>> (i.e. the location of the previous version to compare with)
>>
>> * type "maven clirr"
>>
>> You're right, I need to sort out the organization. Actually Cactus
>> does not
>> really build with Maven yet (it's a work in progress which is not
>> progressing much right now). But forcing the location of the base jar
>> should
>> work.
>>
>> Thanks
>> -Vincent
>>
>>
>>
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
> 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
> Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
> http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
> _______________________________________________
> Clirr-devel mailing list
> Cli...@li...
> https://lists.sourceforge.net/lists/listinfo/clirr-devel
>
|
110 messages has been excluded from this view by a project administrator.
