clirr-devel — Discussion about the source code of Clirr

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core ClassFilter.java,NONE,1.1 Checker.java,1.4,1.5 ClassSelector.java,1.1,1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19003/src/java/net/sf/clirr/core

Modified Files:
	Checker.java ClassSelector.java 
Added Files:
	ClassFilter.java 
Log Message:
The Ant task now allows to exclude classes from compatibility checks via the 'apiclasses' subelement.

--- NEW FILE ---
package net.sf.clirr.core;

import org.apache.bcel.classfile.JavaClass;

/**
 * Created by IntelliJ IDEA.
 * User: lk
 * Date: Mar 6, 2005
 * Time: 3:56:35 PM
 * To change this template use Options | File Templates.
 */
public interface ClassFilter
{
    boolean isSelected(JavaClass clazz);
}

Index: Checker.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/Checker.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Checker.java	3 Sep 2004 23:04:48 -0000	1.4
+++ Checker.java	6 Mar 2005 17:01:35 -0000	1.5
@@ -157,7 +157,7 @@
     public void reportDiffs(
         File[] origJars, File[] newJars,
         ClassLoader origThirdPartyLoader, ClassLoader newThirdPartyLoader,
-        ClassSelector classSelector)
+        ClassFilter classSelector)
         throws CheckerException
     {
         if (classSelector == null)
@@ -188,7 +188,7 @@
      * which case all classes in the old and new jars are compared.
      */
     private static ClassSet createClassSet(
-        File[] jarFiles, ClassLoader thirdPartyClasses, ClassSelector classSelector)
+        File[] jarFiles, ClassLoader thirdPartyClasses, ClassFilter classSelector)
         throws CheckerException
     {
         if (classSelector == null)

Index: ClassSelector.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/ClassSelector.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ClassSelector.java	10 Jul 2004 13:37:26 -0000	1.1
+++ ClassSelector.java	6 Mar 2005 17:01:35 -0000	1.2
@@ -30,7 +30,7 @@
  *
  * @author Simon Kitching
  */
-public final class ClassSelector
+public final class ClassSelector implements ClassFilter
 {
     /** Class for implementing an enumeration. */
     public static final class Mode

[Clirr-devel] CVS: clirr/core/src/test/net/sf/clirr/core/internal/checks AbstractCheckTestCase.java,1.1,1.2 ClassModifierCheckTest.java,1.1,1.2 ClassScopeCheckTest.java,1.2,1.3

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19003/src/test/net/sf/clirr/core/internal/checks

Modified Files:
	AbstractCheckTestCase.java ClassModifierCheckTest.java 
	ClassScopeCheckTest.java 
Log Message:
The Ant task now allows to exclude classes from compatibility checks via the 'apiclasses' subelement.

Index: AbstractCheckTestCase.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/AbstractCheckTestCase.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- AbstractCheckTestCase.java	11 Jul 2004 10:29:24 -0000	1.1
+++ AbstractCheckTestCase.java	6 Mar 2005 17:01:35 -0000	1.2
@@ -5,6 +5,7 @@
 import net.sf.clirr.core.ClassSelector;
 import net.sf.clirr.core.ApiDifference;
 import net.sf.clirr.core.CheckerFactory;
+import net.sf.clirr.core.ClassFilter;
 import net.sf.clirr.core.internal.ClassChangeCheck;
 import org.apache.bcel.util.ClassSet;
 
@@ -50,7 +51,7 @@
     {
         TestDiffListener tdl = new TestDiffListener();
         Checker checker = CheckerFactory.createChecker(createCheck(tdl));
-        ClassSelector classSelector = createClassSelector();
+        ClassFilter classSelector = createClassSelector();
 
         checker.reportDiffs(
             getBaseLine(), getCurrent(),
@@ -70,7 +71,7 @@
      * to select different classes from the test jars should override this
      * method.
      */
-    protected ClassSelector createClassSelector()
+    protected ClassFilter createClassSelector()
     {
         // only check classes in the base "testlib" package of the jars
         ClassSelector classSelector = new ClassSelector(ClassSelector.MODE_IF);

Index: ClassModifierCheckTest.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/ClassModifierCheckTest.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ClassModifierCheckTest.java	11 Jul 2004 10:29:24 -0000	1.1
+++ ClassModifierCheckTest.java	6 Mar 2005 17:01:35 -0000	1.2
@@ -3,6 +3,7 @@
 import net.sf.clirr.core.internal.ClassChangeCheck;
 import net.sf.clirr.core.Severity;
 import net.sf.clirr.core.ClassSelector;
+import net.sf.clirr.core.ClassFilter;
 import net.sf.clirr.core.internal.checks.ClassModifierCheck;
 import net.sf.clirr.core.internal.checks.AbstractCheckTestCase;
 
@@ -25,7 +26,7 @@
         return new ClassModifierCheck(tdl);
     }
 
-    protected ClassSelector createClassSelector()
+    protected ClassFilter createClassSelector()
     {
         // only apply the check to classes in the testlib.modifiers package.
         ClassSelector classSelector = new ClassSelector(ClassSelector.MODE_IF);

Index: ClassScopeCheckTest.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/ClassScopeCheckTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ClassScopeCheckTest.java	16 Jul 2004 09:53:03 -0000	1.2
+++ ClassScopeCheckTest.java	6 Mar 2005 17:01:35 -0000	1.3
@@ -4,6 +4,7 @@
 import net.sf.clirr.core.Severity;
 import net.sf.clirr.core.ClassSelector;
 import net.sf.clirr.core.ScopeSelector;
+import net.sf.clirr.core.ClassFilter;
 import net.sf.clirr.core.internal.checks.ClassScopeCheck;
 import net.sf.clirr.core.internal.checks.AbstractCheckTestCase;
 
@@ -43,7 +44,7 @@
         return new ClassScopeCheck(tdl, scopeSelector);
     }
 
-    protected ClassSelector createClassSelector()
+    protected ClassFilter createClassSelector()
     {
         // only check the testlib/scope/ClassScopeChange class.
         ClassSelector classSelector = new ClassSelector(ClassSelector.MODE_IF);

[Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/ant PatternSetFilter.java,NONE,1.1 AntTask.java,1.3,1.4

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/ant
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19003/src/java/net/sf/clirr/ant

Modified Files:
	AntTask.java 
Added Files:
	PatternSetFilter.java 
Log Message:
The Ant task now allows to exclude classes from compatibility checks via the 'apiclasses' subelement.

--- NEW FILE ---
//////////////////////////////////////////////////////////////////////////////
// Clirr: compares two versions of a java library for binary compatibility
// Copyright (C) 2003 - 2004  Lars Kühne
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
//////////////////////////////////////////////////////////////////////////////

package net.sf.clirr.ant;

import net.sf.clirr.core.ClassFilter;

import java.util.List;
import java.io.File;

import org.apache.bcel.classfile.JavaClass;
import org.apache.tools.ant.types.selectors.SelectorUtils;
import org.apache.tools.ant.types.PatternSet;
import org.apache.tools.ant.Project;

/**
 * A ClassFilter that uses Ant PatternSets as the decision criteria.
 *
 * @author lkuehne
 */
class PatternSetFilter implements ClassFilter
{
    private final Project project;
    private final List patternSets;


    /**
     * Creates a new PatternSetFilter.
     * @param project the current Ant project
     * @param patternSets a List of Ant PatternSet objects
     */
    public PatternSetFilter(Project project, List patternSets)
    {
        this.project = project;
        this.patternSets = patternSets;
    }


    public boolean isSelected(JavaClass clazz)
    {
        // The patternset evaluation code below was copied from Apache Ant's Expand task.
        // I feel this code should be available as a library function inside Ant somewhere...
        String className = clazz.getClassName();
        String name = className.replace('.', '/');


        if (patternSets == null || patternSets.isEmpty())
        {
            return true;
        }

        boolean included = false;
        for (int i = 0; i < patternSets.size(); i++)
        {
            PatternSet p = (PatternSet) patternSets.get(i);
            p.getIncludePatterns(project);

            String[] incls = p.getIncludePatterns(project);
            if (incls == null || incls.length == 0)
            {
                // no include pattern implicitly means includes="**"
                incls = new String[] {"**"};
            }

            for (int w = 0; w < incls.length; w++)
            {
                String pattern = incls[w].replace('/', File.separatorChar)
                        .replace('\\', File.separatorChar);
                if (pattern.endsWith(File.separator))
                {
                    pattern += "**";
                }

                included = SelectorUtils.matchPath(pattern, name);
                if (included)
                {
                    break;
                }
            }

            if (!included)
            {
                break;
            }


            String[] excls = p.getExcludePatterns(project);
            if (excls != null)
            {
                for (int w = 0; w < excls.length; w++)
                {
                    String pattern = excls[w]
                            .replace('/', File.separatorChar)
                            .replace('\\', File.separatorChar);
                    if (pattern.endsWith(File.separator))
                    {
                        pattern += "**";
                    }
                    included = !(SelectorUtils.matchPath(pattern, name));
                    if (!included)
                    {
                        break;
                    }
                }
            }
        }
        System.out.println("included " + className + " = " + included);
        return included;
    }
}

Index: AntTask.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/ant/AntTask.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- AntTask.java	3 Sep 2004 23:05:07 -0000	1.3
+++ AntTask.java	6 Mar 2005 17:01:34 -0000	1.4
@@ -32,6 +32,8 @@
 import net.sf.clirr.core.CheckerException;
 import net.sf.clirr.core.PlainDiffListener;
 import net.sf.clirr.core.XmlDiffListener;
+import net.sf.clirr.core.ClassSelector;
+import net.sf.clirr.core.ClassFilter;
 import net.sf.clirr.core.internal.ExceptionUtil;
 
 import org.apache.tools.ant.BuildException;
@@ -40,6 +42,8 @@
 import org.apache.tools.ant.Task;
 import org.apache.tools.ant.types.FileSet;
 import org.apache.tools.ant.types.Path;
+import org.apache.tools.ant.types.PatternSet;
+import org.apache.bcel.classfile.JavaClass;
 
 
 /**
@@ -88,6 +92,25 @@
         }
     }
 
+    /**
+     * Class Filter that returns the logical "and" of two underlying class filters.
+     */
+    private static class CompoundClassFilter implements ClassFilter
+    {
+        private final ClassFilter patternSetFilter;
+        private final ClassFilter scopeSelector;
+
+        public CompoundClassFilter(ClassFilter patternSetFilter, ClassFilter scopeSelector)
+        {
+            this.patternSetFilter = patternSetFilter;
+            this.scopeSelector = scopeSelector;
+        }
+
+        public boolean isSelected(JavaClass clazz)
+        {
+            return patternSetFilter.isSelected(clazz) && scopeSelector.isSelected(clazz);
+        }
+    }
 
     private FileSet origFiles = null;
     private FileSet newFiles = null;
@@ -99,6 +122,7 @@
     private boolean failOnSrcError = true;
     private boolean failOnSrcWarning = false;
     private List formatters = new LinkedList();
+    private List patternSets = new LinkedList();
 
 
     public Path createNewClassPath()
@@ -186,6 +210,11 @@
         formatters.add(formatter);
     }
 
+    public void addApiClasses(PatternSet set)
+    {
+        patternSets.add(set);
+    }
+
     public void execute()
     {
         log("Running Clirr, built from tag $Name$", Project.MSG_VERBOSE);
@@ -266,7 +295,7 @@
         try
         {
             checker.reportDiffs(
-                origJars, newJars, origThirdPartyLoader, newThirdPartyLoader, null);
+                origJars, newJars, origThirdPartyLoader, newThirdPartyLoader, buildClassFilter());
         }
         catch (CheckerException ex)
         {
@@ -286,6 +315,13 @@
         }
     }
 
+    private ClassFilter buildClassFilter()
+    {
+        final PatternSetFilter patternSetFilter = new PatternSetFilter(getProject(), patternSets);
+        final ClassFilter scopeSelector = new ClassSelector(ClassSelector.MODE_UNLESS);
+        return new CompoundClassFilter(patternSetFilter, scopeSelector);
+    }
+
 
     private ClassLoader createClasspathLoader(Path classpath)
     {
@@ -328,4 +364,5 @@
         }
         return ret;
     }
+
 }

[Clirr-devel] CVS: clirr/core/src/conf/net/sf/clirr/core EventMessages_de.properties,1.2,1.3

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19606

Modified Files:
	EventMessages_de.properties 
Log Message:
fixed typo

Index: EventMessages_de.properties
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/conf/net/sf/clirr/core/EventMessages_de.properties,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- EventMessages_de.properties	2 Sep 2004 04:29:23 -0000	1.2
+++ EventMessages_de.properties	14 Dec 2004 19:43:23 -0000	1.3
@@ -9,7 +9,7 @@
 #-----------------------------------------------------------------------------
 # ClassScopeCheck messages
 #-----------------------------------------------------------------------------
-m1000=Sichtbarkeit der Klasse wurde von {3} auf {4} erweitern
+m1000=Sichtbarkeit der Klasse wurde von {3} auf {4} erweitert
 m1001=Sichtbarkeit der Klasse wurde von {3} auf {4} eingeschränkt
 m1002=Kann Klassen-Scope in der alten Version nicht bestimmen: {3}
 m1003=Kann Klassen-Scope in der neuen Version nicht bestimmen: {3}

Re: [Clirr-devel] Clirr Maven plugin

[<lak...@t-...>]

Yes, it has been released and is available at 
https://sourceforge.net/project/showfiles.php?group_id=89627

The missing link is the result of my incompetence with the Maven 
deployment goals, see my earlier postings on the list.

Lars


Vincent Massol wrote:

>Hi Martin,
>
>I don't know if it has been released (Lars?). You can probably build it from
>sources:
>- CVS checkout
>- "maven plugin:install" from the plugin directory
>
>Thanks
>-Vincent
>
>  
>
>>-----Original Message-----
>>From: cli...@li... [mailto:clirr-devel-
>>ad...@li...] On Behalf Of Martin Cooper
>>Sent: lundi 22 novembre 2004 01:17
>>To: cli...@li...
>>Subject: [Clirr-devel] Clirr Maven plugin
>>
>>The web site documents a Maven plugin for running Clirr, and even includes
>>a link to download it manually. However, it doesn't seem to exist, at
>>least on ibiblio, where the link points.
>>
>>Can someone tell me where I can find it?
>>
>>Thanks!
>>
>>(BTW, I'm not subscribed to the list, so I'd appreciate being included
>>directly in any response.)
>>
>>--
>>Martin Cooper
>>
>>    
>>

RE: [Clirr-devel] Clirr Maven plugin

[Vincent M. <vma...@pi...>]

Hi Martin,

I don't know if it has been released (Lars?). You can probably build it from
sources:
- CVS checkout
- "maven plugin:install" from the plugin directory

Thanks
-Vincent

> -----Original Message-----
> From: cli...@li... [mailto:clirr-devel-
> ad...@li...] On Behalf Of Martin Cooper
> Sent: lundi 22 novembre 2004 01:17
> To: cli...@li...
> Subject: [Clirr-devel] Clirr Maven plugin
> 
> The web site documents a Maven plugin for running Clirr, and even includes
> a link to download it manually. However, it doesn't seem to exist, at
> least on ibiblio, where the link points.
> 
> Can someone tell me where I can find it?
> 
> Thanks!
> 
> (BTW, I'm not subscribed to the list, so I'd appreciate being included
> directly in any response.)
> 
> --
> Martin Cooper
> 
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://productguide.itmanagersjournal.com/
> _______________________________________________
> Clirr-devel mailing list
> Cli...@li...
> https://lists.sourceforge.net/lists/listinfo/clirr-devel

Re: [Clirr-devel] Clirr Maven plugin

[Simon K. <si...@ec...>]

On Mon, 2004-11-22 at 13:16, Martin Cooper wrote:
> The web site documents a Maven plugin for running Clirr, and even includes 
> a link to download it manually. However, it doesn't seem to exist, at 
> least on ibiblio, where the link points.
> 
> Can someone tell me where I can find it?

Hi Martin,

I'm not sure what the situation is with the Maven plugin. I see from a
posting on the jakarta-dev list that you've managed to run Clirr anyway
though:
  http://cvs.apache.org/~martinc/io/

I'll try to track down the maven plugin and let you know...

Regards,

Simon

[Clirr-devel] Clirr Maven plugin

[Martin C. <ma...@ap...>]

The web site documents a Maven plugin for running Clirr, and even includes 
a link to download it manually. However, it doesn't seem to exist, at 
least on ibiblio, where the link points.

Can someone tell me where I can find it?

Thanks!

(BTW, I'm not subscribed to the list, so I'd appreciate being included 
directly in any response.)

--
Martin Cooper

RE: [Clirr-devel] Swamped

[Vincent M. <vma...@pi...>]

Hi Lars and Simon,

There are actually several plugins in Maven dedicated to deployments:
- scm plugin
- dist plugin
- artifact (e.g. jar:deploy, war:deploy, or using directly the =
<artifact>
tag)
- site:deploy
- release plugin

The release should not be used as deprecated. The scm plugin is ok but =
is
quite tied to how deploying plugins in Maven works, that is:
- it works only with CVS
- it assumes there is a changes.xml file that describe changes
- it assumes we're using the <versions> tag

I think this is all fine for us and we should be able to use the scm =
plugin.
Here's what it does:
- modify the project.xml and changes.xml to swap a SNAPSHOT version and
replace it with the final version name (it also reformats the =
changes.xml
file)
- apply a CVS tag
- checkout a fresh copy of the tag and build the project
- upload the artifact to the Maven remote repo

What I don't know is whether it works with a  multiproject or not. I've
never tried it and it's not used for multiprojects in Maven land. But =
who
knows... In any case I think it would require minimal changes to make it
work for multiprojects.

The artifact plugin works very fine and we can use it easily. It doesn't =
do
all the fancy stuff the scm plugin does: it concentrates on deploying a
built artifact to a Maven remote repo.

The dist plugin does not currently work for multiprojects but that =
should be
easy to fix. It builds zips and targz of the project and upload source =
and
binary distributions to a maven remote repo. It's complementary to the =
scm
plugin which only releases artifacts, not complete distribution.

Then there is the NSIS plugin which generates installers for a project. =
I
haven't used it yet.

Hope it helps,
-Vincent

> -----Original Message-----
> From: cli...@li... [mailto:clirr-devel-
> ad...@li...] On Behalf Of "Lars K=FChne"
> Sent: mardi 9 novembre 2004 21:10
> To: cli...@li...
> Subject: [Clirr-devel] Swamped
>=20
> Hi guys,
>=20
> sorry for not responding earlier. I have been assigned additional =
tasks
> inside my company, so unfortunately I currently can't devote any time =
to
> Clirr. I hope I can get my head above sealevel early next year or so.
>=20
> Meanwhile if one of you guys could can change the build process to use
> the maven scm plugin (like Vincent suggested in another email) that
> would be most welcome. You should have all permissions neccessary to
> update the website - if not, please let me know.
>=20
> Sorry,
> Lars
>=20
>=20
> Vincent Massol wrote:
>=20
> >Hi Lars,
> >
> >Sorry for the delay in answering. There is actually a procedure to =
follow
> to
> >get the jars on ibiblio. Here's the procedure:
> >
> >http://maven.apache.org/repository-upload.html
> >
> >You'll need to create 2 bundles:
> >- one for the core jar
> >- one for the maven plugin. You'll need to specify that for the =
plugin
> it's
> >meant to go in http://www.ibiblio.org/maven/clirr/plugins and not in
> >http://www.ibiblio.org/maven/clirr/jars
> >
> >Thanks
> >-Vincent
> >
> >
> >
> >>-----Original Message-----
> >>From: cli...@li... [mailto:clirr-devel-
> >>ad...@li...] On Behalf Of Lars K=FChne
> >>Sent: dimanche 5 septembre 2004 20:53
> >>To: cli...@li...
> >>Subject: [Clirr-devel] files for 0.4 have been released on =
sourceforge
> >>
> >>Hi,
> >>
> >>I have made file releases for version 0.4 available on the =
sourceforge
> >>download pages - thanks guys, without you this release would not =
have
> >>been possible!
> >>
> >>I had to create the binary release files of 'core' manually, because =
I
> >>couldn't find a way to include the uberjar in the archives that are
> >>built by dist:build-bin. It would be really great if you could test =
the
> >>release files a bit before we publish the news to a wider audience -
> >>just to make sure I didn't make any stupid mistake.
> >>
> >>Vincent, can you arrange things on ibiblio, so it's as easy as =
possible
> >>to start working with the Maven plugin?
> >>
> >>Thanks,
> >>Lars
> >>
> >>
> >>
>=20
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Sybase ASE Linux Express Edition - download now for FREE
> LinuxWorld Reader's Choice Award Winner for best database on Linux.
> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick
> _______________________________________________
> Clirr-devel mailing list
> Cli...@li...
> https://lists.sourceforge.net/lists/listinfo/clirr-devel

Re: [Clirr-devel] Swamped

[Simon K. <si...@ec...>]

Hi Lars,

I know how you feel - life has been busy for me too. And of course it's
summer for me, so spending evenings at the keyboard is not so tempting..

I will have a go at this if I get time, though that is probably not
likely soon. I definitely will have lots of free time from mid-january
on, though, and definitely intend to get back into some Clirr work. If
you've got some free time around the same date that would be cool..

Cheers,

Simon

On Wed, 2004-11-10 at 09:10, Lars K=FChne wrote:
> Hi guys,
>=20
> sorry for not responding earlier. I have been assigned additional tasks=
=20
> inside my company, so unfortunately I currently can't devote any time t=
o=20
> Clirr. I hope I can get my head above sealevel early next year or so.
>=20
> Meanwhile if one of you guys could can change the build process to use=20
> the maven scm plugin (like Vincent suggested in another email) that=20
> would be most welcome. You should have all permissions neccessary to=20
> update the website - if not, please let me know.
>=20
> Sorry,
> Lars
>=20
>=20
> Vincent Massol wrote:
>=20
> >Hi Lars,
> >
> >Sorry for the delay in answering. There is actually a procedure to fol=
low to
> >get the jars on ibiblio. Here's the procedure:
> >
> >http://maven.apache.org/repository-upload.html
> >
> >You'll need to create 2 bundles:
> >- one for the core jar
> >- one for the maven plugin. You'll need to specify that for the plugin=
 it's
> >meant to go in http://www.ibiblio.org/maven/clirr/plugins and not in
> >http://www.ibiblio.org/maven/clirr/jars
> >
> >Thanks
> >-Vincent
> >
> > =20
> >
> >>-----Original Message-----
> >>From: cli...@li... [mailto:clirr-devel-
> >>ad...@li...] On Behalf Of Lars K=FChne
> >>Sent: dimanche 5 septembre 2004 20:53
> >>To: cli...@li...
> >>Subject: [Clirr-devel] files for 0.4 have been released on sourceforg=
e
> >>
> >>Hi,
> >>
> >>I have made file releases for version 0.4 available on the sourceforg=
e
> >>download pages - thanks guys, without you this release would not have
> >>been possible!
> >>
> >>I had to create the binary release files of 'core' manually, because =
I
> >>couldn't find a way to include the uberjar in the archives that are
> >>built by dist:build-bin. It would be really great if you could test t=
he
> >>release files a bit before we publish the news to a wider audience -
> >>just to make sure I didn't make any stupid mistake.
> >>
> >>Vincent, can you arrange things on ibiblio, so it's as easy as possib=
le
> >>to start working with the Maven plugin?
> >>
> >>Thanks,
> >>Lars
> >>
> >>   =20
> >>
>=20
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Sybase ASE Linux Express Edition - download now for FREE
> LinuxWorld Reader's Choice Award Winner for best database on Linux.
> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick
> _______________________________________________
> Clirr-devel mailing list
> Cli...@li...
> https://lists.sourceforge.net/lists/listinfo/clirr-devel
>=20

[Clirr-devel] Swamped

[<lak...@t-...>]

Hi guys,

sorry for not responding earlier. I have been assigned additional tasks 
inside my company, so unfortunately I currently can't devote any time to 
Clirr. I hope I can get my head above sealevel early next year or so.

Meanwhile if one of you guys could can change the build process to use 
the maven scm plugin (like Vincent suggested in another email) that 
would be most welcome. You should have all permissions neccessary to 
update the website - if not, please let me know.

Sorry,
Lars


Vincent Massol wrote:

>Hi Lars,
>
>Sorry for the delay in answering. There is actually a procedure to follow to
>get the jars on ibiblio. Here's the procedure:
>
>http://maven.apache.org/repository-upload.html
>
>You'll need to create 2 bundles:
>- one for the core jar
>- one for the maven plugin. You'll need to specify that for the plugin it's
>meant to go in http://www.ibiblio.org/maven/clirr/plugins and not in
>http://www.ibiblio.org/maven/clirr/jars
>
>Thanks
>-Vincent
>
>  
>
>>-----Original Message-----
>>From: cli...@li... [mailto:clirr-devel-
>>ad...@li...] On Behalf Of Lars Kühne
>>Sent: dimanche 5 septembre 2004 20:53
>>To: cli...@li...
>>Subject: [Clirr-devel] files for 0.4 have been released on sourceforge
>>
>>Hi,
>>
>>I have made file releases for version 0.4 available on the sourceforge
>>download pages - thanks guys, without you this release would not have
>>been possible!
>>
>>I had to create the binary release files of 'core' manually, because I
>>couldn't find a way to include the uberjar in the archives that are
>>built by dist:build-bin. It would be really great if you could test the
>>release files a bit before we publish the news to a wider audience -
>>just to make sure I didn't make any stupid mistake.
>>
>>Vincent, can you arrange things on ibiblio, so it's as easy as possible
>>to start working with the Maven plugin?
>>
>>Thanks,
>>Lars
>>
>>    
>>

RE: [Clirr-devel] files for 0.4 have been released on sourceforge

[Vincent M. <vm...@pi...>]

Hi Lars,

Sorry for the delay in answering. There is actually a procedure to =
follow to
get the jars on ibiblio. Here's the procedure:

http://maven.apache.org/repository-upload.html

You'll need to create 2 bundles:
- one for the core jar
- one for the maven plugin. You'll need to specify that for the plugin =
it's
meant to go in http://www.ibiblio.org/maven/clirr/plugins and not in
http://www.ibiblio.org/maven/clirr/jars

Thanks
-Vincent

> -----Original Message-----
> From: cli...@li... [mailto:clirr-devel-
> ad...@li...] On Behalf Of Lars K=FChne
> Sent: dimanche 5 septembre 2004 20:53
> To: cli...@li...
> Subject: [Clirr-devel] files for 0.4 have been released on sourceforge
>=20
> Hi,
>=20
> I have made file releases for version 0.4 available on the sourceforge
> download pages - thanks guys, without you this release would not have
> been possible!
>=20
> I had to create the binary release files of 'core' manually, because I
> couldn't find a way to include the uberjar in the archives that are
> built by dist:build-bin. It would be really great if you could test =
the
> release files a bit before we publish the news to a wider audience -
> just to make sure I didn't make any stupid mistake.
>=20
> Vincent, can you arrange things on ibiblio, so it's as easy as =
possible
> to start working with the Maven plugin?
>=20
> Thanks,
> Lars
>=20
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_id=3D5047&alloc_id=3D10808&op=3Dclick
> _______________________________________________
> Clirr-devel mailing list
> Cli...@li...
> https://lists.sourceforge.net/lists/listinfo/clirr-devel

RE: [Clirr-devel] deploy trouble

[Vincent M. <vma...@pi...>]

> -----Original Message-----
> From: cli...@li... [mailto:clirr-devel-
> ad...@li...] On Behalf Of Lars K=FChne
> Sent: lundi 13 septembre 2004 07:03
> To: cli...@li...
> Subject: Re: [Clirr-devel] deploy trouble
>=20
> Vincent Massol wrote:
>=20
> >The default Maven install is configured to use ibiblio. It only takes =
a
> few
> >seconds to add a second repository but the user has to know how to do =
it.
> >
> >Thus in term of user experience, getting it on ibiblio is best. =
However
> this
> >takes a bit more of time as we have to open a JIRA issue and wait for =
a
> >Maven committer to process it.
> >
> >
>=20
> OK, then let's put it up on sf and we can additionally upload to =
ibiblio
> when you have time to enhance the user experience.

ok

>=20
> This means that we need to write down the procedure for installing a
> second repository in our own docs. Is
>=20
> =
maven.repo.remote=3Dhttp://www.ibiblio.org/maven,http://clirr.sorceforge.=
net
> /repository
>=20
>=20
> in the user's project.properties really all that is needed?

Yes

[snip]

-Vincent

Re: [Clirr-devel] deploy trouble

[<lak...@t-...>]

Vincent Massol wrote:

>The default Maven install is configured to use ibiblio. It only takes a few
>seconds to add a second repository but the user has to know how to do it.
>
>Thus in term of user experience, getting it on ibiblio is best. However this
>takes a bit more of time as we have to open a JIRA issue and wait for a
>Maven committer to process it.
>  
>

OK, then let's put it up on sf and we can additionally upload to ibiblio 
when you have time to enhance the user experience.

This means that we need to write down the procedure for installing a 
second repository in our own docs. Is

maven.repo.remote=http://www.ibiblio.org/maven,http://clirr.sorceforge.net/repository 


in the user's project.properties really all that is needed?

>>Maybe we should discuss that on irc to get it sorted out quickly. I'll
>>be on #clirr most of this afternoon. If you can't make it, let me know
>>when you're available ...
>>    
>>
>
>Sorry I'm not available right now (I don't have an ADSL connection anymore
>at home... :-( I'm fighting to get one but the ISPs are overwhelmed in
>France and they can't satisfy user's subscriptions...). I'll be traveling to
>India the whole week so I'm not sure I'll have the time either but I'll try
>at least to answer some emails.
>
>  
>

OK.

>>> [...]
>>
>>Currently reading the scm docs - looks good. (BTW: The Maven docs really
>>could be clearer about what is recommended, which modules are
>>deprecated, etc.)
>>    
>>
>
>Yep. The Maven team needs help on the doco side. When you say "reading the
>scm docs", you mean reading the plugin.jelly, right? ;-)
>
>  
>

:-)

Lars

RE: [Clirr-devel] deploy trouble

[Vincent M. <vma...@pi...>]

> -----Original Message-----
> From: cli...@li... [mailto:clirr-devel-
> ad...@li...] On Behalf Of Lars K=FChne
> Sent: dimanche 12 septembre 2004 14:22
> To: cli...@li...
> Subject: Re: [Clirr-devel] deploy trouble
>=20

[snip]

> >For the binaries, we need to check it. I have never done it. I always
> deploy
> >to the Maven repositories using the scm plugin (see the reference =
page on
> >the Maven web site for deploying plugins). I think we can use that if =
you
> >wish to deploy the binaries to SF. That said we'll need to decide =
whether
> we
> >want them on ibiblio or on SF...
> >
> >
> >
>=20
> What provides the best user experience for the users of the maven
> plugin? Should we upload to both? What are the =
advantages/disadvantages
> of each?

The default Maven install is configured to use ibiblio. It only takes a =
few
seconds to add a second repository but the user has to know how to do =
it.

Thus in term of user experience, getting it on ibiblio is best. However =
this
takes a bit more of time as we have to open a JIRA issue and wait for a
Maven committer to process it.

>=20
> Maybe we should discuss that on irc to get it sorted out quickly. I'll
> be on #clirr most of this afternoon. If you can't make it, let me know
> when you're available ...

Sorry I'm not available right now (I don't have an ADSL connection =
anymore
at home... :-( I'm fighting to get one but the ISPs are overwhelmed in
France and they can't satisfy user's subscriptions...). I'll be =
traveling to
India the whole week so I'm not sure I'll have the time either but I'll =
try
at least to answer some emails.

>=20
> >>    * If I use maven.repo.list (from the artifact plugin) instead of =
the
> >>      'legacy deploy mode', it seems I need to put my sourceforge
> >>      password in a file that is publically accessible via CVS ?!?
> >>
> >>
> >
> >You should use the scm plugin (after reading the doc on maven site as =
it
> >does quite a lot of things that needs to be understood).
> >
> >
> >
>=20
> Currently reading the scm docs - looks good. (BTW: The Maven docs =
really
> could be clearer about what is recommended, which modules are
> deprecated, etc.)

Yep. The Maven team needs help on the doco side. When you say "reading =
the
scm docs", you mean reading the plugin.jelly, right? ;-)

-Vincent

Re: [Clirr-devel] deploy trouble

[<lak...@t-...>]

Vincent Massol wrote:

>Hi Lars,
>  
>
>>[...]
>>    
>>
>>Questions:
>>
>>    * Where can I tell Maven to use the unix group name 'clirr' or
>>      prevent the chgrp call completely?
>>    
>>
>
>Hmm... I don't know anything about the dist plugin but I wouldn't use it if
>I were you. If you wish to update the web site, you should use the
>"site:deploy" goal.
>
>  
>

Yes, I did that and it worked.

>For the binaries, we need to check it. I have never done it. I always deploy
>to the Maven repositories using the scm plugin (see the reference page on
>the Maven web site for deploying plugins). I think we can use that if you
>wish to deploy the binaries to SF. That said we'll need to decide whether we
>want them on ibiblio or on SF...
>
>  
>

What provides the best user experience for the users of the maven 
plugin? Should we upload to both? What are the advantages/disadvantages 
of each?

Maybe we should discuss that on irc to get it sorted out quickly. I'll 
be on #clirr most of this afternoon. If you can't make it, let me know 
when you're available ...

>>    * If I use maven.repo.list (from the artifact plugin) instead of the
>>      'legacy deploy mode', it seems I need to put my sourceforge
>>      password in a file that is publically accessible via CVS ?!?
>>    
>>
>
>You should use the scm plugin (after reading the doc on maven site as it
>does quite a lot of things that needs to be understood).
>
>  
>

Currently reading the scm docs - looks good. (BTW: The Maven docs really 
could be clearer about what is recommended, which modules are 
deprecated, etc.)

Thanks,
Lars

RE: [Clirr-devel] deploy trouble

[Vincent M. <vma...@pi...>]

Hi Lars,

> -----Original Message-----
> From: cli...@li... [mailto:clirr-devel-
> ad...@li...] On Behalf Of Lars K=FChne
> Sent: dimanche 5 septembre 2004 17:33
> To: cli...@li...
> Subject: [Clirr-devel] deploy trouble
>=20
> Hi,
>=20
> I have updated our web site with the 0.4 docs, but I'm getting errors
> when I try to deploy the binaries:
>=20
>  > cd core; maven -Dmaven.username=3Dlkuehne dist:deploy;
>=20
> [...]
> dist:deploy-bin:
>     [echo] maven.repo.list is not set - using legacy deploy mode
>     [echo] DEPRECATED: use of deploy:artifact tag and the legacy =
deploy
> method are deprecated
>     [echo]
>         Copying project.xml to the
> /home/groups/c/cl/clirr/htdocs/builds//clirr/poms on =
shell.sourceforge.net
>=20
>     [echo]
>           Executing [...]; chgrp maven clirr-core-0.4.pom [...]
>=20
>     [exec] chgrp: changing group of `clirr-core-0.4.pom': Operation =
not
> permitted
>=20
> BUILD FAILED
>=20
>=20
> Questions:
>=20
>     * Where can I tell Maven to use the unix group name 'clirr' or
>       prevent the chgrp call completely?

Hmm... I don't know anything about the dist plugin but I wouldn't use it =
if
I were you. If you wish to update the web site, you should use the
"site:deploy" goal.

For the binaries, we need to check it. I have never done it. I always =
deploy
to the Maven repositories using the scm plugin (see the reference page =
on
the Maven web site for deploying plugins). I think we can use that if =
you
wish to deploy the binaries to SF. That said we'll need to decide =
whether we
want them on ibiblio or on SF...

>     * If I use maven.repo.list (from the artifact plugin) instead of =
the
>       'legacy deploy mode', it seems I need to put my sourceforge
>       password in a file that is publically accessible via CVS ?!?

You should use the scm plugin (after reading the doc on maven site as it
does quite a lot of things that needs to be understood).

Thanks
-Vincent

[Clirr-devel] [ clirr-Feature Requests-1022920 ] Ant Task should work with uberjar

[SourceForge.net <no...@so...>]

Feature Requests item #1022920, was opened at 2004-09-06 09:32
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1022920&group_id=89627

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Lars Kühne (lkuehne)
Assigned to: Lars Kühne (lkuehne)
Summary: Ant Task should work with uberjar

Initial Comment:
It should be possible to use the uberjar in the
taskdef, but that currently does not work because of
the way the uberjar is built. Instead the user has to
fiddle around with bcel and commons* individually.

Instead of adding the individual jars and then doing
classloader magic it would be a lot easier to simply
unpack the dependencies and jar the required classes,
similar to how we generate checkstyle-all.jar in the
checkstyle project.

When doing this, note that ant.jar should not be
included in the uberjar, as it is not required by the
cli frontend nor by the ant task (which should use the
classes provided by the ant runtime environment).
Removing classworlds and ant from the uberjar will
drastically reduce the size of the uberjar.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=590802&aid=1022920&group_id=89627

[Clirr-devel] files for 0.4 have been released on sourceforge

[<lak...@t-...>]

Hi,

I have made file releases for version 0.4 available on the sourceforge 
download pages - thanks guys, without you this release would not have 
been possible!

I had to create the binary release files of 'core' manually, because I 
couldn't find a way to include the uberjar in the archives that are 
built by dist:build-bin. It would be really great if you could test the 
release files a bit before we publish the news to a wider audience - 
just to make sure I didn't make any stupid mistake.

Vincent, can you arrange things on ibiblio, so it's as easy as possible 
to start working with the Maven plugin?

Thanks,
Lars

[Clirr-devel] build multiproject source release - how?

[<lak...@t-...>]

Hi,

as with earlier releases I'd like to provide a source release as well.

It doesn't make much sense to release the sources for the subprojects 
individually (i.e. dist:build-src for each subproject) because they will 
not compile without the toplevel project.xml.

Is there sth. like a multiproject:build-src, i.e. a goal that generates 
a zip file that contains the whole source tree (including the subprojects)?

For now I can simply do a fresh "cvs export" and zip up the results, but 
if Maven provides a simpler way to do it I'd love to hear about it.

Thanks,
Lars

[Clirr-devel] deploy trouble

[<lak...@t-...>]

Hi,

I have updated our web site with the 0.4 docs, but I'm getting errors 
when I try to deploy the binaries:

 > cd core; maven -Dmaven.username=lkuehne dist:deploy;

[...]
dist:deploy-bin:
    [echo] maven.repo.list is not set - using legacy deploy mode
    [echo] DEPRECATED: use of deploy:artifact tag and the legacy deploy 
method are deprecated
    [echo]
        Copying project.xml to the 
/home/groups/c/cl/clirr/htdocs/builds//clirr/poms on shell.sourceforge.net

    [echo]
          Executing [...]; chgrp maven clirr-core-0.4.pom [...]

    [exec] chgrp: changing group of `clirr-core-0.4.pom': Operation not 
permitted

BUILD FAILED


Questions:

    * Where can I tell Maven to use the unix group name 'clirr' or
      prevent the chgrp call completely?
    * If I use maven.repo.list (from the artifact plugin) instead of the
      'legacy deploy mode', it seems I need to put my sourceforge
      password in a file that is publically accessible via CVS ?!?

/Lars

[Clirr-devel] CVS: clirr maven.xml,1.4,1.5

[<lk...@us...>]

Update of /cvsroot/clirr/clirr
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23165

Modified Files:
	maven.xml 
Log Message:
enable standard goal to deploy website

Index: maven.xml
===================================================================
RCS file: /cvsroot/clirr/clirr/maven.xml,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- maven.xml	5 Sep 2004 11:45:31 -0000	1.4
+++ maven.xml	5 Sep 2004 13:52:56 -0000	1.5
@@ -12,6 +12,11 @@
 

   <goal name="dist-site" prereqs="dist,multiproject:site"/>

 

+  <goal name="site:deploy">

+    <attainGoal name="multiproject:site"/>

+    <attainGoal name="site:${maven.site.deploy.method}deploy"/>

+  </goal>

+

   <preGoal name="clean">

     <attainGoal name="multiproject:clean"/>

   </preGoal>

[Clirr-devel] CVS: clirr/maven project.xml,1.1,1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/maven
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv17736

Modified Files:
	project.xml 
Log Message:
prepare for release 0.4

Index: project.xml
===================================================================
RCS file: /cvsroot/clirr/clirr/maven/project.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- project.xml	15 Jul 2004 13:34:22 -0000	1.1
+++ project.xml	5 Sep 2004 13:17:25 -0000	1.2
@@ -8,7 +8,7 @@
   <!-- Note: Although we inherit from project.xml, we still cannot 
   	   remove the <currentVersion> tag as this project.xml is parsed at 
   	   runtime whenever our plugin is called. -->
-  <currentVersion>0.4-SNAPSHOT</currentVersion>
+  <currentVersion>0.4</currentVersion>
 
   <package>net.sf.clirr.maven</package>
   <description>Maven plugin for Clirr</description>

[Clirr-devel] CVS: clirr/core/xdocs changes.xml,1.2,1.3

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/core/xdocs
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15428/core/xdocs

Modified Files:
	changes.xml 
Log Message:
prepare for release 0.4

Index: changes.xml
===================================================================
RCS file: /cvsroot/clirr/clirr/core/xdocs/changes.xml,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- changes.xml	18 Jul 2004 01:13:44 -0000	1.2
+++ changes.xml	5 Sep 2004 13:03:07 -0000	1.3
@@ -7,7 +7,7 @@
   </properties>
   <body>
 
-    <release version="0.4-SNAPSHOT" date="in CVS">
+    <release version="0.4" date="2004-09-05">
         <action dev="lkuehne" type="add" due-to="skitching">
             Improved change messages if field accessibility is weakened/strengthened.
         </action>

[Clirr-devel] CVS: clirr project.xml,1.24,1.25

[<lk...@us...>]

Update of /cvsroot/clirr/clirr
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15428

Modified Files:
	project.xml 
Log Message:
prepare for release 0.4

Index: project.xml
===================================================================
RCS file: /cvsroot/clirr/clirr/project.xml,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- project.xml	15 Jul 2004 13:36:54 -0000	1.24
+++ project.xml	5 Sep 2004 13:03:07 -0000	1.25
@@ -14,7 +14,7 @@
 
   <!-- The version of the project under development, e.g.
        1.1, 1.2, 2.0-dev -->
-  <currentVersion>0.4-SNAPSHOT</currentVersion>
+  <currentVersion>0.4</currentVersion>
 
   <!-- details about the organization that 'owns' the project -->
   <organization>
@@ -70,7 +70,7 @@
     <version>
       <id>0.4</id>
       <name>0.4</name>
-      <tag>HEAD</tag>
+      <tag>RELEASE_CLIRR_0_4</tag>
     </version>
   </versions>