Wrong encoding of non-ASCII characters in saved files
Brought to you by:
carlburch
Menu
▾
▴
#60 Wrong encoding of non-ASCII characters in saved files
Logisim has a bug when saving circuits with non-ASCII characters (in labels, component names, etc.). The XML file has a header that states it's UFT-8. However, the characters are not encoded in UTF-8, but in the "local default" charset (cp-1252 on Windows, MacRoman on MacOSX, etc.).
The bug seems to have been non-apparent prior to version 2.5, because Logisim silently re-opened the wrongly-encoded file. However in version 2.5 Logisim refuses to open such file with a message such as: "Could not open file: ...LoadFailedException: Error encountered opening ...: ...MalformedByteSequenceException: Invalid byte 1 of 3-byte UTF-8 sequence."
To reproduce the bug:
1. Create an new circuit containg a label with a non-ASCII character (for instance "é")
2. Save the file
3. Reopen the file in Logisim 2.5, the aforementioned error dialog should pop up
Thanks for the note! This is certainly a major problem. What happened was that I switched to a different library for parsing the XML (the one packaged with Java rather than a third-party library called JDOM). I only changed the code for reading - I was planning to change the code for writing in a later version.
Anyway, I certainly agree this is a major bug, and it's now at the top of my list of things to change.
Ok, I've created a preliminary version that I believe fixes this issue (as well as the other one you mentioned about generics). I've uploaded the development version under the File Manager as logisim-fragile-2.5.1.1.jar . If you'd like to try it out, I'd welcome any feedback about whether it seems to entirely solve the problem.
Addressed in 2.5.1, just released. Thanks again.