Re: [Chromium-dev] Patch for compiling with VC8

[Brian P. <bri...@tu...>]

Michael D=FCrig wrote:
>=20
> The patch attached adds support for Visual Studio 2005 (i.e. VC8).
>=20
> - When VC8 is detected in WIN_NT.MK a different set of flags is set.
> There are a lot of deprecation warnings. I choose to ignore them (/wd49=
96).
>=20
> - By default the linker produces an external manifest file. This is
> problematic for appfaker since an application fails to start when the
> manifest is not in the applications directory. I therefore added a
> further link step which embeds the manifest into the application's bina=
ry.
>=20
> - Some .def files used the DESCRIPTION keyword which is deprecated now.
> Since the description was always an empty string I removed it entirely.
>=20
> - I think it is wrong to declare cr_packer_globals DLLDATA
> (__declspec(dllimport)) in cr_pack.h/pack_init.c. After all the variabl=
e
> is exported.

I checked in your patch.  Not sure about the DLLDATA thing.  Maybe=20
another Windows user can comment.

-Brian