Re: [Chromium-dev] Texture crashes being caused by pack_texture.c rev 1.35

[Michael H. <mho...@gr...>]

This is caused by a double free.  All current implementations of 
HugePacket free the buffer internally.  I'll argue this is a bad thing 
and that the function that allocates the packet should be the one to 
free it.

-Mike

Michael Houston wrote:

> I tracked things down to pack_texture.c in the 1.35 change list which 
> is causing the texture crashes for me.  It looks like some of the 
> additions of crPackFree()'s are incorrect and freeing NULL 
> pointers...  We need to take a longer look at that change list and 
> probably back it out for now.
>
> -Mike
>
> Nathan Jeffery wrote:
>
>>
>> Thankyou all for investigating the problems, and providing feedback.
>>
>> so the problem appears to be with my setup, i'll keep investigating.
>>
>> thanks again for all the support offered, will update on progress
>>
>> Regards
>>
>> Nathan
>>
>>
>>
>> On Fri, 24 Jun 2005, Michael Houston wrote:
>>
>>> 1.8 is okay as well...  The textures seem to be working there for 
>>> me.  I'm running quake3 in a window and not full screen.  Full 
>>> screen seems to have display issues.  Not sure what's going on 
>>> there, but I remember I always had problems with the full screen 
>>> mode running through Chromium (WireGL as well).
>>>
>>> The segfaults I'm seeing crept in somewhere between 1.8 and top of 
>>> tree.  It segfaults almost immediately when loading the splash 
>>> screen (texture).
>>>
>>> -Mike
>>>
>>> Michael Houston wrote:
>>>
>>>> CR-1.7 works just fine.
>>>>
>>>> -Mike
>>>>
>>>> Brian Paul wrote:
>>>>
>>>>> Michael Houston wrote:
>>>>>
>>>>>> The crash is being caused in the pixel packing routines.  There 
>>>>>> is nothing obvious at the moment, so I'm going to backtrack 
>>>>>> through revisions until I can track down the change list.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> I made some changes in some pixel packing code a few weeks ago.  
>>>>> If you can tell me how to reproduce the problem with a small test 
>>>>> case, I can look into it (but perhaps not until next week).
>>>>>
>>>>> -Brian
>>>>>
>>>>>
>>>>> -------------------------------------------------------
>>>>> SF.Net email is sponsored by: Discover Easy Linux Migration 
>>>>> Strategies
>>>>> from IBM. Find simple to follow Roadmaps, straightforward articles,
>>>>> informative Webcasts and more! Get everything you need to get up to
>>>>> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
>>>>> _______________________________________________
>>>>> Chromium-dev mailing list
>>>>> Chr...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/chromium-dev
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> -------------------------------------------------------
>>>> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
>>>> from IBM. Find simple to follow Roadmaps, straightforward articles,
>>>> informative Webcasts and more! Get everything you need to get up to
>>>> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
>>>> _______________________________________________
>>>> Chromium-dev mailing list
>>>> Chr...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/chromium-dev
>>>
>>>
>>>
>>
>>
>> -------------------------------------------------------
>> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
>> from IBM. Find simple to follow Roadmaps, straightforward articles,
>> informative Webcasts and more! Get everything you need to get up to
>> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
>> _______________________________________________
>> Chromium-users mailing list
>> Chr...@li...
>> https://lists.sourceforge.net/lists/listinfo/chromium-users
>
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
> from IBM. Find simple to follow Roadmaps, straightforward articles,
> informative Webcasts and more! Get everything you need to get up to
> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
> _______________________________________________
> Chromium-dev mailing list
> Chr...@li...
> https://lists.sourceforge.net/lists/listinfo/chromium-dev