[Chromium-dev] Possible Fix for Tilesort + No Context + GL Calls = Crash

[<ma...@co...>]

Hi all,

We were experienceing a problem with an ill-behaved app that was calling
destroyContext(), then calling flush().

Most spu's don't seem to mind this naughtiness, but tilesort appears to crash
under these circumstances.

So here's a modification to opengl_stub/context.c in stubMakeCurrent, around
line 750 or so that seems to work...

if (!context || !window) {
	if (stub.currentContext)
		stub.currentContext->currentDrawable = NULL;
	if (context)
		context->currentDrawable = NULL;
	stub.currentContext = NULL;

	/* BP Viz Change: When making non-current, null out the funcs */
	stubSetDispatch(&stubNULLDispatch);

	return GL_TRUE;  /* OK */
}


Let me know if there are any potentially bad side-effects of this change!


Thanks,
Jon

Jonathan Marbach
BP Center for Visualization
University of Colorado