Thread: [Chromium-dev] Chromium 1.9 second release candidate

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

A second release candidate of Chromium 1.9 is ready at 
http://chromium.sf.net/beta

This just accumulates a few more bugs fixes since the first RC.

-Brian

Brian Paul wrote:
> 
> A second release candidate of Chromium 1.9 is ready at 
> http://chromium.sf.net/beta
> 
> This just accumulates a few more bugs fixes since the first RC.

I haven't seen any feedback on this, positive or negative.

It would be good to at least have a couple people confirm that they're 
tried it and it's OK.

Thanks.

-Brian

Brian Paul wrote:

> Brian Paul wrote:
>
>>
>> A second release candidate of Chromium 1.9 is ready at 
>> http://chromium.sf.net/beta
>>
>> This just accumulates a few more bugs fixes since the first RC.
>
>
> I haven't seen any feedback on this, positive or negative.
>
> It would be good to at least have a couple people confirm that they're 
> tried it and it's OK.
>
> Thanks. 

I have yet to try and build/test 1.9 on OSX, but I will get to that 
tomorrow morning.

 -Chris

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 24 May 2006, Brian Paul wrote:
> Brian Paul wrote:
>>
>> A second release candidate of Chromium 1.9 is ready at
>> http://chromium.sf.net/beta
>>
>> This just accumulates a few more bugs fixes since the first RC.
>
> I haven't seen any feedback on this, positive or negative.
>
> It would be good to at least have a couple people confirm that they're tr=
ied
> it and it's OK.
>
> Thanks.

Trying to compile cr-1.9rc2 gives:
$ make
=2E..
Compiling state_program.c
cc1: warnings being treated as errors
state_program.c: In function =E2=80=98crStateGetVertexAttribivNV=E2=80=99:
state_program.c:1042: warning: =E2=80=98floatParams[0]=E2=80=99 is used
uninitialized in this function
state_program.c:1040: warning: =E2=80=98floatParams[1]=E2=80=99 may be used
uninitialized in this function
state_program.c:1040: warning: =E2=80=98floatParams[2]=E2=80=99 may be used
uninitialized in this function
state_program.c:1040: warning: =E2=80=98floatParams[3]=E2=80=99 may be used
uninitialized in this function
gmake[2]: *** [../built/crstate/Linux/state_program.o] Error 1
gmake[1]: *** [dep] Error 2
make: *** [state_tracker.subdir] Error 2

This is with gcc 4.1.0-3 on Fedora Core 5. If I remove -Werror from
configs/Linux.mk CXXFLAGS and CFLAGS cr-1.9rc2 compiles (I have not
tried running it yet).

- -sandalle

- --
Eric Sandall                     |  Source Mage GNU/Linux Developer
er...@sa...                  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  SysAdmin @ Inst. Shock Physics @ WSU
http://counter.li.org/  #196285  |  http://www.shock.wsu.edu/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEdLHXHXt9dKjv3WERAqD4AJ96CWbDTQNe8FajqDBCHRv0LgjORQCeLaAq
JQ0D/nw6DoIAN1fzjGWtvLQ=3D
=3Dr0FJ
-----END PGP SIGNATURE-----

Eric Sandall wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>=20
> On Wed, 24 May 2006, Brian Paul wrote:
>=20
>> Brian Paul wrote:
>>
>>>
>>> A second release candidate of Chromium 1.9 is ready at
>>> http://chromium.sf.net/beta
>>>
>>> This just accumulates a few more bugs fixes since the first RC.
>>
>>
>> I haven't seen any feedback on this, positive or negative.
>>
>> It would be good to at least have a couple people confirm that they're=
=20
>> tried
>> it and it's OK.
>>
>> Thanks.
>=20
>=20
> Trying to compile cr-1.9rc2 gives:
> $ make
> ...
> Compiling state_program.c
> cc1: warnings being treated as errors
> state_program.c: In function =91crStateGetVertexAttribivNV=92:
> state_program.c:1042: warning: =91floatParams[0]=92 is used
> uninitialized in this function
> state_program.c:1040: warning: =91floatParams[1]=92 may be used
> uninitialized in this function
> state_program.c:1040: warning: =91floatParams[2]=92 may be used
> uninitialized in this function
> state_program.c:1040: warning: =91floatParams[3]=92 may be used
> uninitialized in this function
> gmake[2]: *** [../built/crstate/Linux/state_program.o] Error 1
> gmake[1]: *** [dep] Error 2
> make: *** [state_tracker.subdir] Error 2
>=20
> This is with gcc 4.1.0-3 on Fedora Core 5. If I remove -Werror from
> configs/Linux.mk CXXFLAGS and CFLAGS cr-1.9rc2 compiles (I have not
> tried running it yet).

OK, I actually fixed the same problem in a different function and=20
didn't realize there was a second instance of it.

The patch is attached.

-Brian

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 24 May 2006, Brian Paul wrote:
> Eric Sandall wrote:
>> On Wed, 24 May 2006, Brian Paul wrote:
>>> Brian Paul wrote:
>>>> A second release candidate of Chromium 1.9 is ready at
>>>> http://chromium.sf.net/beta
>>>>=20
>>>> This just accumulates a few more bugs fixes since the first RC.
>>>=20
>>> I haven't seen any feedback on this, positive or negative.
>>>=20
>>> It would be good to at least have a couple people confirm that they're=
=20
>>> tried
>>> it and it's OK.
>>>=20
>>> Thanks.
>>=20
>> Trying to compile cr-1.9rc2 gives:
>> $ make
>> ...
>> Compiling state_program.c
>> cc1: warnings being treated as errors
>> state_program.c: In function =91crStateGetVertexAttribivNV=92:
>> state_program.c:1042: warning: =91floatParams[0]=92 is used
>> uninitialized in this function
>> state_program.c:1040: warning: =91floatParams[1]=92 may be used
>> uninitialized in this function
>> state_program.c:1040: warning: =91floatParams[2]=92 may be used
>> uninitialized in this function
>> state_program.c:1040: warning: =91floatParams[3]=92 may be used
>> uninitialized in this function
>> gmake[2]: *** [../built/crstate/Linux/state_program.o] Error 1
>> gmake[1]: *** [dep] Error 2
>> make: *** [state_tracker.subdir] Error 2
>>=20
>> This is with gcc 4.1.0-3 on Fedora Core 5. If I remove -Werror from
>> configs/Linux.mk CXXFLAGS and CFLAGS cr-1.9rc2 compiles (I have not
>> tried running it yet).
>
> OK, I actually fixed the same problem in a different function and didn't=
=20
> realize there was a second instance of it.
>
> The patch is attached.

Still gives:
Rebuilding dependencies for state_program.c
Compiling state_program.c
cc1: warnings being treated as errors
state_program.c: In function =E2=80=98crStateGetVertexAttribivARB=E2=80=99:
state_program.c:1099: warning: =E2=80=98floatParams[0]=E2=80=99 is used
uninitialized in this function
state_program.c:1097: warning: =E2=80=98floatParams[1]=E2=80=99 may be used
uninitialized in this function
state_program.c:1097: warning: =E2=80=98floatParams[2]=E2=80=99 may be used
uninitialized in this function
state_program.c:1097: warning: =E2=80=98floatParams[3]=E2=80=99 may be used
uninitialized in this function
gmake[2]: *** [../built/crstate/Linux/state_program.o] Error 1
gmake[1]: *** [dep] Error 2
make: *** [state_tracker.subdir] Error 2

And again when the above is fixed:
Rebuilding dependencies for state_program.c
Compiling state_program.c
cc1: warnings being treated as errors
state_program.c: In function =E2=80=98crStateGetVertexAttribdvARB=E2=80=99:
state_program.c:1113: warning: =E2=80=98floatParams[0]=E2=80=99 is used
uninitialized in this function
state_program.c:1111: warning: =E2=80=98floatParams[1]=E2=80=99 may be used
uninitialized in this function
state_program.c:1111: warning: =E2=80=98floatParams[2]=E2=80=99 may be used
uninitialized in this function
state_program.c:1111: warning: =E2=80=98floatParams[3]=E2=80=99 may be used
uninitialized in this function
gmake[2]: *** [../built/crstate/Linux/state_program.o] Error 1
gmake[1]: *** [dep] Error 2
make: *** [state_tracker.subdir] Error 2

Seems to be fixed in CVS. Attached is a patch (after applying yours)
that fixes the other two locations.

- -sandalle

- --
Eric Sandall                     |  Source Mage GNU/Linux Developer
er...@sa...                  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  SysAdmin @ Inst. Shock Physics @ WSU
http://counter.li.org/  #196285  |  http://www.shock.wsu.edu/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEdL/THXt9dKjv3WERAgeAAJ9RfL1vAsDNGxiJ/1C3HJ9RVIdgeQCfbCNG
GAsQAuWsKhyTqe7KW3io7kY=3D
=3Dwh1q
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 24 May 2006, Michael Barnes wrote:
> All,
>
> I may have a better patch attached.  If -Werror is needed for building
> cromium, then it might be better just to shut up gcc's bogus warning
> about something that "may be used unitialized".  The flag that shuts
> this up is -Wno-uninitialized.

IMO release code shouldn't use -Werror. ;)

>> From gcc's manpage:
>
>      These warnings are made optional because GNU CC is not smart
>      enough to see all the reasons why the code might be correct
>      despite appearing to have an error.
>
> Uninitialized variables are bugs.  Warnings about them maybe being
> uninitilized being turned into errors, when they are not unitialized,
> is a waste of our time.
>
> Please consider the attached patch.
>
> The patch is against 1.8, but it should apply cleanly to 1.9.
<snip>

This may do better as I ran into another uninitialized error while
compiling 1.9rc2:

Rebuilding dependencies for wetspu_init.c
Compiling wetspu.c
cc1: warnings being treated as errors
wetspu.c: In function =E2=80=98ComputeNormal=E2=80=99:
wetspu.c:128: warning: =E2=80=98p1[2]=E2=80=99 may be used uninitialized in
this function
wetspu.c:128: warning: =E2=80=98p2[2]=E2=80=99 may be used uninitialized in
this function
wetspu.c:128: warning: =E2=80=98p3[2]=E2=80=99 may be used uninitialized in
this function
wetspu.c:128: warning: =E2=80=98p4[2]=E2=80=99 may be used uninitialized in
this function
gmake[3]: *** [../../built/wetspu/Linux/wetspu.o] Error 1
gmake[2]: *** [dep] Error 2
gmake[1]: *** [wet.subdir] Error 2
make: *** [spu.subdir] Error 2

Possibly more if I fix this one and let the compile continue. In case
we are wanting to initialize everything, a patch is attached.

- -sandalle

- --
Eric Sandall                     |  Source Mage GNU/Linux Developer
er...@sa...                  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  SysAdmin @ Inst. Shock Physics @ WSU
http://counter.li.org/  #196285  |  http://www.shock.wsu.edu/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEdNDZHXt9dKjv3WERAsVJAJ0cLf51I6PR/TXUmBxm+YL8V/F7LgCdGivF
APIugkUU0yCTO4vbOysQpNc=3D
=3DeUhr
-----END PGP SIGNATURE-----
Michael Barnes wrote:
> All,
> 
> I may have a better patch attached.  If -Werror is needed for building
> cromium, then it might be better just to shut up gcc's bogus warning
> about something that "may be used unitialized".  The flag that shuts
> this up is -Wno-uninitialized.
> 
>>From gcc's manpage:
> 
>       These warnings are made optional because GNU CC is not smart
>       enough to see all the reasons why the code might be correct
>       despite appearing to have an error.

Which version of gcc is that?  I checked the manual for a few versions 
and can't find it.

> Uninitialized variables are bugs.  Warnings about them maybe being
> uninitilized being turned into errors, when they are not unitialized,
> is a waste of our time.
> 
> Please consider the attached patch.
> 
> The patch is against 1.8, but it should apply cleanly to 1.9.

I'm thinking the simplest thing will be to only use -Werror for debug 
builds, as someone previously mentioned.

-Brian

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 24 May 2006, Brian Paul wrote:
> Brian Paul wrote:
>>=20
>> A second release candidate of Chromium 1.9 is ready at=20
>> http://chromium.sf.net/beta
>>=20
>> This just accumulates a few more bugs fixes since the first RC.
>
> I haven't seen any feedback on this, positive or negative.
>
> It would be good to at least have a couple people confirm that they're tr=
ied=20
> it and it's OK.

After applying all patches for initialization posted so far and even
with removing '-Werror' from configs/Linux.mk, I get this error
(though it did not show up earlier when I successfully built cr 1.9rc2
earlier):
Compiling tsfuncs.c
tsfuncs.c: In function =E2=80=98ts_CreateContext=E2=80=99:
tsfuncs.c:554: error: too few arguments to function
=E2=80=98tab->CreateContext=E2=80=99
tsfuncs.c: At top level:
tsfuncs.c:3726: warning: initialization from incompatible pointer type
tsfuncs.c: In function =E2=80=98ts_CreateContext=E2=80=99:
tsfuncs.c:555: warning: control reaches end of non-void function
gmake[2]: *** [../built/crfaker/Linux/tsfuncs.o] Error 1
gmake[1]: *** [dep] Error 2
make: *** [opengl_stub.subdir] Error 2

gcc 4.1.0-3 on Fedora Core 5. I've tried a 'clean' cr-1.9rc2 build
with only removing '-Werror' from CXXFLAGS and CFLAGS in
configs/Linux.mk and still receive the above.

I found the difference. If I set "THREADSAFE=3D1" in options.mk I get
the above error, but if I leave "THREADSAFE=3D0" in options.mk
cr-1.9rc2 compiles fine.

- -sandalle

- --
Eric Sandall                     |  Source Mage GNU/Linux Developer
er...@sa...                  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  SysAdmin @ Inst. Shock Physics @ WSU
http://counter.li.org/  #196285  |  http://www.shock.wsu.edu/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEdNaYHXt9dKjv3WERApuHAJ9tg69a9iPoDUaNN3LYSC5qbbtWwwCgwHqE
ItzsZTZTfznbv3wXd2eTQmE=3D
=3Dm0eg
-----END PGP SIGNATURE-----

Eric Sandall wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>=20
> On Wed, 24 May 2006, Brian Paul wrote:
>=20
>> Brian Paul wrote:
>>
>>>
>>> A second release candidate of Chromium 1.9 is ready at=20
>>> http://chromium.sf.net/beta
>>>
>>> This just accumulates a few more bugs fixes since the first RC.
>>
>>
>> I haven't seen any feedback on this, positive or negative.
>>
>> It would be good to at least have a couple people confirm that they're=
=20
>> tried it and it's OK.
>=20
>=20
> After applying all patches for initialization posted so far and even
> with removing '-Werror' from configs/Linux.mk, I get this error
> (though it did not show up earlier when I successfully built cr 1.9rc2
> earlier):
> Compiling tsfuncs.c
> tsfuncs.c: In function =91ts_CreateContext=92:
> tsfuncs.c:554: error: too few arguments to function
> =91tab->CreateContext=92
> tsfuncs.c: At top level:
> tsfuncs.c:3726: warning: initialization from incompatible pointer type
> tsfuncs.c: In function =91ts_CreateContext=92:
> tsfuncs.c:555: warning: control reaches end of non-void function
> gmake[2]: *** [../built/crfaker/Linux/tsfuncs.o] Error 1
> gmake[1]: *** [dep] Error 2
> make: *** [opengl_stub.subdir] Error 2
>=20
> gcc 4.1.0-3 on Fedora Core 5. I've tried a 'clean' cr-1.9rc2 build
> with only removing '-Werror' from CXXFLAGS and CFLAGS in
> configs/Linux.mk and still receive the above.
>=20
> I found the difference. If I set "THREADSAFE=3D1" in options.mk I get
> the above error, but if I leave "THREADSAFE=3D0" in options.mk
> cr-1.9rc2 compiles fine.

Try removing the opengl_stub/tsfuncs.c file.  It should get=20
regenerated by the tsfuncs.py script.  It looks like the .c file was=20
accidentally included in the tarball.

-Brian

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 24 May 2006, Brian Paul wrote:
> Eric Sandall wrote:
<snip>
>> After applying all patches for initialization posted so far and even
>> with removing '-Werror' from configs/Linux.mk, I get this error
>> (though it did not show up earlier when I successfully built cr 1.9rc2
>> earlier):
>> Compiling tsfuncs.c
>> tsfuncs.c: In function =91ts_CreateContext=92:
>> tsfuncs.c:554: error: too few arguments to function
>> =91tab->CreateContext=92
>> tsfuncs.c: At top level:
>> tsfuncs.c:3726: warning: initialization from incompatible pointer type
>> tsfuncs.c: In function =91ts_CreateContext=92:
>> tsfuncs.c:555: warning: control reaches end of non-void function
>> gmake[2]: *** [../built/crfaker/Linux/tsfuncs.o] Error 1
>> gmake[1]: *** [dep] Error 2
>> make: *** [opengl_stub.subdir] Error 2
>>
>> gcc 4.1.0-3 on Fedora Core 5. I've tried a 'clean' cr-1.9rc2 build
>> with only removing '-Werror' from CXXFLAGS and CFLAGS in
>> configs/Linux.mk and still receive the above.
>>
>> I found the difference. If I set "THREADSAFE=3D1" in options.mk I get
>> the above error, but if I leave "THREADSAFE=3D0" in options.mk
>> cr-1.9rc2 compiles fine.
>
> Try removing the opengl_stub/tsfuncs.c file.  It should get regenerated b=
y
> the tsfuncs.py script.  It looks like the .c file was accidentally includ=
ed
> in the tarball.

Removing opengl_stub/tsfuncs.c allowed cr-1.9rc2 to build with
THREADSAFE=3D1, thanks. :)

- -sandalle

- --
Eric Sandall                     |  Source Mage GNU/Linux Developer
er...@sa...                  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  SysAdmin @ Inst. Shock Physics @ WSU
http://counter.li.org/  #196285  |  http://www.shock.wsu.edu/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEdORuHXt9dKjv3WERArnAAJ9NnzfVzYTYf901UFAXdwhDF9on7wCgtUIp
RfysdRN0WpGzHQrpmul60/M=3D
=3DAvNb
-----END PGP SIGNATURE-----

Thread: [Chromium-dev] Chromium 1.9 second release candidate

chromium-dev