chromium-dev

[Chromium-dev] warning in dmx.c

[James S. <arr...@gm...>]

warning in dmx.c

I am getting a warning in /opt/cr/dmx/dmx.c, due to a type differnce.
I have attached a patch which fixes the problem.

Thank you for your time,
James Steven Supancic III

Re: [Chromium-dev] warning in dmx.c

[Brian P. <bri...@tu...>]

James Supancic wrote:
> warning in dmx.c
> 
> I am getting a warning in /opt/cr/dmx/dmx.c, due to a type differnce.
> I have attached a patch which fixes the problem.
> 
> Thank you for your time,
> James Steven Supancic III
> 
> 
> ------------------------------------------------------------------------
> 
> ? dmx.c.diff
> Index: dmx.c
> ===================================================================
> RCS file: /cvsroot/chromium/cr/dmx/dmx.c,v
> retrieving revision 1.1
> diff -r1.1 dmx.c
> 102c102
> < 	DMXGetScreenCount(dpy, &numScreens);
> ---
> 
>>	DMXGetScreenCount(dpy, (int*)&numScreens);
> 
> 127c127
> < 	if (!DMXGetWindowAttributes(dpy, xwin, &count, numScreens, dmxWinInfo))
> ---
> 
>>	if (!DMXGetWindowAttributes(dpy, xwin, (int*)&count, numScreens, dmxWinInfo))

Alternately, does changing "unsigned int" to "int" on line 97 silence 
the warnings?

Which compiler is this?

-Brian

Re: [Chromium-dev] warning in dmx.c

[James S. <arr...@gm...>]

> Alternately, does changing "unsigned int" to "int" on line 97 silence
> the warnings?

Yea, that gets rid of them, but now I get
dmx.c:103: warning: comparison between signed and unsigned
for
CRASSERT(numScreens == numBackendWindows);

> Which compiler is this?
gcc 4.1.1, apparently it doesn't like implicit conversions from signed
 to unsigned values...

Thank you for your time,
James Steven Supancic III

Re: [Chromium-dev] warning in dmx.c

[Brian P. <bri...@tu...>]

James Supancic wrote:
>> Alternately, does changing "unsigned int" to "int" on line 97 silence
>> the warnings?
> 
> 
> Yea, that gets rid of them, but now I get
> dmx.c:103: warning: comparison between signed and unsigned
> for
> CRASSERT(numScreens == numBackendWindows);

OK, fixed in CVS.


>> Which compiler is this?
> 
> gcc 4.1.1, apparently it doesn't like implicit conversions from signed
> to unsigned values...

g++ has complained about those in earlier versions.  I guess gcc is 
catching up.

-Brian