chromium-dev

RE: [Chromium-dev] Texture crashes being caused by pack_texture.c rev 1.35

[<bri...@tu...>]

Mike wrote:

> I tracked things down to pack_texture=2Ec in the 1=2E35 change list whic=
h is=20
> causing the texture crashes for me=2E  It looks like some of the additio=
ns=20
> of crPackFree()'s are incorrect and freeing NULL pointers=2E=2E=2E  We n=
eed to=20
> take a longer look at that change list and probably back it out for now=2E=


I think the proper fix is to simply remove the crPackFree() calls from
those functions=2E  When crHugePacket() is called, we wind up in a SPU
function like packspuHuge() or tilesortHuge() which call crPackFree()
themselves=2E

We should probably add a comment to crHugePacket() in pack_buffer=2Ec to
indicate that the caller should _not_ call crPackFree() and that it's up t=
o
the SPU routine called via pc->SendHuge() to do so=2E

-Brian


--------------------------------------------------------------------
mail2web - Check your email from the web at
http://mail2web=2Ecom/ =2E

Re: [Chromium-dev] Texture crashes being caused by pack_texture.c rev 1.35

[Michael H. <mho...@gr...>]

Actually, I think the other way around makes more sense, i.e. the caller 
allocates the packet, so I think they should have to free it as well.  I 
have a patched tree that already does this.  Most of the functions that 
use HugePacket currently issue the free...

-Mike

bri...@tu... wrote:

>Mike wrote:
>
>  
>
>>I tracked things down to pack_texture.c in the 1.35 change list which is 
>>causing the texture crashes for me.  It looks like some of the additions 
>>of crPackFree()'s are incorrect and freeing NULL pointers...  We need to 
>>take a longer look at that change list and probably back it out for now.
>>    
>>
>
>I think the proper fix is to simply remove the crPackFree() calls from
>those functions.  When crHugePacket() is called, we wind up in a SPU
>function like packspuHuge() or tilesortHuge() which call crPackFree()
>themselves.
>
>We should probably add a comment to crHugePacket() in pack_buffer.c to
>indicate that the caller should _not_ call crPackFree() and that it's up to
>the SPU routine called via pc->SendHuge() to do so.
>
>-Brian
>
>
>--------------------------------------------------------------------
>mail2web - Check your email from the web at
>http://mail2web.com/ .
>
>
>
>
>-------------------------------------------------------
>SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
>from IBM. Find simple to follow Roadmaps, straightforward articles,
>informative Webcasts and more! Get everything you need to get up to
>speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click
>_______________________________________________
>Chromium-dev mailing list
>Chr...@li...
>https://lists.sourceforge.net/lists/listinfo/chromium-dev
>  
>