Attached is a patch against 2.6.6 that enables multicast on stm32 targets. It requires MAC_ENABLE_MULTICAST to be set to TRUE in halconf.h; i've also added a default value of FALSE for that symbol because of extra CPU usage required.
Thanks for the patch. A feature like this could eventually go in the 3.0 branch, 2.6.x is closed for new features.
The only problem I can see with the patch is exposing the feature from the high level driver, while this is not guaranteed to be present on different devices. I would make it a low level setting in mcuconf.h and then export a capability key MAC_SUPPORTS_MULTICAST to the higher levels.
Giovanni
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks for the reply. If i make any more patches, i'll be sure to port and test against 3.0 before submission. Also, I can see why you'd want to expose the feature from the lld instead of the high level abstraction, it does make things cleaner.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi,
Thanks for the patch. A feature like this could eventually go in the 3.0 branch, 2.6.x is closed for new features.
The only problem I can see with the patch is exposing the feature from the high level driver, while this is not guaranteed to be present on different devices. I would make it a low level setting in mcuconf.h and then export a capability key MAC_SUPPORTS_MULTICAST to the higher levels.
Giovanni
Thanks for the reply. If i make any more patches, i'll be sure to port and test against 3.0 before submission. Also, I can see why you'd want to expose the feature from the lld instead of the high level abstraction, it does make things cleaner.